mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Sorting pages between chapters does not work #3349
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Eichiwolf on GitHub (Nov 17, 2022).
Describe the Bug
Trying to move pages from one chapter to another within a book fails without error for every user other than the global administrator.
However sorting pages within a chapter does work just fine
Steps to Reproduce
Enter Sort mode as user.
Drag page to another chapter.
Click 'Save'
BookStack reports "Book successfully re-sorted"
-> Changes are not saved
Expected Behaviour
Pages are moved to another chapter or outside a chapter
Screenshots or Additional Context
Permissions given to the user role on book level:
System Permissions: none
Asset Permissions:
Tried on production environment with NGINX proxy and fresh install without proxy
Browser Details
No response
Exact BookStack Version
v22.10.2
PHP Version
8.0.25
Hosting Environment
Docker Compose from Linuxserver.io
MariaDB 10.6.10
@ssddanbrown commented on GitHub (Nov 17, 2022):
Hi @Eichiwolf, This is likely related to #1200 and #3813.
The permissions involved in sorting are quite complex, and changes are assessed on a per-items basis, where the changes are allowed or not on per-item permissions.
Therefore, I'd imagine you're not seeing changes due to lacking permissions right now.
Based on the shared permissions, I'm guessing is lack of "Delete" permissions. Moving an item out of its original location currently requires "Delete" permission for that item.
@Eichiwolf commented on GitHub (Nov 17, 2022):
Oh that was it, thanks.
I think i tried granting every permission other than that before opening the issue.
A bit unfortunate since we planned on not giving every user delete permissions, but it'll do for now.