[PR #2899] [MERGED] Added role permissions for exporting content #6090

New Issue

OVERLORD · 2026-02-05T10:24:15+03:00

OVERLORD commented

2026-02-05 10:24:15 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2899
Author: @ssddanbrown
Created: 8/28/2021
Status: ✅ Merged
Merged: 8/28/2021
Merged by: @ssddanbrown

Base: master ← Head: export_permissions

📝 Commits (3)

eda9e89 Added role permissions for exporting content
7d9de23 Applied styleci patches
0e7166f Cleaned up DB usage in migration

📊 Changes

20 files changed (+197 additions, -36 deletions)

View changed files

📝 app/Http/Controllers/Api/BookExportApiController.php (+1 -0)
📝 app/Http/Controllers/Api/ChapterExportApiController.php (+1 -0)
📝 app/Http/Controllers/Api/PageExportApiController.php (+1 -0)
📝 app/Http/Controllers/BookExportController.php (+1 -0)
📝 app/Http/Controllers/ChapterExportController.php (+1 -0)
📝 app/Http/Controllers/PageExportController.php (+1 -0)
📝 app/Http/Kernel.php (+1 -2)
➕ app/Http/Middleware/CheckUserHasPermission.php (+38 -0)
➖ app/Http/Middleware/PermissionMiddleware.php (+0 -28)
➕ database/migrations/2021_08_28_161743_add_export_role_permission.php (+49 -0)
📝 resources/lang/en/settings.php (+1 -0)
📝 resources/views/books/show.blade.php (+3 -1)
📝 resources/views/chapters/show.blade.php (+3 -1)
📝 resources/views/pages/show.blade.php (+3 -1)
📝 resources/views/settings/roles/parts/form.blade.php (+2 -1)
📝 tests/Api/BooksApiTest.php (+13 -0)
📝 tests/Api/ChaptersApiTest.php (+13 -0)
📝 tests/Api/PagesApiTest.php (+13 -0)
📝 tests/Entity/ExportTest.php (+26 -0)
📝 tests/SharedTestHelpers.php (+26 -2)

📄 Description

Related to #2882 and #1251

Note: Need to add security notice

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2899 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 8/28/2021 **Status:** ✅ Merged **Merged:** 8/28/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `export_permissions` --- ### 📝 Commits (3) - [`eda9e89`](https://github.com/BookStackApp/BookStack/commit/eda9e89c55caf6a98ab57a084d1ce03e0c5fe993) Added role permissions for exporting content - [`7d9de23`](https://github.com/BookStackApp/BookStack/commit/7d9de23a25a5a055adf79e81f67768686f3a8c94) Applied styleci patches - [`0e7166f`](https://github.com/BookStackApp/BookStack/commit/0e7166f7f60a98030ca00273bbd12730893d4241) Cleaned up DB usage in migration ### 📊 Changes **20 files changed** (+197 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Api/BookExportApiController.php` (+1 -0) 📝 `app/Http/Controllers/Api/ChapterExportApiController.php` (+1 -0) 📝 `app/Http/Controllers/Api/PageExportApiController.php` (+1 -0) 📝 `app/Http/Controllers/BookExportController.php` (+1 -0) 📝 `app/Http/Controllers/ChapterExportController.php` (+1 -0) 📝 `app/Http/Controllers/PageExportController.php` (+1 -0) 📝 `app/Http/Kernel.php` (+1 -2) ➕ `app/Http/Middleware/CheckUserHasPermission.php` (+38 -0) ➖ `app/Http/Middleware/PermissionMiddleware.php` (+0 -28) ➕ `database/migrations/2021_08_28_161743_add_export_role_permission.php` (+49 -0) 📝 `resources/lang/en/settings.php` (+1 -0) 📝 `resources/views/books/show.blade.php` (+3 -1) 📝 `resources/views/chapters/show.blade.php` (+3 -1) 📝 `resources/views/pages/show.blade.php` (+3 -1) 📝 `resources/views/settings/roles/parts/form.blade.php` (+2 -1) 📝 `tests/Api/BooksApiTest.php` (+13 -0) 📝 `tests/Api/ChaptersApiTest.php` (+13 -0) 📝 `tests/Api/PagesApiTest.php` (+13 -0) 📝 `tests/Entity/ExportTest.php` (+26 -0) 📝 `tests/SharedTestHelpers.php` (+26 -2) </details> ### 📄 Description Related to #2882 and #1251 --- Note: Need to add security notice --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:24:15 +03:00

OVERLORD closed this issue

2026-02-05 10:24:17 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6090