mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Update notifications to make dismissal more intuitive #1251
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @flonology on GitHub (Jul 5, 2019).
Originally assigned to: @james-geiger on GitHub.
Describe the bug
While editing a draft, the dialogue stays over the "Save Page" button and does not go away
Expected behavior
The dialogue should go away or stay in a place which lets the "Save Page" be visible.
Screenshots
Your Configuration:
@ssddanbrown commented on GitHub (Jul 5, 2019):
Hi @flonology,
Does the message not go away if you click on it?
Success messages are made to auto-disappear, Since their purpose is affirmation of an event and does not have any consequences whereas warnings & errors will stay around until dismissed since it's more important that they're read.
@flonology commented on GitHub (Sep 6, 2019):
Hi, sorry for the late reply – yes, it disappears when I click it! I just wasn’t aware that I could. After knowing that it seems so obvious (cursor changes to hand etc.). Maybe I was too focused on finding any X (to close) but I do not see any problem anymore ;-)
@ssddanbrown commented on GitHub (Sep 7, 2019):
@flonology Thanks for the response.
It's probably a good idea if we add a close icon to the notification, To make it obvious it can be dismissed. I'll re-open this and mark it for the next feature release.
@james-geiger commented on GitHub (Dec 9, 2019):
@ssddanbrown Is this still open? Happy to take it.
@ssddanbrown commented on GitHub (Dec 11, 2019):
@james-geiger Yeah, Still open, Go for it, would be a big help. Thanks!
Have assigned to you but no pressure, Just shout if you want to be un-assigned for any reason.
@james-geiger commented on GitHub (Dec 12, 2019):
I've been playing around with this, and it seems like a dedicated dismiss button would be "just for show" unless we removed the click-to-dismiss feature from the notification and forced users to click the close button.
My thought to keep things looking clean is just to add auto-hide for errors and warnings with a 5-10 second timeout.
Thoughts, @ssddanbrown & @flonology?
@ssddanbrown commented on GitHub (Dec 16, 2019):
@james-geiger I'd totally vote for the dismiss button that's "just for show". Although it would not actually function itself, it would still act as an intuitive target for the user to click.
I'm generally adverse to auto-hiding warning and error messages since they should generally be things the user should be aware of, and I personally find it really frustrating when a message zooms off while I'm in the middle to trying to understand what it says.
@ssddanbrown commented on GitHub (Jan 19, 2020):
This is now closed as of #1845. Will be in the next release.