starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-13 11:19:37 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #1926] [CLOSED] WIP: SAML SingleLogoutService Updates #5926

New Issue
Closed
opened 2026-02-05 10:20:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:20:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1926
Author: @SoarinFerret
Created: 3/1/2020
Status: ❌ Closed

Base: master ← Head: signed-sls

📝 Commits (10+)

  • 9d6f574 Updated attachment tests to align with front-end changes
  • 3bfd26b Converted the page editor from vue to component
  • b383f57 Tweaked dropdown shadows a tad
  • b6aa232 Fixed issue where more images than expected could be deleted
  • 02dc315 Converted image-manager to be component/HTML based
  • 2bacc3c Removed vuejs from the project
  • 03211eb Removed unused tinymce imagetools plugin
  • 8213ea9 Fixed issue where URL params in image names would cause loading failure
  • a46b248 Fixed some image manager behaviour
  • f5fefbd Removed a few remaining vue references

📊 Changes

788 files changed (+34563 additions, -15914 deletions)

View changed files

📝 .env.example (+22 -9)
📝 .env.example.complete (+40 -4)
➕ .github/FUNDING.yml (+3 -0)
➕ .github/ISSUE_TEMPLATE/api_request.md (+17 -0)
📝 .github/translators.txt (+65 -2)
📝 .github/workflows/phpunit.yml (+5 -1)
➕ .github/workflows/test-migrations.yml (+58 -0)
📝 app/Actions/Activity.php (+21 -14)
📝 app/Actions/ActivityService.php (+87 -81)
➕ app/Actions/ActivityType.php (+51 -0)
📝 app/Actions/Comment.php (+15 -7)
📝 app/Actions/CommentRepo.php (+36 -31)
📝 app/Actions/Tag.php (+1 -4)
📝 app/Actions/TagRepo.php (+20 -70)
📝 app/Actions/ViewService.php (+20 -18)
📝 app/Api/ApiDocsGenerator.php (+23 -2)
📝 app/Api/ApiToken.php (+19 -1)
📝 app/Api/ListingResponseBuilder.php (+18 -15)
📝 app/Auth/Access/ExternalAuthService.php (+4 -10)
📝 app/Auth/Access/Guards/ExternalBaseSessionGuard.php (+0 -2)

...and 80 more files

📄 Description

Patch for #1925

I provided fixes to allow .env vars for the following:

  • SAML2_SP_x509 - This is the x509 certificate for use in signing SAML requests / responses sent to IDP
  • SAML2_SP_PRIVATEKEY - Corresponding private key for above
  • SAML2_SLS_SIGNED_REQUEST - Option to enable or disable signing Single Logout Service requests. Required for SLS on ADFS
  • SAML2_SLS_SIGNED_RESPONSE - Option to enable or disable signing Single Logout Service responses. Required for SLS on ADFS

I'm still working on trying to figure out how to ensure the SLS responses are crafted properly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1926 **Author:** [@SoarinFerret](https://github.com/SoarinFerret) **Created:** 3/1/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `signed-sls` --- ### 📝 Commits (10+) - [`9d6f574`](https://github.com/BookStackApp/BookStack/commit/9d6f574494ced900c1e59a5f292d9efd76edccc8) Updated attachment tests to align with front-end changes - [`3bfd26b`](https://github.com/BookStackApp/BookStack/commit/3bfd26bf86ebf2d325bbb90b2a2879aa5d33f95b) Converted the page editor from vue to component - [`b383f57`](https://github.com/BookStackApp/BookStack/commit/b383f5776d6246470e44d8af0c9f520db91870a2) Tweaked dropdown shadows a tad - [`b6aa232`](https://github.com/BookStackApp/BookStack/commit/b6aa232205d1f889be95a57e76ac391023e00bfd) Fixed issue where more images than expected could be deleted - [`02dc315`](https://github.com/BookStackApp/BookStack/commit/02dc3154e34775f44b4f38b525224a2354aa698c) Converted image-manager to be component/HTML based - [`2bacc3c`](https://github.com/BookStackApp/BookStack/commit/2bacc3c967885fb7de93ba824ff6e3a0e78a08dc) Removed vuejs from the project - [`03211eb`](https://github.com/BookStackApp/BookStack/commit/03211ebea6b26b29ad2c28a9833c61a4ff9581a4) Removed unused tinymce imagetools plugin - [`8213ea9`](https://github.com/BookStackApp/BookStack/commit/8213ea9a7182df48ac9c12bb7b74098b5ad665a4) Fixed issue where URL params in image names would cause loading failure - [`a46b248`](https://github.com/BookStackApp/BookStack/commit/a46b248cf4ff3213a8bef8d8c60e623ea4beeab4) Fixed some image manager behaviour - [`f5fefbd`](https://github.com/BookStackApp/BookStack/commit/f5fefbdb06af5e8711bf6bef7cbc558cf922069a) Removed a few remaining vue references ### 📊 Changes **788 files changed** (+34563 additions, -15914 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+22 -9) 📝 `.env.example.complete` (+40 -4) ➕ `.github/FUNDING.yml` (+3 -0) ➕ `.github/ISSUE_TEMPLATE/api_request.md` (+17 -0) 📝 `.github/translators.txt` (+65 -2) 📝 `.github/workflows/phpunit.yml` (+5 -1) ➕ `.github/workflows/test-migrations.yml` (+58 -0) 📝 `app/Actions/Activity.php` (+21 -14) 📝 `app/Actions/ActivityService.php` (+87 -81) ➕ `app/Actions/ActivityType.php` (+51 -0) 📝 `app/Actions/Comment.php` (+15 -7) 📝 `app/Actions/CommentRepo.php` (+36 -31) 📝 `app/Actions/Tag.php` (+1 -4) 📝 `app/Actions/TagRepo.php` (+20 -70) 📝 `app/Actions/ViewService.php` (+20 -18) 📝 `app/Api/ApiDocsGenerator.php` (+23 -2) 📝 `app/Api/ApiToken.php` (+19 -1) 📝 `app/Api/ListingResponseBuilder.php` (+18 -15) 📝 `app/Auth/Access/ExternalAuthService.php` (+4 -10) 📝 `app/Auth/Access/Guards/ExternalBaseSessionGuard.php` (+0 -2) _...and 80 more files_ </details> ### 📄 Description Patch for #1925 I provided fixes to allow `.env` vars for the following: * `SAML2_SP_x509` - This is the x509 certificate for use in signing SAML requests / responses sent to IDP * `SAML2_SP_PRIVATEKEY` - Corresponding private key for above * `SAML2_SLS_SIGNED_REQUEST` - Option to enable or disable signing Single Logout Service requests. Required for SLS on ADFS * `SAML2_SLS_SIGNED_RESPONSE` - Option to enable or disable signing Single Logout Service responses. Required for SLS on ADFS I'm still working on trying to figure out how to ensure the SLS responses are crafted properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:20:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5926
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?