mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Maintenance > Cleanup Images: Wording is ambiguous #1925
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Wookbert on GitHub (Nov 3, 2020).
a)„ignore the images in earlier versions of the pages, so leave them untouched and do NOT delete them“ and
b) „don't give a sh*t about these images and earlier versions of the pages, just delete them, regardless to what that means, when one wants/needs to revert to an earlier page version!“ (which is what this option actually does)
In order to make this option less ambiguous, I would retitle it to: „Also delete images only found in previous page revisions“ (or in german: „Bilder, die nur in vorherigen Seiten-Versionen vorkommen, ebenfalls löschen“)
@ssddanbrown commented on GitHub (Nov 13, 2020):
Thanks again for reporting @Wookbert.
I totally agree, My wording here it terrible. Marked to be changed for next release.
@Wookbert commented on GitHub (Nov 13, 2020):
I wonder if this „Delete Images from previous page versions“ option should/could be a bit smarter, e.g. so that one can revert to at least a/the last version with images still in tact. Would require a bit of thinking...
@ssddanbrown commented on GitHub (Dec 19, 2020):
Now updated in
4e82d93350ready for next release so will therefore close. Thanks again @Wookbert.That could be a smart idea, probably best to do it based on time (Revisions in the last x days rather than last revision) but I think that'd be optimizing a corner of the system that has little traffic.