[PR #1317] [MERGED] Issue #1306 - Allow custom name attribute in LDAP #5800

Closed
opened 2026-02-05 10:17:24 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1317
Author: @dfanara
Created: 3/9/2019
Status: Merged
Merged: 3/10/2019
Merged by: @ssddanbrown

Base: masterHead: feature-ldap-attributes


📝 Commits (3)

  • 55b07c7 Issue #1306 - Specify display name attribute from LDAP
  • 502ea60 Issue #1306 - Unit Tests for LdapService Changes
  • 6d20bdc Preserve original display_name_attribute configuration values.

📊 Changes

4 files changed (+84 additions, -2 deletions)

View changed files

📝 .env.example.complete (+1 -0)
📝 app/Auth/Access/LdapService.php (+4 -2)
📝 config/services.php (+1 -0)
📝 tests/Auth/LdapTest.php (+78 -0)

📄 Description

Adds the ability to configure which attribute is mapped to the display name of the user.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1317 **Author:** [@dfanara](https://github.com/dfanara) **Created:** 3/9/2019 **Status:** ✅ Merged **Merged:** 3/10/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `feature-ldap-attributes` --- ### 📝 Commits (3) - [`55b07c7`](https://github.com/BookStackApp/BookStack/commit/55b07c7076d3296116714470ea53d75f69cb4387) Issue #1306 - Specify display name attribute from LDAP - [`502ea60`](https://github.com/BookStackApp/BookStack/commit/502ea608bf2387a0bc928eb1cb521809920309c2) Issue #1306 - Unit Tests for LdapService Changes - [`6d20bdc`](https://github.com/BookStackApp/BookStack/commit/6d20bdc1fbb4da20e7f5c40c0beafcafc296a18d) Preserve original display_name_attribute configuration values. ### 📊 Changes **4 files changed** (+84 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+1 -0) 📝 `app/Auth/Access/LdapService.php` (+4 -2) 📝 `config/services.php` (+1 -0) 📝 `tests/Auth/LdapTest.php` (+78 -0) </details> ### 📄 Description Adds the ability to configure which attribute is mapped to the display name of the user. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:17:24 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5800