starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

Image manager/Gallery Shows no pictures when pointerdown event is bound in header. Prevents adding images. #1306

New Issue
Closed
opened 2026-02-05 00:33:50 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-05 00:33:50 +03:00
Owner
Copy Link

Originally created by @eceforge on GitHub (Aug 18, 2019).

Describe the bug
I noticed that Images that were already on a page still display just fine, and images that get uploaded exist when I go dig in the docker storage volume -- it's just that the image manager doesn't show anything -- even immediately after a "successful" upload. Attachments work fine, its just images.
Everything appears just fine on upload including the "image upload successfully" notification but images didn't appear in the image manager.

Turns out the image manager relies on the click event to start loading the images -- and I had foolishly bound the pointerdown event listener in the header in an attempt to get a reasonable update rate when using KaTeX (which would btw be a fantastic default feature).

Not really a bug per say -- I started writing this bug before I had figured out what happened but I figured this might help someone else that is having a similar issue.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Not know any better and add an event listener for the pointerdown event to render math while editing a page.
  2. Edit any page
  3. Click on 'insert image'
  4. Image Select dialog comes up, but no images are shown

Expected behavior
Images from the wiki including images that have just been uploaded with the image upload feature should be shown here for adding to the page.

Screenshots
It's just a blank Image Select dialog.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): v0.26.2
  • PHP Version: 7.1.30
  • Hosting Method (Nginx/Apache/Docker): Docker (solidnerd)

Additional context

Originally created by @eceforge on GitHub (Aug 18, 2019). **Describe the bug** I noticed that Images that were already on a page still display just fine, and images that get uploaded exist when I go dig in the docker storage volume -- it's just that the image manager doesn't show anything -- even immediately after a "successful" upload. Attachments work fine, its just images. Everything appears just fine on upload including the "image upload successfully" notification but images didn't appear in the image manager. Turns out the image manager relies on the click event to start loading the images -- and I had foolishly bound the pointerdown event listener in the header in an attempt to get a reasonable update rate when using KaTeX (which would btw be a fantastic default feature). Not really a bug per say -- I started writing this bug before I had figured out what happened but I figured this might help someone else that is having a similar issue. **Steps To Reproduce** Steps to reproduce the behavior: 1. Not know any better and add an event listener for the pointerdown event to render math while editing a page. 1. Edit any page 2. Click on 'insert image' 3. Image Select dialog comes up, but no images are shown **Expected behavior** Images from the wiki including images that have just been uploaded with the image upload feature should be shown here for adding to the page. **Screenshots** It's just a blank Image Select dialog. **Your Configuration (please complete the following information):** - Exact BookStack Version (Found in settings): v0.26.2 - PHP Version: 7.1.30 - Hosting Method (Nginx/Apache/Docker): Docker (solidnerd) **Additional context**
OVERLORD commented 2026-02-05 00:33:54 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Jun 6, 2021):

Thanks for noting for others, Will therefore close this off.

@ssddanbrown commented on GitHub (Jun 6, 2021): Thanks for noting for others, Will therefore close this off.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#1306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?