[PR #906] [MERGED] Fixes issue with code not wrapping on revision page. #5733

New Issue

OVERLORD · 2026-02-05T10:15:38+03:00

OVERLORD commented

2026-02-05 10:15:38 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/906
Author: @Abijeet
Created: 6/30/2018
Status: ✅ Merged
Merged: 7/1/2018
Merged by: @ssddanbrown

Base: master ← Head: bug/revision-wrap

📝 Commits (1)

fb29f41 Fixes issue with code not wrapping on revision page.

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 resources/assets/sass/_pages.scss (+6 -0)
📝 resources/views/pages/revision.blade.php (+1 -1)

📄 Description

Closes #888

See image below,

Also tested PDF export and HTML export. The same CSS are applied to the pre code section but Dompdf does not seem to support white-space: pre-wrap whereas wkhtmltopdf does.

wkhtmltopdf - test-page-wkhtmltopdf.pdf
Dompdf - test-page-dom-pdf.pdf

Signed-off-by: Abijeet abijeetpatro@gmail.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/906 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 6/30/2018 **Status:** ✅ Merged **Merged:** 7/1/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `bug/revision-wrap` --- ### 📝 Commits (1) - [`fb29f41`](https://github.com/BookStackApp/BookStack/commit/fb29f4119d430cc8d040ba5d7c5d5d084937cf32) Fixes issue with code not wrapping on revision page. ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/sass/_pages.scss` (+6 -0) 📝 `resources/views/pages/revision.blade.php` (+1 -1) </details> ### 📄 Description Closes #888 See image below, ![image](https://user-images.githubusercontent.com/1685517/42121359-277e2c04-7c4b-11e8-8675-971a5d5da262.png) Also tested PDF export and HTML export. The same CSS are applied to the `pre code` section but Dompdf does not seem to support `white-space: pre-wrap` whereas wkhtmltopdf does. - wkhtmltopdf - [test-page-wkhtmltopdf.pdf](https://github.com/BookStackApp/BookStack/files/2151410/test-page-wkhtmltopdf.pdf) - Dompdf - [test-page-dom-pdf.pdf](https://github.com/BookStackApp/BookStack/files/2151411/test-page-dom-pdf.pdf) Signed-off-by: Abijeet <abijeetpatro@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:15:38 +03:00

OVERLORD closed this issue

2026-02-05 10:15:42 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5733