[PR #438] [MERGED] Support new lines for book/chapter descriptions + fix tests #5648

New Issue

OVERLORD · 2026-02-05T10:13:14+03:00

OVERLORD commented

2026-02-05 10:13:14 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/438
Author: @clemblanco
Created: 7/14/2017
Status: ✅ Merged
Merged: 7/27/2017
Merged by: @ssddanbrown

Base: master ← Head: master

📝 Commits (10+)

67bc700 Support new lines for book/chapter descriptions
711dcb4 Update travis.yml to try and solve the test issue around LDAP.
265ed34 Update travis.yml to try and solve the test issue around LDAP.
ae2ec43 Avoid having to wait until all tests are processed to exit upon error/failure.
0d98b4c Trying to make the tests green.
5eeed03 Trying to make the tests green.
afc56c1 Trying to make the tests green.
3b771f2 Trying to make the tests green.
6ef522d Trying to make the tests green.
684c20c Trying to make the tests green.

📊 Changes

4 files changed (+18 additions, -6 deletions)

View changed files

📝 .travis.yml (+10 -1)
📝 resources/views/books/show.blade.php (+3 -3)
📝 resources/views/chapters/show.blade.php (+1 -1)
📝 tests/Auth/LdapTest.php (+4 -1)

📄 Description

Avoid ignoring new lines when renderring the book/chapter descriptions on their respective detailed views.

And fixing the tests too (LDAP needs to be installed before running the LDAP tests).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/438 **Author:** [@clemblanco](https://github.com/clemblanco) **Created:** 7/14/2017 **Status:** ✅ Merged **Merged:** 7/27/2017 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`67bc700`](https://github.com/BookStackApp/BookStack/commit/67bc7007aa58cbb44801f3df1d1f98ae3f8e2c64) Support new lines for book/chapter descriptions - [`711dcb4`](https://github.com/BookStackApp/BookStack/commit/711dcb4a4834a562bcdb36c7dac17964e93f38a6) Update travis.yml to try and solve the test issue around LDAP. - [`265ed34`](https://github.com/BookStackApp/BookStack/commit/265ed34ffd49f199fe78e571a242eae39a4ea7bf) Update travis.yml to try and solve the test issue around LDAP. - [`ae2ec43`](https://github.com/BookStackApp/BookStack/commit/ae2ec43a826c92d96ae33388eba3d1599dc598e9) Avoid having to wait until all tests are processed to exit upon error/failure. - [`0d98b4c`](https://github.com/BookStackApp/BookStack/commit/0d98b4ce5e4176ef4f31a5374964c054c48048db) Trying to make the tests green. - [`5eeed03`](https://github.com/BookStackApp/BookStack/commit/5eeed03dcded3d024ac719599da250444bb87ac8) Trying to make the tests green. - [`afc56c1`](https://github.com/BookStackApp/BookStack/commit/afc56c12fe02e4a1947b22b1858f6b2662e9bd80) Trying to make the tests green. - [`3b771f2`](https://github.com/BookStackApp/BookStack/commit/3b771f2976e3272e77faaf1f5aed06d66aefd48e) Trying to make the tests green. - [`6ef522d`](https://github.com/BookStackApp/BookStack/commit/6ef522df7ec8b43f484461e7690b08196d3585c1) Trying to make the tests green. - [`684c20c`](https://github.com/BookStackApp/BookStack/commit/684c20c4ea186876afb4aa84115773d032d7063b) Trying to make the tests green. ### 📊 Changes **4 files changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+10 -1) 📝 `resources/views/books/show.blade.php` (+3 -3) 📝 `resources/views/chapters/show.blade.php` (+1 -1) 📝 `tests/Auth/LdapTest.php` (+4 -1) </details> ### 📄 Description Avoid ignoring new lines when renderring the book/chapter descriptions on their respective detailed views. And fixing the tests too (LDAP needs to be installed before running the LDAP tests). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:13:14 +03:00

OVERLORD closed this issue

2026-02-05 10:13:16 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5648