Two-factor authentication #438

Closed
opened 2026-02-04 19:59:21 +03:00 by OVERLORD · 14 comments
Owner

Originally created by @genxlee on GitHub (Sep 19, 2017).

^

Originally created by @genxlee on GitHub (Sep 19, 2017). ^
OVERLORD added the 🔨 Feature Request🚪 Authentication labels 2026-02-04 19:59:21 +03:00
Author
Owner

@s0n- commented on GitHub (Sep 22, 2017):

Do you use a specific 2 factor vendor? I know I have requested Okta or SSO support.

@s0n- commented on GitHub (Sep 22, 2017): Do you use a specific 2 factor vendor? I know I have requested Okta or SSO support.
Author
Owner

@adambirds commented on GitHub (Sep 28, 2017):

This is definitely needed, if it could be compatible with Google Authenticator that would be great.

@adambirds commented on GitHub (Sep 28, 2017): This is definitely needed, if it could be compatible with Google Authenticator that would be great.
Author
Owner

@Flemming-H commented on GitHub (Sep 28, 2018):

Hi

2-factor with Google Authenticator is a great idea

@Flemming-H commented on GitHub (Sep 28, 2018): Hi 2-factor with Google Authenticator is a great idea
Author
Owner

@lwl12 commented on GitHub (Dec 8, 2018):

Need it too!

@lwl12 commented on GitHub (Dec 8, 2018): Need it too!
Author
Owner

@guenth commented on GitHub (Dec 21, 2018):

Google auth (so it's compatible with authy) would be wonderful!

@guenth commented on GitHub (Dec 21, 2018): Google auth (so it's compatible with authy) would be wonderful!
Author
Owner

@lwl12 commented on GitHub (Dec 21, 2018):

Google auth (so it's compatible with authy) would be wonderful!

Actually, they are all based on TOTP, so just use this protocol and we can use it in many APPs~

@lwl12 commented on GitHub (Dec 21, 2018): > Google auth (so it's compatible with authy) would be wonderful! Actually, they are all based on [TOTP](https://en.wikipedia.org/wiki/Time-based_One-time_Password_algorithm), so just use this protocol and we can use it in many APPs~
Author
Owner

@fourthdimension commented on GitHub (Feb 7, 2019):

This would be a great feature!

@fourthdimension commented on GitHub (Feb 7, 2019): This would be a great feature!
Author
Owner

@cyclinggeorgian commented on GitHub (Sep 22, 2019):

Google auth (so it's compatible with authy) would be wonderful!

Actually, they are all based on TOTP, so just use this protocol and we can use it in many APPs~

Definitely voting on TOTP implementation. This would be great enhancement to the security of the whole platform. And just think of all the popularity points project going to score with this implementation :-).

@cyclinggeorgian commented on GitHub (Sep 22, 2019): > > Google auth (so it's compatible with authy) would be wonderful! > > Actually, they are all based on [TOTP](https://en.wikipedia.org/wiki/Time-based_One-time_Password_algorithm), so just use this protocol and we can use it in many APPs~ Definitely voting on TOTP implementation. This would be great enhancement to the security of the whole platform. And just think of all the popularity points project going to score with this implementation :-).
Author
Owner

@Cave-Johnson commented on GitHub (Sep 22, 2019):

Would definitely like to add my +1 to TOTP support

@Cave-Johnson commented on GitHub (Sep 22, 2019): Would definitely like to add my +1 to TOTP support
Author
Owner

@Cave-Johnson commented on GitHub (Oct 24, 2019):

Came across this project recently, could this be implemented to deliver TOTP support?

https://github.com/Spomky-Labs/otphp

@Cave-Johnson commented on GitHub (Oct 24, 2019): Came across this project recently, could this be implemented to deliver TOTP support? https://github.com/Spomky-Labs/otphp
Author
Owner

@ssddanbrown commented on GitHub (Mar 13, 2020):

Just to flesh this out a little further, What kind of controls would you want for 2FA? For example, would you want to force 2FA on all users? Let users decide? User-level control by admins? Something else?

Not looking for extra ideal, just want to know what you'd specifically want for your environment(s).

I'm assuming, for new users and for newly-admin-enabled-2fa users, we'd force a "Setup 2FA" step upon login?

We we need to implement a backup system? Or would an admin CLI command suffice to disable 2FA for system/specfiic-account suffice in scenarios where access is lost.

@ssddanbrown commented on GitHub (Mar 13, 2020): Just to flesh this out a little further, What kind of controls would you want for 2FA? For example, would you want to force 2FA on all users? Let users decide? User-level control by admins? Something else? Not looking for extra ideal, just want to know what you'd specifically want for your environment(s). I'm assuming, for new users and for newly-admin-enabled-2fa users, we'd force a "Setup 2FA" step upon login? We we need to implement a backup system? Or would an admin CLI command suffice to disable 2FA for system/specfiic-account suffice in scenarios where access is lost.
Author
Owner

@fourthdimension commented on GitHub (Mar 13, 2020):

Should be implemented system wide for all users. Let the admin decide to
enable or disable. Users would not have control over enabling or disabling.
It would be best to force setup of 2fa upon login. CLI command would
suffice where access is lost, for now.

Hope this helps to understand our environment better.

Dru

On Thu, Mar 12, 2020, 6:48 PM Dan Brown notifications@github.com wrote:

Just to flesh this out a little further, What kind of controls would you
want for 2FA? For example, would you want to force 2FA on all users? Let
users decide? User-level control by admins? Something else?

Not looking for extra ideal, just want to know what you'd specifically
want for your environment(s).

I'm assuming, for new users and for newly-admin-enabled-2fa users, we'd
force a "Setup 2FA" step upon login?

We we need to implement a backup system? Or would an admin CLI command
suffice to disable 2FA for system/specfiic-account suffice in scenarios
where access is lost.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BookStackApp/BookStack/issues/516#issuecomment-598465723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGGONBTEXV7NEXZ5OAB4ILRHFRDBANCNFSM4D3QI3DQ
.

@fourthdimension commented on GitHub (Mar 13, 2020): Should be implemented system wide for all users. Let the admin decide to enable or disable. Users would not have control over enabling or disabling. It would be best to force setup of 2fa upon login. CLI command would suffice where access is lost, for now. Hope this helps to understand our environment better. Dru On Thu, Mar 12, 2020, 6:48 PM Dan Brown <notifications@github.com> wrote: > Just to flesh this out a little further, What kind of controls would you > want for 2FA? For example, would you want to force 2FA on all users? Let > users decide? User-level control by admins? Something else? > > Not looking for extra ideal, just want to know what you'd specifically > want for your environment(s). > > I'm assuming, for new users and for newly-admin-enabled-2fa users, we'd > force a "Setup 2FA" step upon login? > > We we need to implement a backup system? Or would an admin CLI command > suffice to disable 2FA for system/specfiic-account suffice in scenarios > where access is lost. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/BookStackApp/BookStack/issues/516#issuecomment-598465723>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGGONBTEXV7NEXZ5OAB4ILRHFRDBANCNFSM4D3QI3DQ> > . >
Author
Owner

@ssddanbrown commented on GitHub (Apr 8, 2020):

Thanks for the input @fourthdimension.

@ssddanbrown commented on GitHub (Apr 8, 2020): Thanks for the input @fourthdimension.
Author
Owner

@ssddanbrown commented on GitHub (Apr 8, 2020):

Realized we have duplicate issues for this, Will close this off in favour of #1118. Although this was the original, #1118 has more up-votes to indicate user-need and therefore more likely to be looked at when choosing features to implement.

For any further comments, please add them to #1118.

@ssddanbrown commented on GitHub (Apr 8, 2020): Realized we have duplicate issues for this, Will close this off in favour of #1118. Although this was the original, #1118 has more up-votes to indicate user-need and therefore more likely to be looked at when choosing features to implement. For any further comments, please add them to #1118.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#438