mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 19:06:02 +03:00
Images with exif orientation set fail may not be orientated correctly #5165
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Jan 31, 2025).
Originally assigned to: @ssddanbrown on GitHub.
We are specifically setting rotation based upon exif via our own custom means:
387c786768/app/Uploads/ImageResizer.php (L178-L186)This can now lead to images being wrongly rotated, due to changes in intervention 3 which would apply orientation by default, leading to the the orientation being applied double.
This is mentioned in the upgrade notes, but quite easy to miss which I did.
Somewhat related to some of the newer comments in #4875.
@ssddanbrown commented on GitHub (Feb 1, 2025):
Changes made in
4f5f7c10b1and part of #5463 to be merged for the next patch/feature.