starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

Shelf permissions are copied to existing books when books on the shelf are added/removed #5463

New Issue
Closed
opened 2026-02-05 10:05:06 +03:00 by OVERLORD · 5 comments
OVERLORD commented 2026-02-05 10:05:06 +03:00
Owner
Copy Link

Originally created by @rozdun on GitHub (Oct 18, 2025).

Describe the Bug

Shelf permissions are copied to existing books when books on the shelf are added/removed or when the shelf is edited (e.g. changing the description).

Steps to Reproduce

  1. Create a shelf.
  2. Create two books on the shelf and set custom permissions there.
  3. Do any of the following:
  • Create a third book on the shelf.
  • Create a new book outside the shelf, and then move it to the shelf.
  • Remove one book from the shelf (move to another shelf or no shelf).
  • Edit the shelf (change the description).

Expected Behaviour

  • Existing books on the shelf use their custom permissions, not the shelf permissions.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v25.05.1

Originally created by @rozdun on GitHub (Oct 18, 2025). ### Describe the Bug Shelf permissions are copied to existing books when books on the shelf are added/removed or when the shelf is edited (e.g. changing the description). ### Steps to Reproduce 1. Create a shelf. 2. Create two books on the shelf and set custom permissions there. 3. Do any of the following: - Create a third book on the shelf. - Create a new book outside the shelf, and then move it to the shelf. - Remove one book from the shelf (move to another shelf or no shelf). - Edit the shelf (change the description). ### Expected Behaviour - Existing books on the shelf use their custom permissions, not the shelf permissions. ### Screenshots or Additional Context _No response_ ### Browser Details _No response_ ### Exact BookStack Version v25.05.1
OVERLORD added the 🐕 Support label 2026-02-05 10:05:06 +03:00
OVERLORD commented 2026-02-05 10:05:09 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Oct 18, 2025):

Hi @rozdun,

Do you have any customizations active, or an APP_THEME option set in your BookStack .env file?

@ssddanbrown commented on GitHub (Oct 18, 2025): Hi @rozdun, Do you have any customizations active, or an `APP_THEME` option set in your BookStack `.env` file?
OVERLORD commented 2026-02-05 10:05:11 +03:00
Author
Owner
Copy Link

@rozdun commented on GitHub (Oct 19, 2025):

Indeed I had active customizations I wasn't aware of. Thank you!

@rozdun commented on GitHub (Oct 19, 2025): Indeed I had active customizations I wasn't aware of. Thank you!
OVERLORD commented 2026-02-05 10:05:12 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Oct 19, 2025):

@ssddanbrown No worries. Just to confirm, I'm assuming you found a customization that was resulting in this behaviour, and therefore this is now solved?

@ssddanbrown commented on GitHub (Oct 19, 2025): @ssddanbrown No worries. Just to confirm, I'm assuming you found a customization that was resulting in this behaviour, and therefore this is now solved?
OVERLORD commented 2026-02-05 10:05:13 +03:00
Author
Owner
Copy Link

@rozdun commented on GitHub (Oct 19, 2025):

Yes, this is solved. There was a webhook that copied permissions onto books, and because I was not the one who set up our instance, I wasn't aware of it.

@rozdun commented on GitHub (Oct 19, 2025): Yes, this is solved. There was a webhook that copied permissions onto books, and because I was not the one who set up our instance, I wasn't aware of it.
OVERLORD commented 2026-02-05 10:05:14 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Oct 21, 2025):

Okay, thanks for confirming. Will therefore close this off.

@ssddanbrown commented on GitHub (Oct 21, 2025): Okay, thanks for confirming. Will therefore close this off.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 🐕 Support
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?