mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-07-19 13:44:02 +03:00
Responses to attachment range requests, spanning full range, does not provide a partial/range response #5064
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Nov 27, 2024).
Seems to be causing issues serving video in chromium based browsers.
"Rare Candy" on discord helped find the cause, which is this line:
91d8d6eaaa/app/Http/RangeSupportedStream.php (L95)Due to this, we're not sending partial/range responses to full range requests, which kinda makes sense in a way, but it seems like browsers still want/need that full range response (even for a full response) to work as desired.
Can be solved by removing the
-1, but might want to check if that condition is redundant or not.Needs test to cover.
Discord thread: https://discord.com/channels/578552496637739008/1247823044869886006
@ssddanbrown commented on GitHub (Nov 28, 2024):
Potentially related to #5088
@ssddanbrown commented on GitHub (Nov 29, 2024):
Addressed via
e9f906ce56