mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
[Question]plural and singular implementation #413
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @msaus on GitHub (Aug 24, 2017).
Dear sir,
I have a question regarding the plural and singular implementation.
In Japanese, we do not have a such a grammar and so we do not put "s" to the right-most.
Is there any function to remove that "s"?
I know that following source code is putting "s" to the right-most.
vendor/laravel/framework/src/Illuminate/Support/helpers.php
Possibly... can we add some logic to view files?
Or controller side?
I guess I can fix it myself.
Regards,
@msaus commented on GitHub (Aug 24, 2017):
We do not need this red rectangle one.
@ssddanbrown commented on GitHub (Sep 11, 2017):
Hi @msaus, Sorry for my late reply. This was also picked up by other users under #417.
I've now changed it to use the built in Laravel's
trans_choice()function. This means pluralization can be manually set for each language now.The changes for this and the added translation strings can be seen on this commit:
874386ceabI'll close this issue now a solution has been implemented but if you need further help on this feel free to open a new issue or comment further on this one.