Page order not updated after sorting #2955

New Issue

Closed

opened 2026-02-05 05:50:04 +03:00 by OVERLORD · 19 comments

OVERLORD commented 2026-02-05 05:50:04 +03:00

Owner

Copy Link

Originally created by @mrcompsci on GitHub (Aug 11, 2022).

Attempted Debugging

• I have read the debugging page

Searched GitHub Issues

• I have searched GitHub for the issue.

Describe the Scenario

The order of pages within a chapter is not saved when using the sort function. The priority field in the database is not updated. This is true of existing books and chapters as well as newly created ones. No errors are displayed or logged.

Pages that aren't contained in a chapter sort as expected.

This seems to be the same issue as #3544 . To follow up on unanswered questions from that issue: Yes, I am using a user with administrative privileges. The JSON extension is enabled. I also added the debug line to BookSortController.php and confirmed that it is receiving the new order from the browser.

This system was upgraded from v0.29.0 to v22.03.1 in April and sorting hasn't worked since. It was upgraded again today to v22.07.3.

Exact BookStack Version

v22.07.3

Log Content

No response

PHP Version

7.4.30

Hosting Environment

Shared hosting environment:

cPanel Version: 104.0 (build 7)
Apache Version: 2.4.54
PHP Version: 7.2.34
MySQL Version: 10.3.35-MariaDB-cll-lve
Architecture: x86_64
Operating System: linux

Originally created by @mrcompsci on GitHub (Aug 11, 2022). ### Attempted Debugging - [X] I have read the debugging page ### Searched GitHub Issues - [X] I have searched GitHub for the issue. ### Describe the Scenario The order of pages within a chapter is not saved when using the sort function. The priority field in the database is not updated. This is true of existing books and chapters as well as newly created ones. No errors are displayed or logged. Pages that aren't contained in a chapter sort as expected. This seems to be the same issue as #3544 . To follow up on unanswered questions from that issue: Yes, I am using a user with administrative privileges. The JSON extension is enabled. I also added the debug line to BookSortController.php and confirmed that it is receiving the new order from the browser. This system was upgraded from v0.29.0 to v22.03.1 in April and sorting hasn't worked since. It was upgraded again today to v22.07.3. ### Exact BookStack Version v22.07.3 ### Log Content _No response_ ### PHP Version 7.4.30 ### Hosting Environment Shared hosting environment: cPanel Version: 104.0 (build 7) Apache Version: 2.4.54 PHP Version: 7.2.34 MySQL Version: 10.3.35-MariaDB-cll-lve Architecture: x86_64 Operating System: linux

OVERLORD added the 🐕 Support label 2026-02-05 05:50:04 +03:00

OVERLORD closed this issue 2026-02-05 05:50:09 +03:00

OVERLORD commented 2026-02-05 05:50:13 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 12, 2022):

Hi @mrcompsci,

Where is the 7.2.34 php version coming from, is that the version of PHP being used for bookstack itself?

@ssddanbrown commented on GitHub (Aug 12, 2022): Hi @mrcompsci, Where is the `7.2.34` php version coming from, is that the version of PHP being used for bookstack itself?

OVERLORD commented 2026-02-05 05:50:15 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 12, 2022):

@ssddanbrown

I apologize for the contradiction. The CLI reports 7.2.34 as does cPanel's "server information" page, but if I use phpinfo() on the site itself, it reports 7.4.30.

@mrcompsci commented on GitHub (Aug 12, 2022): @ssddanbrown I apologize for the contradiction. The CLI reports 7.2.34 as does cPanel's "server information" page, but if I use phpinfo() on the site itself, it reports 7.4.30.

OVERLORD commented 2026-02-05 05:50:20 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 12, 2022):

@mrcompsci Thanks for confirming. This is gonna be a bit tricky to solve other than attempting to replicate your environment directly, so you may need to bear with me to run through debugging steps.

Could you find the line highlighted here:
1fdf854ea7/app/Http/Controllers/BookSortController.php (L61)

and below it, add the following line:

dd($sortMap);

This should stop the sort action and spit out the sort data on save. On the output view, if existing, it would be helpful to expand some of the items by clicking the little arrows that should show.

@ssddanbrown commented on GitHub (Aug 12, 2022): @mrcompsci Thanks for confirming. This is gonna be a bit tricky to solve other than attempting to replicate your environment directly, so you may need to bear with me to run through debugging steps. Could you find the line highlighted here: https://github.com/BookStackApp/BookStack/blob/1fdf854ea735bf69e1c2666d8d23f66b243d7afe/app/Http/Controllers/BookSortController.php#L61 and **_below_** it, add the following line: ```php dd($sortMap); ``` This should stop the sort action and spit out the sort data on save. On the output view, if existing, it would be helpful to expand some of the items by clicking the little arrows that should show.

OVERLORD commented 2026-02-05 05:50:22 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 12, 2022):

@ssddanbrown Here is the output. I have three test pages within a chapter - Page 1A (item 1322), Page 2A (item 1323) and Page 3A (item 1324) which are currently in order 1-3. I just tried to sort them in reverse order.

^ BookStack\Entities\Tools\BookSortMap {#1278 ▼
  #mapData: array:4 [▼
    0 => BookStack\Entities\Tools\BookSortMapItem {#1547 ▶}
    1 => BookStack\Entities\Tools\BookSortMapItem {#1545 ▼
      +id: 1324
      +sort: 0
      +parentChapterId: 196
      +type: "page"
      +parentBookId: 45
    }
    2 => BookStack\Entities\Tools\BookSortMapItem {#1543 ▼
      +id: 1323
      +sort: 1
      +parentChapterId: 196
      +type: "page"
      +parentBookId: 45
    }
    3 => BookStack\Entities\Tools\BookSortMapItem {#1548 ▼
      +id: 1322
      +sort: 2
      +parentChapterId: 196
      +type: "page"
      +parentBookId: 45
    }
  ]
}

@mrcompsci commented on GitHub (Aug 12, 2022): @ssddanbrown Here is the output. I have three test pages within a chapter - Page 1A (item 1322), Page 2A (item 1323) and Page 3A (item 1324) which are currently in order 1-3. I just tried to sort them in reverse order. ``` ^ BookStack\Entities\Tools\BookSortMap {#1278 ▼ #mapData: array:4 [▼ 0 => BookStack\Entities\Tools\BookSortMapItem {#1547 ▶} 1 => BookStack\Entities\Tools\BookSortMapItem {#1545 ▼ +id: 1324 +sort: 0 +parentChapterId: 196 +type: "page" +parentBookId: 45 } 2 => BookStack\Entities\Tools\BookSortMapItem {#1543 ▼ +id: 1323 +sort: 1 +parentChapterId: 196 +type: "page" +parentBookId: 45 } 3 => BookStack\Entities\Tools\BookSortMapItem {#1548 ▼ +id: 1322 +sort: 2 +parentChapterId: 196 +type: "page" +parentBookId: 45 } ] } ```

OVERLORD commented 2026-02-05 05:50:27 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 13, 2022):

Thanks for the info @mrcompsci,
That all looks fine. I'm getting the impression that permissions may be at play here.

When you say the following:

Yes, I am using a user with administrative privileges.

Does the user have all possible role permissions assigned? And are there any permission overrides set on the content being sorted?

@ssddanbrown commented on GitHub (Aug 13, 2022): Thanks for the info @mrcompsci, That all looks fine. I'm getting the impression that permissions may be at play here. When you say the following: > Yes, I am using a user with administrative privileges. Does the user have all possible role permissions assigned? And are there any permission overrides set on the content being sorted?

OVERLORD commented 2026-02-05 05:50:30 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 13, 2022):

@ssddanbrown

This user has the Admin role and one other assigned. The admin role has all permissions assigned.

The book I'm testing with did have custom permissions to hide it from the public, but I just tried disabling that and was still unable to sort pages. I even tried removing it from the custom role (leaving just Admin) but that had no effect on sorting.

@mrcompsci commented on GitHub (Aug 13, 2022): @ssddanbrown This user has the Admin role and one other assigned. The admin role has all permissions assigned.  The book I'm testing with did have custom permissions to hide it from the public, but I just tried disabling that and was still unable to sort pages. I even tried removing it from the custom role (leaving just Admin) but that had no effect on sorting.

OVERLORD commented 2026-02-05 05:50:34 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 13, 2022):

Okay, as a next step, could you find the following file & lines:

1fdf854ea7/app/Entities/Tools/BookContents.php (L182-L184)

Then, before the return; line add dd('lacking permission');
This will help us determine if this is something permission related, since you're expected to have all permissions with your user setup.

@ssddanbrown commented on GitHub (Aug 13, 2022): Okay, as a next step, could you find the following file & lines: https://github.com/BookStackApp/BookStack/blob/1fdf854ea735bf69e1c2666d8d23f66b243d7afe/app/Entities/Tools/BookContents.php#L182-L184 Then, before the `return;` line add `dd('lacking permission');` This will help us determine if this is something permission related, since you're expected to have all permissions with your user setup.

OVERLORD commented 2026-02-05 05:50:39 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 13, 2022):

Yes, it does seem to be permission related. I received the "lacking permission" message when I tried to sort.

I confirmed again that the Admin role has all of the permissions assigned in the web interface, but perhaps something is wrong in the database?

@mrcompsci commented on GitHub (Aug 13, 2022): Yes, it does seem to be permission related. I received the "lacking permission" message when I tried to sort. I confirmed again that the Admin role has all of the permissions assigned in the web interface, but perhaps something is wrong in the database? 

OVERLORD commented 2026-02-05 05:50:43 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 14, 2022):

but perhaps something is wrong in the database?

Quite possible at this stage.

As the next debug step, could you find this section:

1fdf854ea7/app/Entities/Tools/BookContents.php (L252-L257)

and, above it, add the following:

dd($hasCurrentParentPermission, $newParentInRightLocation, $hasNewParentPermission, $hasPageEditPermission, $hasDeletePermissionIfMoving, $hasCreatePermissionIfMoving);

Then report output, if existing. Should allow us to find the exact failing permission check.

@ssddanbrown commented on GitHub (Aug 14, 2022): > but perhaps something is wrong in the database? Quite possible at this stage. As the next debug step, could you find this section: https://github.com/BookStackApp/BookStack/blob/1fdf854ea735bf69e1c2666d8d23f66b243d7afe/app/Entities/Tools/BookContents.php#L252-L257 and, above it, add the following: ```php dd($hasCurrentParentPermission, $newParentInRightLocation, $hasNewParentPermission, $hasPageEditPermission, $hasDeletePermissionIfMoving, $hasCreatePermissionIfMoving); ``` Then report output, if existing. Should allow us to find the exact failing permission check.

OVERLORD commented 2026-02-05 05:50:47 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 14, 2022):

$newParentInRightLocation is false:

^ true
^ false
^ true
^ true
^ true
^ true

@mrcompsci commented on GitHub (Aug 14, 2022): $newParentInRightLocation is false: ``` ^ true ^ false ^ true ^ true ^ true ^ true ```

OVERLORD commented 2026-02-05 05:50:48 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 23, 2022):

@ssddanbrown Do you have any suggestions for troubleshooting this further?

@mrcompsci commented on GitHub (Aug 23, 2022): @ssddanbrown Do you have any suggestions for troubleshooting this further?

OVERLORD commented 2026-02-05 05:50:52 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 23, 2022):

@mrcompsci Sorry for lack of response.
Seems to be some misalignment in understanding the parent location.
Would be good to know what's going on there.

Where you placed the previous debug line, could you instead add the following:

if (!$newParentInRightLocation) {
	dd($sortMapItem, $newParent->book_id ?? false, $newBook->id ?? false);
}

@ssddanbrown commented on GitHub (Aug 23, 2022): @mrcompsci Sorry for lack of response. Seems to be some misalignment in understanding the parent location. Would be good to know what's going on there. Where you placed the previous debug line, could you instead add the following: ```php if (!$newParentInRightLocation) { dd($sortMapItem, $newParent->book_id ?? false, $newBook->id ?? false); } ```

OVERLORD commented 2026-02-05 05:50:55 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 23, 2022):

@ssddanbrown

^ BookStack\Entities\Tools\BookSortMapItem {#1540 ▼
  +id: 1323
  +sort: 0
  +parentChapterId: 196
  +type: "page"
  +parentBookId: 45
}

^ "45"

^ 45

@mrcompsci commented on GitHub (Aug 23, 2022): @ssddanbrown ``` ^ BookStack\Entities\Tools\BookSortMapItem {#1540 ▼ +id: 1323 +sort: 0 +parentChapterId: 196 +type: "page" +parentBookId: 45 } ^ "45" ^ 45 ```

OVERLORD commented 2026-02-05 05:50:56 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 23, 2022):

Thanks for the info @mrcompsci, interesting result.

I get the impression your environment may be using an older PHP/MySQL driver that's rarely used.
Within CPanel, do you have options for the PHP MySQL driver, or do you have mulitple options for mysql-related PHP extensions?

@ssddanbrown commented on GitHub (Aug 23, 2022): Thanks for the info @mrcompsci, interesting result. I get the impression your environment may be using an older PHP/MySQL driver that's rarely used. Within CPanel, do you have options for the PHP MySQL driver, or do you have mulitple options for mysql-related PHP extensions?

OVERLORD commented 2026-02-05 05:51:00 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 23, 2022):

@ssddanbrown There are a few MySQL options in cPanel:

mysqli
mysqlnd (enabled)
nd_mysqli (enabled)
nd_pdo_mysql
pdo_mysql (enabled)

@mrcompsci commented on GitHub (Aug 23, 2022): @ssddanbrown There are a few MySQL options in cPanel: mysqli mysqlnd (enabled) nd_mysqli (enabled) nd_pdo_mysql pdo_mysql (enabled)

OVERLORD commented 2026-02-05 05:51:05 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 23, 2022):

nd_pdo_mysql
pdo_mysql (enabled)

Could you try swapping those around? So disable pdo_mysql and enable nd_pdo_mysql.
Then restart apache/php (if possible) and see if that fixes things.

@ssddanbrown commented on GitHub (Aug 23, 2022): > nd_pdo_mysql > pdo_mysql (enabled) Could you try swapping those around? So disable `pdo_mysql` and enable `nd_pdo_mysql`. Then restart apache/php (if possible) and see if that fixes things.

OVERLORD commented 2026-02-05 05:51:10 +03:00

Author

Owner

Copy Link

@mrcompsci commented on GitHub (Aug 24, 2022):

Disabling pdo_mysql and enabling nd_pro_mysql worked. Sorting is working properly now and it doesn't look like the change created any new issues. I never would have guessed that the MySQL driver needed to be changed. Thanks for your help!

@mrcompsci commented on GitHub (Aug 24, 2022): Disabling pdo_mysql and enabling nd_pro_mysql worked. Sorting is working properly now and it doesn't look like the change created any new issues. I never would have guessed that the MySQL driver needed to be changed. Thanks for your help!

OVERLORD commented 2026-02-05 05:51:14 +03:00

Author

Owner

Copy Link

@ssddanbrown commented on GitHub (Aug 24, 2022):

Great news! Will therefore close this off.
Must admit, I didn't think the non-native driver was in use any more.
I'll keep an ear out though and, if this pops up again, maybe update the docs to specific driver version.

@ssddanbrown commented on GitHub (Aug 24, 2022): Great news! Will therefore close this off. Must admit, I didn't think the non-native driver was in use any more. I'll keep an ear out though and, if this pops up again, maybe update the docs to specific driver version.

OVERLORD commented 2026-02-05 05:51:16 +03:00

Author

Owner

Copy Link

@jwtay1 commented on GitHub (Feb 14, 2023):

Finally! I was having the same issue and it took awhile to find this post as the correct solution.

@jwtay1 commented on GitHub (Feb 14, 2023): Finally! I was having the same issue and it took awhile to find this post as the correct solution.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

development

further_theme_development

l10n_development

release

llm_only

vectors

v25-11

docker_env

drawio_rendering

user_permissions

ldap_host_failover

svg_image

prosemirror

captcha_example

fix/video-export

v25.12.3

v25.12.2

v25.12.1

v25.12

v25.11.6

v25.11.5

v25.11.4

v24.11.4

v25.11.3

v25.11.2

v25.11.1

v25.11

v25.07.3

v25.07.2

v25.07.1

v25.07

v25.05.2

v25.05.1

v25.05

v25.02.5

v25.02.4

v25.02.3

v25.02.2

v25.02.1

v25.02

v24.12.1

v24.12

v24.10.3

v24.10.2

v24.10.1

v24.10

v24.05.4

v24.05.3

v24.05.2

v24.05.1

v24.05

v24.02.3

v24.02.2

v24.02.1

v24.02

v23.12.3

v23.12.2

v23.12.1

v23.12

v23.10.4

v23.10.3

v23.10.2

v23.10.1

v23.10

v23.08.3

v23.08.2

v23.08.1

v23.08

v23.06.2

v23.06.1

v23.06

v23.05.2

v23.05.1

v23.05

v23.02.3

v23.02.2

v23.02.1

v23.02

v23.01.1

v23.01

v22.11.1

v22.11

v22.10.2

v22.10.1

v22.10

v22.09.1

v22.09

v22.07.3

v22.07.2

v22.07.1

v22.07

v22.06.2

v22.06.1

v22.06

v22.04.2

v22.04.1

v22.04

v22.03.1

v22.03

v22.02.3

v22.02.2

v22.02.1

v22.02

v21.12.5

v21.12.4

v21.12.3

v21.12.2

v21.12.1

v21.12

v21.11.3

v21.11.2

v21.11.1

v21.11

v21.10.3

v21.10.2

v21.10.1

v21.10

v21.08.6

v21.08.5

v21.08.4

v21.08.3

v21.08.2

v21.08.1

v21.08

v21.05.4

v21.05.3

v21.05.2

v21.05.1

v21.05

v21.04.6

v21.04.5

v21.04.4

v21.04.3

v21.04.2

v21.04.1

v21.04

v0.31.8

v0.31.7

v0.31.6

v0.31.5

v0.31.4

v0.31.3

v0.31.2

v0.31.1

v0.31.0

v0.30.7

v0.30.6

v0.30.5

v0.30.4

v0.30.3

v0.30.2

v0.30.1

v0.30.0

v0.29.3

v0.29.2

v0.29.1

v0.29.0

v0.28.3

v0.28.2

v0.28.1

v0.28.0

v0.27.5

v0.27.4

v0.27.3

v0.27.2

v0.27.1

v0.27

v0.26.4

v0.26.3

v0.26.2

v0.26.1

v0.26.0

v0.25.5

v0.25.4

v0.25.3

v0.25.2

v0.25.1

v0.25.0

v0.24.3

v0.24.2

v0.24.1

v0.24.0

v0.23.2

v0.23.1

v0.23.0

v0.22.0

v0.21.0

v0.20.3

v0.20.2

v0.20.1

v0.20.0

v0.19.0

v0.18.5

v0.18.4

v0.18.3

v0.18.2

v0.18.1

v0.18.0

v0.17.4

v0.17.3

v0.17.2

v0.17.1

v0.17.0

v0.16.3

v0.16.2

v0.16.1

v0.16.0

v0.15.3

v0.15.2

v0.15.1

v0.15.0

v0.14.3

v0.14.2

v0.14.1

v0.14.0

v0.13.1

v0.13.0

v0.12.2

v0.12.1

v0.12.0

v0.11.2

v0.11.1

v0.11.0

v0.10.0

v0.9.3

v0.9.2

v0.9.1

v0.9.0

v0.8.2

v0.8.1

v0.8.0

v0.7.6

v0.7.5

v0.7.4

v0.7.3

0.7.2

v.0.7.1

v0.7.0

v0.6.3

v0.6.2

v0.6.1

v0.6.0

v0.5.0

Labels

Clear labels

🎨 Design

📖 Docs Update

🐛 Bug

🐛 Bug

:cat2:🐈 Possible duplicate

💿 Database

☕ Open to discussion

💻 Front-End

🐕 Support

🚪 Authentication

🌍 Translations

🔌 API Task

🏭 Back-End

⛲ Upstream

🔨 Feature Request

🛠️ Enhancement

🛠️ Enhancement

🛠️ Enhancement

❤️ Happy feedback

🔒 Security

🔍 Pending Validation

💆 UX

📝 WYSIWYG Editor

🌔 Out of scope

🔩 API Request

:octocat: Admin/Meta

🖌️ View Customization

❓ Question

🚀 Priority

🛡️ Blocked

🚚 Export System

♿ A11y

🔧 Maintenance

> Markdown Editor

pull-request

Mirrored from GitHub Pull Request

No Label 🐕 Support

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#2955