Shelf is deleting when set individual rights #2373

Closed
opened 2026-02-05 03:51:12 +03:00 by OVERLORD · 6 comments
Owner

Originally created by @pboatone on GitHub (Aug 31, 2021).

Describe the bug
When I create a new shelf and save it, the shelf is there. If I set custom rights on it and click safe there comes a message that shelf is not there. After reloading I look on all shelfes and it is away ...

Steps To Reproduce
Steps to reproduce the behavior:

  1. New shelf -> save it
  2. Edit Right and set custom rights
  3. Click Save
  4. Shelf is not avaible

Screenshots
2021-08-31 13_02_41-Window
2021-08-31 13_02_18-Window
2021-08-31 12_58_18-Window

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): BookStack v21.05.4
  • PHP Version: php8.0
  • Hosting Method (Nginx/Apache/Docker): Apache

Additional context
Add any other context about the problem here.

Originally created by @pboatone on GitHub (Aug 31, 2021). **Describe the bug** When I create a new shelf and save it, the shelf is there. If I set custom rights on it and click safe there comes a message that shelf is not there. After reloading I look on all shelfes and it is away ... **Steps To Reproduce** Steps to reproduce the behavior: 1. New shelf -> save it 2. Edit Right and set custom rights 3. Click Save 4. Shelf is not avaible **Screenshots** ![2021-08-31 13_02_41-Window](https://user-images.githubusercontent.com/67209365/131491602-d318f349-9a45-4b9a-afde-49e1dedfad32.png) ![2021-08-31 13_02_18-Window](https://user-images.githubusercontent.com/67209365/131491644-ed1063d7-ebbc-4226-8578-af10d16c2df4.png) ![2021-08-31 12_58_18-Window](https://user-images.githubusercontent.com/67209365/131491657-6bd397a5-fb71-44bf-a3ab-690728f9acb4.png) **Your Configuration (please complete the following information):** - Exact BookStack Version (Found in settings): BookStack v21.05.4 - PHP Version: php8.0 - Hosting Method (Nginx/Apache/Docker): Apache **Additional context** Add any other context about the problem here.
Author
Owner

@ssddanbrown commented on GitHub (Sep 2, 2021):

Hi @pboatone,
When setting permissions are you ensuring that your own user account will have permission afterwards? What you've described could occur if you're updating permissions in a way that will hide it for your current user.

Otherwise, Are you using a system-level admin account? (Not a custom admin-like role)

@ssddanbrown commented on GitHub (Sep 2, 2021): Hi @pboatone, When setting permissions are you ensuring that your own user account will have permission afterwards? What you've described could occur if you're updating permissions in a way that will hide it for your current user. Otherwise, Are you using a system-level admin account? (Not a custom admin-like role)
Author
Owner

@pboatone commented on GitHub (Sep 2, 2021):

Hi @ssddanbrown,

I am using an admin account and have the permissions too.

@pboatone commented on GitHub (Sep 2, 2021): Hi @ssddanbrown, I am using an admin account and have the permissions too.
Author
Owner

@ssddanbrown commented on GitHub (Sep 2, 2021):

@pboatone Odd, Does the same occur when you set permissions on books?

@ssddanbrown commented on GitHub (Sep 2, 2021): @pboatone Odd, Does the same occur when you set permissions on books?
Author
Owner

@pboatone commented on GitHub (Sep 2, 2021):

@pboatone Odd, Does the same occur when you set permissions on books?

I didn't tried on existing books, in new shelfes which have the ownership of me it works ... I don't want to try it on existing books because they are not recoverable from the settings/cleanup

@pboatone commented on GitHub (Sep 2, 2021): > @pboatone Odd, Does the same occur when you set permissions on books? I didn't tried on existing books, in new shelfes which have the ownership of me it works ... I don't want to try it on existing books because they are not recoverable from the settings/cleanup
Author
Owner

@MexHigh commented on GitHub (Oct 17, 2021):

I'm having the same issue, but I'm not using an admin account. But this behavior is also odd in this case. Owners should be able to see their own shelves and books no matter how to permissions are configured. There is no sense in the principle of ownership otherwise in my opinion.

@MexHigh commented on GitHub (Oct 17, 2021): I'm having the same issue, but I'm not using an admin account. But this behavior is also odd in this case. Owners should be able to see their own shelves and books no matter how to permissions are configured. There is no sense in the principle of ownership otherwise in my opinion.
Author
Owner

@ssddanbrown commented on GitHub (Oct 15, 2022):

I am going to close this off since, after testing again, I am not able to reproduce at all.
I can only assume that it's specific to the roles/permission at play in the original scenario.
Happy to address if a specific issue can be detected, or can reopen if this can be reproduced on our demo instance.

@ssddanbrown commented on GitHub (Oct 15, 2022): I am going to close this off since, after testing again, I am not able to reproduce at all. I can only assume that it's specific to the roles/permission at play in the original scenario. Happy to address if a specific issue can be detected, or can reopen if this can be reproduced on our demo instance.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#2373