mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Draw.io name change to diagrams.net #1660
Closed
opened 2026-02-05 01:32:16 +03:00 by OVERLORD
·
11 comments
No Branch/Tag Specified
development
l10n_development
further_theme_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
No Label
📖 Docs Update
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#1660
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TBK on GitHub (Apr 16, 2020).
Draw.io is transitioning to diagrams.net. They have published a blog post about it https://www.diagrams.net/blog/move-diagrams-net
@ssddanbrown commented on GitHub (Apr 25, 2020):
Thanks for advising @TBK. I did see this but from that blog post:
I'll keep this open as a reminder and then, maybe later this year, if there have been no issues, We can update the docs and code to refer to diagrams.net. Will not change the
DRAWIOenv options though as not really worth changing.Reminder to myself to make this visible as an upgrade note, when it's implemented, since there could be enterprise environments that have whitelisted the draw.io domain.
@davidjgraph commented on GitHub (Jul 31, 2020):
@ssddanbrown We're not in any rush and we're not changing underlying names from drawio, either. Literally, nobody calls it diagrams.net.
The only thing to mention, if anyone is embedding draw.io directly from the hosted version, is that we would like to set the frame header to only allow embedding on embed.diagrams.net. This is a security improvement, that URL won't allow permissions to cloud storage and so removes a number of clickjacking attacks.
If it's just docs, don't worry about it, it'll be called draw.io more than diagrams.net for a long time...
@nutsflag commented on GitHub (Sep 28, 2020):
Hello @ssddanbrown,
You have to modify the url in form.blade.php.
A user has been impacted (Issue #2285)
@davidjgraph commented on GitHub (Sep 28, 2020):
We excluded "https://www.draw.io?embed=1*" from the redirect, going to https://www.draw.io/?embed=1&proto=json&spin=1 shouldn't give you a redirect.
But yes, anything www.draw.io needs to become embed.diagrams.net at some point. The security on embed.diagrams.net is better than on the old domain.
@nutsflag commented on GitHub (Sep 28, 2020):
Hello,
There is a redirection which is done.
First :
Request URL: https://www.draw.io/?embed=1&proto=json&spin=1
Request Method: GET
Status Code: 301
Remote Address: 104.22.56.156:443
Referrer Policy: strict-origin-when-cross-origin
Second :
Request URL: https://app.diagrams.net/?embed=1&proto=json&spin=1
Request Method: GET
Status Code: 200 (from ServiceWorker)
Referrer Policy: strict-origin-when-cross-origin
@davidjgraph commented on GitHub (Sep 28, 2020):
Try clearing the 301 from the browser cache, like https://stackoverflow.com/questions/16154672/how-long-does-chrome-remember-a-301-redirect
@nutsflag commented on GitHub (Sep 28, 2020):
Yes, but one user has been impacted as mentioned above. Changing the url unlocked the situation. Knowing that Draw has notified the domain change, it would be good to apply it for the next release.
@Kabe0 commented on GitHub (Sep 28, 2020):
Clearing the cache has not worked for me on this issue. The redirect itself is not the problem, the issue is the app.diagrams.net response includes the following which locks the iframe from being able to render the content. They are no longer allowing people to use the app.diagrams.net for embedding.
x-frame-options: SAMEORIGIN
@davidjgraph commented on GitHub (Sep 28, 2020):
Could someone grep this codebase for "app.diagrams.net" ?
@ssddanbrown commented on GitHub (Sep 28, 2020):
Thanks @davidjgraph for officially advising here and thanks for the info on embed.diagrams.net from before, I had missed that message.
app.diagrams.netnot already in the codebase (In a release)My findings:
https://www.draw.io/?embed=1&proto=json&spin=1 Does seem to provide a redirect:
The resulting location does not seem to set
x-frame-options:Of course those are my results via CURL; Region, time and request headers may have an affect. That said, In my browser (Including on the BookStack demo site) the requests behave the same (Get redirected to the app.diagrams.net instance with a notification).
In my testing everything still works though, I don't see any
x-frame-optionsalong the way.Either way, I'll look to get include this in the next patch release, Thanks all for having a dig into this
@ssddanbrown commented on GitHub (Oct 1, 2020):
This has now been changed in BookStack v0.30.2