Page Content: Better handling for empty content filtering

For #6028

.gitignore

@@ -8,10 +8,10 @@ Homestead.yaml
 .idea
 npm-debug.log
 yarn-error.log
-/public/dist/*.map
+/public/dist
 /public/plugins
-/public/css/*.map
-/public/js/*.map
+/public/css
+/public/js
 /public/bower
 /public/build/
 /public/favicon.ico

app/Util/HtmlDocument.php

@@ -103,7 +103,13 @@ class HtmlDocument
      */
     public function getBody(): DOMNode
     {
-        return $this->document->getElementsByTagName('body')[0];
+        $bodies = $this->document->getElementsByTagName('body');
+
+        if ($bodies->length === 0) {
+            return new DOMElement('body', '');
+        }
+
+        return $bodies[0];
     }
 
     /**

dev/checksums/vendor

@@ -1 +1 @@
-9a9b39ad13bada8f7c71e2224593d37c967b4ebe5ec048877cd30ca3ff33d898
+22e02ee72d21ff719c1073abbec8302f8e2096ba6d072e133051064ed24b45b1

tests/Entity/PageEditorTest.php

@@ -282,4 +282,23 @@ class PageEditorTest extends TestCase
         $resp->assertOk();
         $resp->assertDontSee('hellotherethisisaturtlemonster', false);
     }
+
+    public function test_editor_html_filtered_does_not_cause_error_if_empty()
+    {
+        $emptyExamples = ['', '<p></p>', '<p>&nbsp;</p>', ' ', "\n"];
+        $editor = $this->users->editor();
+        $page = $this->entities->page();
+        $page->updated_by = $editor->id;
+
+        foreach ($emptyExamples as $emptyExample) {
+            $page->html = $emptyExample;
+            $page->save();
+
+            $resp = $this->asAdmin()->get($page->getUrl('edit'));
+            $resp->assertOk();
+
+            $resp = $this->asAdmin()->get("/ajax/page/{$page->id}");
+            $resp->assertOk();
+        }
+    }
 }

version

@@ -1 +1 @@
-v25.12.6
+v26.01-dev