Started work on details/summary blocks

Now will update the link mark if you have a no-range selection on the
link.

.env.example.complete

@@ -42,7 +42,7 @@ APP_TIMEZONE=UTC
 # overrides can be made. Defaults to disabled.
 APP_THEME=false
 
-# Trusted proxies
+# Trusted Proxies
 # Used to indicate trust of systems that proxy to the application so
 # certain header values (Such as "X-Forwarded-For") can be used from the
 # incoming proxy request to provide origin detail.
@@ -58,13 +58,6 @@ DB_DATABASE=database_database
 DB_USERNAME=database_username
 DB_PASSWORD=database_user_password
 
-# MySQL specific connection options
-# Path to Certificate Authority (CA) certificate file for your MySQL instance.
-# When this option is used host name identity verification will be performed
-# which checks the hostname, used by the client, against names within the
-# certificate itself (Common Name or Subject Alternative Name).
-MYSQL_ATTR_SSL_CA="/path/to/ca.pem"
-
 # Mail system to use
 # Can be 'smtp' or 'sendmail'
 MAIL_DRIVER=smtp
@@ -223,7 +216,6 @@ LDAP_DUMP_USER_DETAILS=false
 LDAP_USER_TO_GROUPS=false
 LDAP_GROUP_ATTRIBUTE="memberOf"
 LDAP_REMOVE_FROM_GROUPS=false
-LDAP_DUMP_USER_GROUPS=false
 
 # SAML authentication configuration
 # Refer to https://www.bookstackapp.com/docs/admin/saml2-auth/
@@ -274,7 +266,7 @@ AVATAR_URL=
 # Enable diagrams.net integration
 # Can simply be true/false to enable/disable the integration.
 # Alternatively, It can be URL to the diagrams.net instance you want to use.
-# For URLs, The following URL parameters should be included: embed=1&proto=json&spin=1&configure=1
+# For URLs, The following URL parameters should be included: embed=1&proto=json&spin=1
 DRAWIO=true
 
 # Default item listing view
@@ -305,11 +297,6 @@ RECYCLE_BIN_LIFETIME=30
 # Maximum file size, in megabytes, that can be uploaded to the system.
 FILE_UPLOAD_SIZE_LIMIT=50
 
-# Export Page Size
-# Primarily used to determine page size of PDF exports.
-# Can be 'a4' or 'letter'.
-EXPORT_PAGE_SIZE=a4
-
 # Allow <script> tags in page content
 # Note, if set to 'true' the page editor may still escape scripts.
 ALLOW_CONTENT_SCRIPTS=false
@@ -332,13 +319,6 @@ ALLOW_UNTRUSTED_SERVER_FETCHING=false
 # Setting this option will also auto-adjust cookies to be SameSite=None.
 ALLOWED_IFRAME_HOSTS=null
 
-# A list of sources/hostnames that can be loaded within iframes within BookStack.
-# Space separated if multiple. BookStack host domain is auto-inferred.
-# Can be set to a lone "*" to allow all sources for iframe content (Not advised).
-# Defaults to a set of common services.
-# Current host and source for the "DRAWIO" setting will be auto-appended to the sources configured.
-ALLOWED_IFRAME_SOURCES="https://*.draw.io https://*.youtube.com https://*.youtube-nocookie.com https://*.vimeo.com"
-
 # The default and maximum item-counts for listing API requests.
 API_DEFAULT_ITEM_COUNT=100
 API_MAX_ITEM_COUNT=500

.github/ISSUE_TEMPLATE/api_request.yml

@@ -1,5 +1,6 @@
 name: New API Endpoint or API Ability
 description: Request a new endpoint or API feature be added
+title: "[API Request]: "
 labels: [":nut_and_bolt: API Request"]
 body:
   - type: textarea

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,5 +1,6 @@
 name: Bug Report
 description: Create a report to help us improve or fix things
+title: "[Bug Report]: "
 labels: [":bug: Bug"]
 body:
   - type: textarea
@@ -35,15 +36,6 @@ body:
       description: Provide any additional context and screenshots here to help us solve this issue
     validations:
       required: false
-  - type: input
-    id: browserdetails
-    attributes:
-      label: Browser Details
-      description: |
-        If this is an issue that occurs when using the BookStack interface, please provide details of the browser used which presents the reported issue.
-      placeholder: (eg. Firefox 97 (64-bit) on Windows 11)
-    validations:
-      required: false
   - type: input
     id: bsversion
     attributes:

.github/ISSUE_TEMPLATE/config.yml

@@ -1,13 +1,9 @@
 blank_issues_enabled: false
 contact_links:
-  - name: Discord Chat Support
+  - name: Discord chat support
     url: https://discord.gg/ztkBqR2
-    about: Realtime support & chat with the BookStack community and the team.
+    about: Realtime support / chat with the community and the team.
 
   - name: Debugging & Common Issues
     url: https://www.bookstackapp.com/docs/admin/debugging/
-    about: Find details on how to debug issues and view common issues with their resolutions.
-
-  - name: Official Support Plans
-    url: https://www.bookstackapp.com/support/
-    about: View our official support plans that offer assured support for business.
+    about: Find details on how to debug issues and view common issues with thier resolutions.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,5 +1,6 @@
 name: Feature Request
-description: Request a new feature or idea to be added to BookStack
+description: Request a new language to be added to CrowdIn for you to translate
+title: "[Feature Request]: "
 labels: [":hammer: Feature Request"]
 body:
   - type: textarea
@@ -12,41 +13,8 @@ body:
   - type: textarea
     id: benefits
     attributes:
-      label: Describe the benefits this would bring to existing BookStack users
-      description: |
-        Explain the measurable benefits this feature would achieve for existing BookStack users.
-        These benefits should details outcomes in terms of what this request solves/achieves, and should not be specific to implementation.
-        This helps us understand the core desired goal so that a variety of potential implementations could be explored.
-        This field is important. Lack if input here may lead to early issue closure.
-    validations:
-      required: true
-  - type: textarea
-    id: already_achieved
-    attributes:
-      label: Can the goal of this request already be achieved via other means?
-      description: |
-        Yes/No. If yes, please describe how the requested approach fits in with the existing method.
-    validations:
-      required: true
-  - type: checkboxes
-    id: confirm-search
-    attributes:
-      label: Have you searched for an existing open/closed issue?
-      description: |
-        To help us keep these issues under control, please ensure you have first [searched our issue list](https://github.com/BookStackApp/BookStack/issues?q=is%3Aissue) for any existing issues that cover the fundemental benefit/goal of your request.
-      options:
-        - label: I have searched for existing issues and none cover my fundemental request
-          required: true
-  - type: dropdown
-    id: existing_usage
-    attributes:
-      label: How long have you been using BookStack?
-      options:
-        - Not using yet, just scoping
-        - 0 to 6 months
-        - 6 months to 1 year
-        - 1 to 5 years
-        - Over 5 years
+      label: Describe the benefits this feature would bring to BookStack users
+      description: Explain the measurable benefits this feature would achieve for existing BookStack users
     validations:
       required: true
   - type: textarea

.github/ISSUE_TEMPLATE/language_request.yml

@@ -1,5 +1,6 @@
 name: Language Request
 description: Request a new language to be added to CrowdIn for you to translate
+title: "[Language Request]: "
 labels: [":earth_africa: Translations"]
 assignees:
   - ssddanbrown

.github/ISSUE_TEMPLATE/support_request.yml

@@ -1,5 +1,6 @@
 name: Support Request
 description: Request support for a specific problem you have not been able to solve yourself
+title: "[Support Request]: "
 labels: [":dog2: Support"]
 body:
   - type: checkboxes

.github/translators.txt

@@ -158,14 +158,14 @@ HenrijsS :: Latvian
 Pascal R-B (pborgner) :: German
 Boris (Ginfred) :: Russian
 Jonas Anker Rasmussen (jonasanker) :: Danish
-Gerwin de Keijzer (gdekeijzer) :: Dutch; German Informal; German
+Gerwin de Keijzer (gdekeijzer) :: Dutch; German; German Informal
 kometchtech :: Japanese
 Auri (Atalonica) :: Catalan
 Francesco Franchina (ffranchina) :: Italian
 Aimrane Kds (aimrane.kds) :: Arabic
 whenwesober :: Indonesian
 Rem (remkovdhoef) :: Dutch
-syn7ax69 :: Bulgarian; Turkish; German
+syn7ax69 :: Bulgarian; Turkish
 Blaade :: French
 Behzad HosseinPoor (behzad.hp) :: Persian
 Ole Aldric (Swoy) :: Norwegian Bokmal
@@ -210,36 +210,3 @@ Tomáš Batelka (Vofy) :: Czech
 Mundo Racional (ismael.mesquita) :: Portuguese, Brazilian
 Zarik (3apuk) :: Russian
 Ali Shaatani (a.shaatani) :: Arabic
-ChacMaster :: Portuguese, Brazilian
-Saeed (saeed205) :: Persian
-Julesdevops :: French
-peter cerny (posli.to.semka) :: Slovak
-Pavel Karlin (pavelkarlin) :: Russian
-SmokingCrop :: Dutch
-Maciej Lebiest (Szwendacz) :: Polish
-DiscordDigital :: German; German Informal
-Gábor Marton (dodver) :: Hungarian
-Jasell :: Swedish
-Ghost_chu (ghostchu) :: Chinese Simplified
-Ravid Shachar (ravidshachar) :: Hebrew
-Helga Guchshenskaya (guchshenskaya) :: Russian
-daniel chou (chou0214) :: Chinese Traditional
-Manolis PATRIARCHE (m.patriarche) :: French
-Mohammed Haboubi (haboubi92) :: Arabic
-roncallyt :: Portuguese, Brazilian
-goegol :: Dutch
-msevgen :: Turkish
-Khroners :: French
-MASOUD HOSSEINY (masoudme) :: Persian
-Thomerson Roncally (roncallyt) :: Portuguese, Brazilian
-metaarch :: Bulgarian
-Xabi (xabikip) :: Basque
-pedromcsousa :: Portuguese
-Nir Louk (looknear) :: Hebrew
-Alex (qianmengnet) :: Chinese Simplified
-stothew :: German
-sgenc :: Turkish
-Shukrullo (vodiylik) :: Uzbek
-William W. (Nevnt) :: Chinese Traditional
-eamaro :: Portuguese
-Ypsilon-dev :: Arabic

.github/workflows/phpstan.yml

@@ -1,14 +1,19 @@
 name: phpstan
 
-on: [push, pull_request]
+on:
+  push:
+    branches-ignore:
+      - l10n_master
+  pull_request:
+    branches-ignore:
+      - l10n_master
 
 jobs:
   build:
-    if: ${{ github.ref != 'refs/heads/l10n_development' }}
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        php: ['7.4']
+        php: ['7.3']
     steps:
     - uses: actions/checkout@v1
 

.github/workflows/phpunit.yml

@@ -1,14 +1,19 @@
 name: phpunit
 
-on: [push, pull_request]
+on:
+  push:
+    branches-ignore:
+      - l10n_master
+  pull_request:
+    branches-ignore:
+      - l10n_master
 
 jobs:
   build:
-    if: ${{ github.ref != 'refs/heads/l10n_development' }}
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        php: ['7.4', '8.0', '8.1']
+        php: ['7.3', '7.4', '8.0', '8.1']
     steps:
     - uses: actions/checkout@v1
 

.github/workflows/test-migrations.yml

@@ -1,14 +1,19 @@
 name: test-migrations
 
-on: [push, pull_request]
+on:
+  push:
+    branches-ignore:
+      - l10n_master
+  pull_request:
+    branches-ignore:
+      - l10n_master
 
 jobs:
   build:
-    if: ${{ github.ref != 'refs/heads/l10n_development' }}
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        php: ['7.4', '8.0', '8.1']
+        php: ['7.3', '7.4', '8.0', '8.1']
     steps:
       - uses: actions/checkout@v1
 

.gitignore

@@ -5,10 +5,10 @@ Homestead.yaml
 .idea
 npm-debug.log
 yarn-error.log
-/public/dist/*.map
+/public/dist
 /public/plugins
-/public/css/*.map
-/public/js/*.map
+/public/css
+/public/js
 /public/bower
 /public/build/
 /storage/images

TODO

@@ -0,0 +1,49 @@
+### Next
+
+- Table cell height resize & cell width resize via width style
+  - Column resize source: https://github.com/ProseMirror/prosemirror-tables/blob/master/src/columnresizing.js
+  - Have updated column resizing to set cell widths
+    - Now need to handle table overall size on change, then heights. 
+
+- Details/Summary
+  - Need view to control summary editability, make readonly but editable via popover.
+  - Need some default styles to visualise details boundary.
+  - Markdown parser needs to be updated to handle separate open/close tags for blocks. 
+
+### In-Progress
+
+- Tables
+- Details/Summary
+
+### Features
+
+- Images
+- Drawings
+- LTR/RTL control
+- Fullscreen
+- Paste Image Uploading
+- Drag + Drop Image Uploading
+- Checkbox/TODO list items
+- Code blocks
+- Indents
+- Attachment integration (Drag & drop)
+- Template system integration.
+
+### Improvements
+
+- List type changing.
+- Color picker options should have "clear" option.
+- Color picker buttons should be split, with button to re-apply last selected color.
+- Color picker options should change color if different instead of remove.
+- Clear formatting, If no selection range, clear the formatting of parent block.
+  - If no marks, clear the block type if text type?
+- Remove links button? (Action already in place if link href is empty).
+- Links - Validate URL.
+- Links - Integrate entity picker.
+- iFrame - Parse iframe HTML & auto-convert youtube/vimeo urls to embeds. 
+
+### Notes
+
+- Use NodeViews for embedded content (Code, Drawings) where control is needed.
+- Probably still easiest to have seperate (codemirror) MD editor. Can alter display output via NodeViews to make MD like
+  but its tricky since editing the markdown content would change the block definition/type while editing.

app/Actions/DispatchWebhookJob.php

@@ -3,14 +3,17 @@
 namespace BookStack\Actions;
 
 use BookStack\Auth\User;
+use BookStack\Entities\Models\Entity;
 use BookStack\Facades\Theme;
 use BookStack\Interfaces\Loggable;
+use BookStack\Model;
 use BookStack\Theming\ThemeEvents;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
+use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Log;
 
@@ -21,16 +24,31 @@ class DispatchWebhookJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
-    protected Webhook $webhook;
-    protected string $event;
-    protected User $initiator;
-    protected int $initiatedTime;
+    /**
+     * @var Webhook
+     */
+    protected $webhook;
+
+    /**
+     * @var string
+     */
+    protected $event;
 
     /**
      * @var string|Loggable
      */
     protected $detail;
 
+    /**
+     * @var User
+     */
+    protected $initiator;
+
+    /**
+     * @var int
+     */
+    protected $initiatedTime;
+
     /**
      * Create a new job instance.
      *
@@ -52,8 +70,8 @@ class DispatchWebhookJob implements ShouldQueue
      */
     public function handle()
     {
-        $themeResponse = Theme::dispatch(ThemeEvents::WEBHOOK_CALL_BEFORE, $this->event, $this->webhook, $this->detail, $this->initiator, $this->initiatedTime);
-        $webhookData = $themeResponse ?? WebhookFormatter::getDefault($this->event, $this->webhook, $this->detail, $this->initiator, $this->initiatedTime)->format();
+        $themeResponse = Theme::dispatch(ThemeEvents::WEBHOOK_CALL_BEFORE, $this->event, $this->webhook, $this->detail);
+        $webhookData = $themeResponse ?? $this->buildWebhookData();
         $lastError = null;
 
         try {
@@ -79,4 +97,36 @@ class DispatchWebhookJob implements ShouldQueue
 
         $this->webhook->save();
     }
+
+    protected function buildWebhookData(): array
+    {
+        $textParts = [
+            $this->initiator->name,
+            trans('activities.' . $this->event),
+        ];
+
+        if ($this->detail instanceof Entity) {
+            $textParts[] = '"' . $this->detail->name . '"';
+        }
+
+        $data = [
+            'event'                    => $this->event,
+            'text'                     => implode(' ', $textParts),
+            'triggered_at'             => Carbon::createFromTimestampUTC($this->initiatedTime)->toISOString(),
+            'triggered_by'             => $this->initiator->attributesToArray(),
+            'triggered_by_profile_url' => $this->initiator->getProfileUrl(),
+            'webhook_id'               => $this->webhook->id,
+            'webhook_name'             => $this->webhook->name,
+        ];
+
+        if (method_exists($this->detail, 'getUrl')) {
+            $data['url'] = $this->detail->getUrl();
+        }
+
+        if ($this->detail instanceof Model) {
+            $data['related_item'] = $this->detail->attributesToArray();
+        }
+
+        return $data;
+    }
 }

app/Actions/WebhookFormatter.php

@@ -1,124 +0,0 @@
-<?php
-
-namespace BookStack\Actions;
-
-use BookStack\Auth\User;
-use BookStack\Entities\Models\Entity;
-use BookStack\Entities\Models\Page;
-use BookStack\Interfaces\Loggable;
-use BookStack\Model;
-use Illuminate\Support\Carbon;
-
-class WebhookFormatter
-{
-    protected Webhook $webhook;
-    protected string $event;
-    protected User $initiator;
-    protected int $initiatedTime;
-
-    /**
-     * @var string|Loggable
-     */
-    protected $detail;
-
-    /**
-     * @var array{condition: callable(string, Model):bool, format: callable(Model):void}[]
-     */
-    protected $modelFormatters = [];
-
-    public function __construct(string $event, Webhook $webhook, $detail, User $initiator, int $initiatedTime)
-    {
-        $this->webhook = $webhook;
-        $this->event = $event;
-        $this->initiator = $initiator;
-        $this->initiatedTime = $initiatedTime;
-        $this->detail = is_object($detail) ? clone $detail : $detail;
-    }
-
-    public function format(): array
-    {
-        $data = [
-            'event'                    => $this->event,
-            'text'                     => $this->formatText(),
-            'triggered_at'             => Carbon::createFromTimestampUTC($this->initiatedTime)->toISOString(),
-            'triggered_by'             => $this->initiator->attributesToArray(),
-            'triggered_by_profile_url' => $this->initiator->getProfileUrl(),
-            'webhook_id'               => $this->webhook->id,
-            'webhook_name'             => $this->webhook->name,
-        ];
-
-        if (method_exists($this->detail, 'getUrl')) {
-            $data['url'] = $this->detail->getUrl();
-        }
-
-        if ($this->detail instanceof Model) {
-            $data['related_item'] = $this->formatModel();
-        }
-
-        return $data;
-    }
-
-    /**
-     * @param callable(string, Model):bool $condition
-     * @param callable(Model):void         $format
-     */
-    public function addModelFormatter(callable $condition, callable $format): void
-    {
-        $this->modelFormatters[] = [
-            'condition' => $condition,
-            'format'    => $format,
-        ];
-    }
-
-    public function addDefaultModelFormatters(): void
-    {
-        // Load entity owner, creator, updater details
-        $this->addModelFormatter(
-            fn ($event, $model) => ($model instanceof Entity),
-            fn ($model) => $model->load(['ownedBy', 'createdBy', 'updatedBy'])
-        );
-
-        // Load revision detail for page update and create events
-        $this->addModelFormatter(
-            fn ($event, $model) => ($model instanceof Page && ($event === ActivityType::PAGE_CREATE || $event === ActivityType::PAGE_UPDATE)),
-            fn ($model) => $model->load('currentRevision')
-        );
-    }
-
-    protected function formatModel(): array
-    {
-        /** @var Model $model */
-        $model = $this->detail;
-        $model->unsetRelations();
-
-        foreach ($this->modelFormatters as $formatter) {
-            if ($formatter['condition']($this->event, $model)) {
-                $formatter['format']($model);
-            }
-        }
-
-        return $model->toArray();
-    }
-
-    protected function formatText(): string
-    {
-        $textParts = [
-            $this->initiator->name,
-            trans('activities.' . $this->event),
-        ];
-
-        if ($this->detail instanceof Entity) {
-            $textParts[] = '"' . $this->detail->name . '"';
-        }
-
-        return implode(' ', $textParts);
-    }
-
-    public static function getDefault(string $event, Webhook $webhook, $detail, User $initiator, int $initiatedTime): self
-    {
-        $instance = new self($event, $webhook, $detail, $initiator, $initiatedTime);
-        $instance->addDefaultModelFormatters();
-
-        return $instance;
-    }
-}

app/Api/ApiDocsGenerator.php

@@ -3,13 +3,11 @@
 namespace BookStack\Api;
 
 use BookStack\Http\Controllers\Api\ApiController;
-use Exception;
 use Illuminate\Contracts\Container\BindingResolutionException;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Str;
-use Illuminate\Validation\Rules\Password;
 use ReflectionClass;
 use ReflectionException;
 use ReflectionMethod;
@@ -102,37 +100,11 @@ class ApiDocsGenerator
             $this->controllerClasses[$className] = $class;
         }
 
-        $rules = collect($class->getValidationRules()[$methodName] ?? [])->map(function ($validations) {
-            return array_map(function ($validation) {
-                return $this->getValidationAsString($validation);
-            }, $validations);
-        })->toArray();
+        $rules = $class->getValdationRules()[$methodName] ?? [];
 
         return empty($rules) ? null : $rules;
     }
 
-    /**
-     * Convert the given validation message to a readable string.
-     */
-    protected function getValidationAsString($validation): string
-    {
-        if (is_string($validation)) {
-            return $validation;
-        }
-
-        if (is_object($validation) && method_exists($validation, '__toString')) {
-            return strval($validation);
-        }
-
-        if ($validation instanceof Password) {
-            return 'min:8';
-        }
-
-        $class = get_class($validation);
-
-        throw new Exception("Cannot provide string representation of rule for class: {$class}");
-    }
-
     /**
      * Parse out the description text from a class method comment.
      */

app/Api/ListingResponseBuilder.php

@@ -2,10 +2,8 @@
 
 namespace BookStack\Api;
 
-use BookStack\Model;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Collection;
-use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 
 class ListingResponseBuilder
@@ -14,11 +12,6 @@ class ListingResponseBuilder
     protected $request;
     protected $fields;
 
-    /**
-     * @var array<callable>
-     */
-    protected $resultModifiers = [];
-
     protected $filterOperators = [
         'eq'   => '=',
         'ne'   => '!=',
@@ -31,7 +24,6 @@ class ListingResponseBuilder
 
     /**
      * ListingResponseBuilder constructor.
-     * The given fields will be forced visible within the model results.
      */
     public function __construct(Builder $query, Request $request, array $fields)
     {
@@ -43,16 +35,12 @@ class ListingResponseBuilder
     /**
      * Get the response from this builder.
      */
-    public function toResponse(): JsonResponse
+    public function toResponse()
     {
         $filteredQuery = $this->filterQuery($this->query);
 
         $total = $filteredQuery->count();
-        $data = $this->fetchData($filteredQuery)->each(function ($model) {
-            foreach ($this->resultModifiers as $modifier) {
-                $modifier($model);
-            }
-        });
+        $data = $this->fetchData($filteredQuery);
 
         return response()->json([
             'data'  => $data,
@@ -61,17 +49,7 @@ class ListingResponseBuilder
     }
 
     /**
-     * Add a callback to modify each element of the results.
-     *
-     * @param (callable(Model)) $modifier
-     */
-    public function modifyResults($modifier): void
-    {
-        $this->resultModifiers[] = $modifier;
-    }
-
-    /**
-     * Fetch the data to return within the response.
+     * Fetch the data to return in the response.
      */
     protected function fetchData(Builder $query): Collection
     {

app/Auth/Access/Guards/LdapSessionGuard.php

@@ -5,7 +5,6 @@ namespace BookStack\Auth\Access\Guards;
 use BookStack\Auth\Access\LdapService;
 use BookStack\Auth\Access\RegistrationService;
 use BookStack\Auth\User;
-use BookStack\Exceptions\JsonDebugException;
 use BookStack\Exceptions\LdapException;
 use BookStack\Exceptions\LoginAttemptEmailNeededException;
 use BookStack\Exceptions\LoginAttemptException;
@@ -16,7 +15,7 @@ use Illuminate\Support\Str;
 
 class LdapSessionGuard extends ExternalBaseSessionGuard
 {
-    protected LdapService $ldapService;
+    protected $ldapService;
 
     /**
      * LdapSessionGuard constructor.
@@ -60,9 +59,8 @@ class LdapSessionGuard extends ExternalBaseSessionGuard
      * @param array $credentials
      * @param bool  $remember
      *
-     * @throws LdapException*@throws \BookStack\Exceptions\JsonDebugException
      * @throws LoginAttemptException
-     * @throws JsonDebugException
+     * @throws LdapException
      *
      * @return bool
      */
@@ -86,7 +84,7 @@ class LdapSessionGuard extends ExternalBaseSessionGuard
             try {
                 $user = $this->createNewFromLdapAndCreds($userDetails, $credentials);
             } catch (UserRegistrationException $exception) {
-                throw new LoginAttemptException($exception->getMessage());
+                throw new LoginAttemptException($exception->message);
             }
         }
 

app/Auth/Access/LdapService.php

@@ -15,17 +15,12 @@ use Illuminate\Support\Facades\Log;
  */
 class LdapService
 {
-    protected Ldap $ldap;
-    protected GroupSyncService $groupSyncService;
-    protected UserAvatars $userAvatars;
-
-    /**
-     * @var resource
-     */
+    protected $ldap;
+    protected $groupSyncService;
     protected $ldapConnection;
-
-    protected array $config;
-    protected bool $enabled;
+    protected $userAvatars;
+    protected $config;
+    protected $enabled;
 
     /**
      * LdapService constructor.
@@ -279,7 +274,6 @@ class LdapService
      * Get the groups a user is a part of on ldap.
      *
      * @throws LdapException
-     * @throws JsonDebugException
      */
     public function getUserGroups(string $userName): array
     {
@@ -291,17 +285,8 @@ class LdapService
         }
 
         $userGroups = $this->groupFilter($user);
-        $allGroups = $this->getGroupsRecursive($userGroups, []);
 
-        if ($this->config['dump_user_groups']) {
-            throw new JsonDebugException([
-                'details_from_ldap'             => $user,
-                'parsed_direct_user_groups'     => $userGroups,
-                'parsed_recursive_user_groups'  => $allGroups,
-            ]);
-        }
-
-        return $allGroups;
+        return $this->getGroupsRecursive($userGroups, []);
     }
 
     /**
@@ -384,7 +369,6 @@ class LdapService
      * Sync the LDAP groups to the user roles for the current user.
      *
      * @throws LdapException
-     * @throws JsonDebugException
      */
     public function syncGroups(User $user, string $username)
     {

app/Auth/Access/Oidc/OidcException.php

@@ -1,9 +0,0 @@
-<?php
-
-namespace BookStack\Auth\Access\Oidc;
-
-use Exception;
-
-class OidcException extends Exception
-{
-}

app/Auth/Access/Oidc/OidcIssuerDiscoveryException.php

@@ -2,8 +2,6 @@
 
 namespace BookStack\Auth\Access\Oidc;
 
-use Exception;
-
-class OidcIssuerDiscoveryException extends Exception
+class OidcIssuerDiscoveryException extends \Exception
 {
 }

app/Auth/Access/Oidc/OidcJwtSigningKey.php

@@ -60,11 +60,8 @@ class OidcJwtSigningKey
      */
     protected function loadFromJwkArray(array $jwk)
     {
-        // 'alg' is optional for a JWK, but we will still attempt to validate if
-        // it exists otherwise presume it will be compatible.
-        $alg = $jwk['alg'] ?? null;
-        if ($jwk['kty'] !== 'RSA' || !(is_null($alg) || $alg === 'RS256')) {
-            throw new OidcInvalidKeyException("Only RS256 keys are currently supported. Found key using {$alg}");
+        if ($jwk['alg'] !== 'RS256') {
+            throw new OidcInvalidKeyException("Only RS256 keys are currently supported. Found key using {$jwk['alg']}");
         }
 
         if (empty($jwk['use'])) {

app/Auth/Access/Oidc/OidcProviderSettings.php

@@ -164,9 +164,7 @@ class OidcProviderSettings
     protected function filterKeys(array $keys): array
     {
         return array_filter($keys, function (array $key) {
-            $alg = $key['alg'] ?? null;
-
-            return $key['kty'] === 'RSA' && $key['use'] === 'sig' && (is_null($alg) || $alg === 'RS256');
+            return $key['kty'] === 'RSA' && $key['use'] === 'sig' && $key['alg'] === 'RS256';
         });
     }
 

app/Auth/Access/Oidc/OidcService.php

@@ -7,12 +7,14 @@ use BookStack\Auth\Access\LoginService;
 use BookStack\Auth\Access\RegistrationService;
 use BookStack\Auth\User;
 use BookStack\Exceptions\JsonDebugException;
+use BookStack\Exceptions\OpenIdConnectException;
 use BookStack\Exceptions\StoppedAuthenticationException;
 use BookStack\Exceptions\UserRegistrationException;
 use function config;
+use Exception;
 use Illuminate\Support\Facades\Cache;
 use League\OAuth2\Client\OptionProvider\HttpBasicAuthOptionProvider;
-use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
+use Psr\Http\Client\ClientExceptionInterface;
 use Psr\Http\Client\ClientInterface as HttpClient;
 use function trans;
 use function url;
@@ -23,9 +25,9 @@ use function url;
  */
 class OidcService
 {
-    protected RegistrationService $registrationService;
-    protected LoginService $loginService;
-    protected HttpClient $httpClient;
+    protected $registrationService;
+    protected $loginService;
+    protected $httpClient;
 
     /**
      * OpenIdService constructor.
@@ -40,8 +42,6 @@ class OidcService
     /**
      * Initiate an authorization flow.
      *
-     * @throws OidcException
-     *
      * @return array{url: string, state: string}
      */
     public function login(): array
@@ -57,15 +57,14 @@ class OidcService
 
     /**
      * Process the Authorization response from the authorization server and
-     * return the matching, or new if registration active, user matched to the
-     * authorization server. Throws if the user cannot be auth if not authenticated.
+     * return the matching, or new if registration active, user matched to
+     * the authorization server.
+     * Returns null if not authenticated.
      *
-     * @throws JsonDebugException
-     * @throws OidcException
-     * @throws StoppedAuthenticationException
-     * @throws IdentityProviderException
+     * @throws Exception
+     * @throws ClientExceptionInterface
      */
-    public function processAuthorizeResponse(?string $authorizationCode): User
+    public function processAuthorizeResponse(?string $authorizationCode): ?User
     {
         $settings = $this->getProviderSettings();
         $provider = $this->getProvider($settings);
@@ -79,7 +78,8 @@ class OidcService
     }
 
     /**
-     * @throws OidcException
+     * @throws OidcIssuerDiscoveryException
+     * @throws ClientExceptionInterface
      */
     protected function getProviderSettings(): OidcProviderSettings
     {
@@ -100,11 +100,7 @@ class OidcService
 
         // Run discovery
         if ($config['discover'] ?? false) {
-            try {
-                $settings->discoverFromIssuer($this->httpClient, Cache::store(null), 15);
-            } catch (OidcIssuerDiscoveryException $exception) {
-                throw new OidcException('OIDC Discovery Error: ' . $exception->getMessage());
-            }
+            $settings->discoverFromIssuer($this->httpClient, Cache::store(null), 15);
         }
 
         $settings->validate();
@@ -165,8 +161,9 @@ class OidcService
      * Processes a received access token for a user. Login the user when
      * they exist, optionally registering them automatically.
      *
-     * @throws OidcException
+     * @throws OpenIdConnectException
      * @throws JsonDebugException
+     * @throws UserRegistrationException
      * @throws StoppedAuthenticationException
      */
     protected function processAccessTokenCallback(OidcAccessToken $accessToken, OidcProviderSettings $settings): User
@@ -185,28 +182,28 @@ class OidcService
         try {
             $idToken->validate($settings->clientId);
         } catch (OidcInvalidTokenException $exception) {
-            throw new OidcException("ID token validate failed with error: {$exception->getMessage()}");
+            throw new OpenIdConnectException("ID token validate failed with error: {$exception->getMessage()}");
         }
 
         $userDetails = $this->getUserDetails($idToken);
         $isLoggedIn = auth()->check();
 
         if (empty($userDetails['email'])) {
-            throw new OidcException(trans('errors.oidc_no_email_address'));
+            throw new OpenIdConnectException(trans('errors.oidc_no_email_address'));
         }
 
         if ($isLoggedIn) {
-            throw new OidcException(trans('errors.oidc_already_logged_in'));
+            throw new OpenIdConnectException(trans('errors.oidc_already_logged_in'), '/login');
         }
 
-        try {
-            $user = $this->registrationService->findOrRegister(
-                $userDetails['name'],
-                $userDetails['email'],
-                $userDetails['external_id']
-            );
-        } catch (UserRegistrationException $exception) {
-            throw new OidcException($exception->getMessage());
+        $user = $this->registrationService->findOrRegister(
+            $userDetails['name'],
+            $userDetails['email'],
+            $userDetails['external_id']
+        );
+
+        if ($user === null) {
+            throw new OpenIdConnectException(trans('errors.oidc_user_not_registered', ['name' => $userDetails['external_id']]), '/login');
         }
 
         $this->loginService->login($user, 'oidc');

app/Auth/Access/RegistrationService.php

@@ -96,8 +96,7 @@ class RegistrationService
         }
 
         // Create the user
-        $newUser = $this->userRepo->createWithoutActivity($userData, $emailConfirmed);
-        $newUser->attachDefaultRole();
+        $newUser = $this->userRepo->registerNew($userData, $emailConfirmed);
 
         // Assign social account if given
         if ($socialAccount) {

app/Auth/Queries/AllUsersPaginatedAndSorted.php

@@ -1,39 +0,0 @@
-<?php
-
-namespace BookStack\Auth\Queries;
-
-use BookStack\Auth\User;
-use Illuminate\Pagination\LengthAwarePaginator;
-
-/**
- * Get all the users with their permissions in a paginated format.
- * Note: Due to the use of email search this should only be used when
- * user is assumed to be trusted. (Admin users).
- * Email search can be abused to extract email addresses.
- */
-class AllUsersPaginatedAndSorted
-{
-    /**
-     * @param array{sort: string, order: string, search: string} $sortData
-     */
-    public function run(int $count, array $sortData): LengthAwarePaginator
-    {
-        $sort = $sortData['sort'];
-
-        $query = User::query()->select(['*'])
-            ->scopes(['withLastActivityAt'])
-            ->with(['roles', 'avatar'])
-            ->withCount('mfaValues')
-            ->orderBy($sort, $sortData['order']);
-
-        if ($sortData['search']) {
-            $term = '%' . $sortData['search'] . '%';
-            $query->where(function ($query) use ($term) {
-                $query->where('name', 'like', $term)
-                    ->orWhere('email', 'like', $term);
-            });
-        }
-
-        return $query->paginate($count);
-    }
-}

app/Auth/Queries/UserContentCounts.php

@@ -1,30 +0,0 @@
-<?php
-
-namespace BookStack\Auth\Queries;
-
-use BookStack\Auth\User;
-use BookStack\Entities\Models\Book;
-use BookStack\Entities\Models\Bookshelf;
-use BookStack\Entities\Models\Chapter;
-use BookStack\Entities\Models\Page;
-
-/**
- * Get asset created counts for the given user.
- */
-class UserContentCounts
-{
-    /**
-     * @return array{pages: int, chapters: int, books: int, shelves: int}
-     */
-    public function run(User $user): array
-    {
-        $createdBy = ['created_by' => $user->id];
-
-        return [
-            'pages'    => Page::visible()->where($createdBy)->count(),
-            'chapters' => Chapter::visible()->where($createdBy)->count(),
-            'books'    => Book::visible()->where($createdBy)->count(),
-            'shelves'  => Bookshelf::visible()->where($createdBy)->count(),
-        ];
-    }
-}

app/Auth/Queries/UserRecentlyCreatedContent.php

@@ -1,37 +0,0 @@
-<?php
-
-namespace BookStack\Auth\Queries;
-
-use BookStack\Auth\User;
-use BookStack\Entities\Models\Book;
-use BookStack\Entities\Models\Bookshelf;
-use BookStack\Entities\Models\Chapter;
-use BookStack\Entities\Models\Page;
-use Illuminate\Database\Eloquent\Builder;
-use Illuminate\Database\Eloquent\Collection;
-
-/**
- * Get the recently created content for the provided user.
- */
-class UserRecentlyCreatedContent
-{
-    /**
-     * @return array{pages: Collection, chapters: Collection, books: Collection, shelves: Collection}
-     */
-    public function run(User $user, int $count): array
-    {
-        $query = function (Builder $query) use ($user, $count) {
-            return $query->orderBy('created_at', 'desc')
-                ->where('created_by', '=', $user->id)
-                ->take($count)
-                ->get();
-        };
-
-        return [
-            'pages'    => $query(Page::visible()->where('draft', '=', false)),
-            'chapters' => $query(Chapter::visible()),
-            'books'    => $query(Book::visible()),
-            'shelves'  => $query(Bookshelf::visible()),
-        ];
-    }
-}

app/Auth/Role.php

@@ -28,8 +28,6 @@ class Role extends Model implements Loggable
 
     protected $fillable = ['display_name', 'description', 'external_auth_id'];
 
-    protected $hidden = ['pivot'];
-
     /**
      * The roles that belong to the role.
      */

app/Auth/User.php

@@ -72,20 +72,22 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
      */
     protected $hidden = [
         'password', 'remember_token', 'system_name', 'email_confirmed', 'external_auth_id', 'email',
-        'created_at', 'updated_at', 'image_id', 'roles', 'avatar', 'user_id',
+        'created_at', 'updated_at', 'image_id',
     ];
 
     /**
      * This holds the user's permissions when loaded.
+     *
+     * @var ?Collection
      */
-    protected ?Collection $permissions;
+    protected $permissions;
 
     /**
      * This holds the default user when loaded.
      *
      * @var null|User
      */
-    protected static ?User $defaultUser = null;
+    protected static $defaultUser = null;
 
     /**
      * Returns the default public user.
@@ -144,7 +146,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
      */
     public function attachDefaultRole(): void
     {
-        $roleId = intval(setting('registration-role'));
+        $roleId = setting('registration-role');
         if ($roleId && $this->roles()->where('id', '=', $roleId)->count() === 0) {
             $this->roles()->attach($roleId);
         }

app/Auth/UserRepo.php

@@ -2,29 +2,30 @@
 
 namespace BookStack\Auth;
 
-use BookStack\Actions\ActivityType;
-use BookStack\Auth\Access\UserInviteService;
 use BookStack\Entities\EntityProvider;
-use BookStack\Exceptions\NotifyException;
+use BookStack\Entities\Models\Book;
+use BookStack\Entities\Models\Bookshelf;
+use BookStack\Entities\Models\Chapter;
+use BookStack\Entities\Models\Page;
+use BookStack\Exceptions\NotFoundException;
 use BookStack\Exceptions\UserUpdateException;
-use BookStack\Facades\Activity;
 use BookStack\Uploads\UserAvatars;
 use Exception;
+use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Facades\Log;
-use Illuminate\Support\Str;
 
 class UserRepo
 {
-    protected UserAvatars $userAvatar;
-    protected UserInviteService $inviteService;
+    protected $userAvatar;
 
     /**
      * UserRepo constructor.
      */
-    public function __construct(UserAvatars $userAvatar, UserInviteService $inviteService)
+    public function __construct(UserAvatars $userAvatar)
     {
         $this->userAvatar = $userAvatar;
-        $this->inviteService = $inviteService;
     }
 
     /**
@@ -52,164 +53,70 @@ class UserRepo
     }
 
     /**
-     * Create a new basic instance of user with the given pre-validated data.
-     *
-     * @param array{name: string, email: string, password: ?string, external_auth_id: ?string, language: ?string, roles: ?array} $data
+     * Get all the users with their permissions.
      */
-    public function createWithoutActivity(array $data, bool $emailConfirmed = false): User
+    public function getAllUsers(): Collection
     {
-        $user = new User();
-        $user->name = $data['name'];
-        $user->email = $data['email'];
-        $user->password = bcrypt(empty($data['password']) ? Str::random(32) : $data['password']);
-        $user->email_confirmed = $emailConfirmed;
-        $user->external_auth_id = $data['external_auth_id'] ?? '';
+        return User::query()->with('roles', 'avatar')->orderBy('name', 'asc')->get();
+    }
 
-        $user->refreshSlug();
-        $user->save();
+    /**
+     * Get all the users with their permissions in a paginated format.
+     * Note: Due to the use of email search this should only be used when
+     * user is assumed to be trusted. (Admin users).
+     * Email search can be abused to extract email addresses.
+     */
+    public function getAllUsersPaginatedAndSorted(int $count, array $sortData): LengthAwarePaginator
+    {
+        $sort = $sortData['sort'];
 
-        if (!empty($data['language'])) {
-            setting()->putUser($user, 'language', $data['language']);
+        $query = User::query()->select(['*'])
+            ->scopes(['withLastActivityAt'])
+            ->with(['roles', 'avatar'])
+            ->withCount('mfaValues')
+            ->orderBy($sort, $sortData['order']);
+
+        if ($sortData['search']) {
+            $term = '%' . $sortData['search'] . '%';
+            $query->where(function ($query) use ($term) {
+                $query->where('name', 'like', $term)
+                    ->orWhere('email', 'like', $term);
+            });
         }
 
-        if (isset($data['roles'])) {
-            $this->setUserRoles($user, $data['roles']);
-        }
+        return $query->paginate($count);
+    }
 
+    /**
+     * Creates a new user and attaches a role to them.
+     */
+    public function registerNew(array $data, bool $emailConfirmed = false): User
+    {
+        $user = $this->create($data, $emailConfirmed);
+        $user->attachDefaultRole();
         $this->downloadAndAssignUserAvatar($user);
 
         return $user;
     }
 
     /**
-     * As per "createWithoutActivity" but records a "create" activity.
+     * Assign a user to a system-level role.
      *
-     * @param array{name: string, email: string, password: ?string, external_auth_id: ?string, language: ?string, roles: ?array} $data
+     * @throws NotFoundException
      */
-    public function create(array $data, bool $sendInvite = false): User
+    public function attachSystemRole(User $user, string $systemRoleName)
     {
-        $user = $this->createWithoutActivity($data, true);
-
-        if ($sendInvite) {
-            $this->inviteService->sendInvitation($user);
-        }
-
-        Activity::add(ActivityType::USER_CREATE, $user);
-
-        return $user;
-    }
-
-    /**
-     * Update the given user with the given data.
-     *
-     * @param array{name: ?string, email: ?string, external_auth_id: ?string, password: ?string, roles: ?array<int>, language: ?string} $data
-     *
-     * @throws UserUpdateException
-     */
-    public function update(User $user, array $data, bool $manageUsersAllowed): User
-    {
-        if (!empty($data['name'])) {
-            $user->name = $data['name'];
-            $user->refreshSlug();
-        }
-
-        if (!empty($data['email']) && $manageUsersAllowed) {
-            $user->email = $data['email'];
-        }
-
-        if (!empty($data['external_auth_id']) && $manageUsersAllowed) {
-            $user->external_auth_id = $data['external_auth_id'];
-        }
-
-        if (isset($data['roles']) && $manageUsersAllowed) {
-            $this->setUserRoles($user, $data['roles']);
-        }
-
-        if (!empty($data['password'])) {
-            $user->password = bcrypt($data['password']);
-        }
-
-        if (!empty($data['language'])) {
-            setting()->putUser($user, 'language', $data['language']);
-        }
-
-        $user->save();
-        Activity::add(ActivityType::USER_UPDATE, $user);
-
-        return $user;
-    }
-
-    /**
-     * Remove the given user from storage, Delete all related content.
-     *
-     * @throws Exception
-     */
-    public function destroy(User $user, ?int $newOwnerId = null)
-    {
-        $this->ensureDeletable($user);
-
-        $user->socialAccounts()->delete();
-        $user->apiTokens()->delete();
-        $user->favourites()->delete();
-        $user->mfaValues()->delete();
-        $user->delete();
-
-        // Delete user profile images
-        $this->userAvatar->destroyAllForUser($user);
-
-        if (!empty($newOwnerId)) {
-            $newOwner = User::query()->find($newOwnerId);
-            if (!is_null($newOwner)) {
-                $this->migrateOwnership($user, $newOwner);
-            }
-        }
-
-        Activity::add(ActivityType::USER_DELETE, $user);
-    }
-
-    /**
-     * @throws NotifyException
-     */
-    protected function ensureDeletable(User $user): void
-    {
-        if ($this->isOnlyAdmin($user)) {
-            throw new NotifyException(trans('errors.users_cannot_delete_only_admin'), $user->getEditUrl());
-        }
-
-        if ($user->system_name === 'public') {
-            throw new NotifyException(trans('errors.users_cannot_delete_guest'), $user->getEditUrl());
-        }
-    }
-
-    /**
-     * Migrate ownership of items in the system from one user to another.
-     */
-    protected function migrateOwnership(User $fromUser, User $toUser)
-    {
-        $entities = (new EntityProvider())->all();
-        foreach ($entities as $instance) {
-            $instance->newQuery()->where('owned_by', '=', $fromUser->id)
-                ->update(['owned_by' => $toUser->id]);
-        }
-    }
-
-    /**
-     * Get an avatar image for a user and set it as their avatar.
-     * Returns early if avatars disabled or not set in config.
-     */
-    protected function downloadAndAssignUserAvatar(User $user): void
-    {
-        try {
-            $this->userAvatar->fetchAndAssignToUser($user);
-        } catch (Exception $e) {
-            Log::error('Failed to save user avatar image');
+        $role = Role::getSystemRole($systemRoleName);
+        if (is_null($role)) {
+            throw new NotFoundException("Role '{$systemRoleName}' not found");
         }
+        $user->attachRole($role);
     }
 
     /**
      * Checks if the give user is the only admin.
      */
-    protected function isOnlyAdmin(User $user): bool
+    public function isOnlyAdmin(User $user): bool
     {
         if (!$user->hasSystemRole('admin')) {
             return false;
@@ -228,7 +135,7 @@ class UserRepo
      *
      * @throws UserUpdateException
      */
-    protected function setUserRoles(User $user, array $roles)
+    public function setUserRoles(User $user, array $roles)
     {
         if ($this->demotingLastAdmin($user, $roles)) {
             throw new UserUpdateException(trans('errors.role_cannot_remove_only_admin'), $user->getEditUrl());
@@ -252,4 +159,117 @@ class UserRepo
 
         return false;
     }
+
+    /**
+     * Create a new basic instance of user.
+     */
+    public function create(array $data, bool $emailConfirmed = false): User
+    {
+        $details = [
+            'name'             => $data['name'],
+            'email'            => $data['email'],
+            'password'         => bcrypt($data['password']),
+            'email_confirmed'  => $emailConfirmed,
+            'external_auth_id' => $data['external_auth_id'] ?? '',
+        ];
+
+        $user = new User();
+        $user->forceFill($details);
+        $user->refreshSlug();
+        $user->save();
+
+        return $user;
+    }
+
+    /**
+     * Remove the given user from storage, Delete all related content.
+     *
+     * @throws Exception
+     */
+    public function destroy(User $user, ?int $newOwnerId = null)
+    {
+        $user->socialAccounts()->delete();
+        $user->apiTokens()->delete();
+        $user->favourites()->delete();
+        $user->mfaValues()->delete();
+        $user->delete();
+
+        // Delete user profile images
+        $this->userAvatar->destroyAllForUser($user);
+
+        if (!empty($newOwnerId)) {
+            $newOwner = User::query()->find($newOwnerId);
+            if (!is_null($newOwner)) {
+                $this->migrateOwnership($user, $newOwner);
+            }
+        }
+    }
+
+    /**
+     * Migrate ownership of items in the system from one user to another.
+     */
+    protected function migrateOwnership(User $fromUser, User $toUser)
+    {
+        $entities = (new EntityProvider())->all();
+        foreach ($entities as $instance) {
+            $instance->newQuery()->where('owned_by', '=', $fromUser->id)
+                ->update(['owned_by' => $toUser->id]);
+        }
+    }
+
+    /**
+     * Get the recently created content for this given user.
+     */
+    public function getRecentlyCreated(User $user, int $count = 20): array
+    {
+        $query = function (Builder $query) use ($user, $count) {
+            return $query->orderBy('created_at', 'desc')
+                ->where('created_by', '=', $user->id)
+                ->take($count)
+                ->get();
+        };
+
+        return [
+            'pages'    => $query(Page::visible()->where('draft', '=', false)),
+            'chapters' => $query(Chapter::visible()),
+            'books'    => $query(Book::visible()),
+            'shelves'  => $query(Bookshelf::visible()),
+        ];
+    }
+
+    /**
+     * Get asset created counts for the give user.
+     */
+    public function getAssetCounts(User $user): array
+    {
+        $createdBy = ['created_by' => $user->id];
+
+        return [
+            'pages'       => Page::visible()->where($createdBy)->count(),
+            'chapters'    => Chapter::visible()->where($createdBy)->count(),
+            'books'       => Book::visible()->where($createdBy)->count(),
+            'shelves'     => Bookshelf::visible()->where($createdBy)->count(),
+        ];
+    }
+
+    /**
+     * Get the roles in the system that are assignable to a user.
+     */
+    public function getAllRoles(): Collection
+    {
+        return Role::query()->orderBy('display_name', 'asc')->get();
+    }
+
+    /**
+     * Get an avatar image for a user and set it as their avatar.
+     * Returns early if avatars disabled or not set in config.
+     */
+    public function downloadAndAssignUserAvatar(User $user): void
+    {
+        try {
+            $this->userAvatar->fetchAndAssignToUser($user);
+        } catch (Exception $e) {
+            Log::error('Failed to save user avatar image');
+        }
+    }
 }

app/Config/app.php

@@ -57,13 +57,6 @@ return [
     // Space separated if multiple. BookStack host domain is auto-inferred.
     'iframe_hosts' => env('ALLOWED_IFRAME_HOSTS', null),
 
-    // A list of sources/hostnames that can be loaded within iframes within BookStack.
-    // Space separated if multiple. BookStack host domain is auto-inferred.
-    // Can be set to a lone "*" to allow all sources for iframe content (Not advised).
-    // Defaults to a set of common services.
-    // Current host and source for the "DRAWIO" setting will be auto-appended to the sources configured.
-    'iframe_sources' => env('ALLOWED_IFRAME_SOURCES', 'https://*.draw.io https://*.youtube.com https://*.youtube-nocookie.com https://*.vimeo.com'),
-
     // Application timezone for back-end date functions.
     'timezone' => env('APP_TIMEZONE', 'UTC'),
 
@@ -71,7 +64,7 @@ return [
     'locale' => env('APP_LANG', 'en'),
 
     // Locales available
-    'locales' => ['en', 'ar', 'bg', 'bs', 'ca', 'cs', 'da', 'de', 'de_informal', 'es', 'es_AR', 'et', 'eu', 'fa', 'fr', 'he', 'hr', 'hu', 'id', 'it', 'ja', 'ko', 'lt', 'lv', 'nl', 'nb', 'pt', 'pt_BR', 'sk', 'sl', 'sv', 'pl',  'ru', 'th', 'tr', 'uk', 'uz', 'vi', 'zh_CN', 'zh_TW'],
+    'locales' => ['en', 'ar', 'bg', 'bs', 'ca', 'cs', 'da', 'de', 'de_informal', 'es', 'es_AR', 'et', 'fa', 'fr', 'he', 'hr', 'hu', 'id', 'it', 'ja', 'ko', 'lt', 'lv', 'nl', 'nb', 'pt', 'pt_BR', 'sk', 'sl', 'sv', 'pl',  'ru', 'th', 'tr', 'uk', 'vi', 'zh_CN', 'zh_TW'],
 
     //  Application Fallback Locale
     'fallback_locale' => 'en',

app/Config/dompdf.php

@@ -7,10 +7,6 @@
  * Configuration should be altered via the `.env` file or environment variables.
  * Do not edit this file unless you're happy to maintain any changes yourself.
  */
-$dompdfPaperSizeMap = [
-    'a4'     => 'a4',
-    'letter' => 'letter',
-];
 
 return [
 
@@ -154,7 +150,7 @@ return [
          *
          * @see CPDF_Adapter::PAPER_SIZES for valid sizes ('letter', 'legal', 'A4', etc.)
          */
-        'default_paper_size' => $dompdfPaperSizeMap[env('EXPORT_PAGE_SIZE', 'a4')] ?? 'a4',
+        'default_paper_size' => 'a4',
 
         /**
          * The default font family.

app/Config/services.php

@@ -119,7 +119,6 @@ return [
     'ldap' => [
         'server'                 => env('LDAP_SERVER', false),
         'dump_user_details'      => env('LDAP_DUMP_USER_DETAILS', false),
-        'dump_user_groups'       => env('LDAP_DUMP_USER_GROUPS', false),
         'dn'                     => env('LDAP_DN', false),
         'pass'                   => env('LDAP_PASS', false),
         'base_dn'                => env('LDAP_BASE_DN', false),

app/Config/snappy.php

@@ -7,10 +7,6 @@
  * Configuration should be altered via the `.env` file or environment variables.
  * Do not edit this file unless you're happy to maintain any changes yourself.
  */
-$snappyPaperSizeMap = [
-    'a4'     => 'A4',
-    'letter' => 'Letter',
-];
 
 return [
     'pdf' => [
@@ -18,8 +14,7 @@ return [
         'binary'  => file_exists(base_path('wkhtmltopdf')) ? base_path('wkhtmltopdf') : env('WKHTMLTOPDF', false),
         'timeout' => false,
         'options' => [
-            'outline'   => true,
-            'page-size' => $snappyPaperSizeMap[env('EXPORT_PAGE_SIZE', 'a4')] ?? 'A4',
+            'outline' => true,
         ],
         'env'     => [],
     ],

app/Console/Commands/CreateAdmin.php

@@ -2,12 +2,9 @@
 
 namespace BookStack\Console\Commands;
 
-use BookStack\Auth\Role;
 use BookStack\Auth\UserRepo;
-use BookStack\Exceptions\NotFoundException;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\Validator;
-use Illuminate\Support\Str;
 use Illuminate\Validation\Rules\Password;
 use Illuminate\Validation\Rules\Unique;
 use Symfony\Component\Console\Command\Command as SymfonyCommand;
@@ -22,8 +19,7 @@ class CreateAdmin extends Command
     protected $signature = 'bookstack:create-admin
                             {--email= : The email address for the new admin user}
                             {--name= : The name of the new admin user}
-                            {--password= : The password to assign to the new admin user}
-                            {--external-auth-id= : The external authentication system id for the new admin user (SAML2/LDAP/OIDC)}';
+                            {--password= : The password to assign to the new admin user}';
 
     /**
      * The console command description.
@@ -46,35 +42,28 @@ class CreateAdmin extends Command
     /**
      * Execute the console command.
      *
-     * @throws NotFoundException
+     * @throws \BookStack\Exceptions\NotFoundException
      *
      * @return mixed
      */
     public function handle()
     {
-        $details = $this->snakeCaseOptions();
+        $details = $this->options();
 
         if (empty($details['email'])) {
             $details['email'] = $this->ask('Please specify an email address for the new admin user');
         }
-
         if (empty($details['name'])) {
             $details['name'] = $this->ask('Please specify a name for the new admin user');
         }
-
         if (empty($details['password'])) {
-            if (empty($details['external_auth_id'])) {
-                $details['password'] = $this->ask('Please specify a password for the new admin user (8 characters min)');
-            } else {
-                $details['password'] = Str::random(32);
-            }
+            $details['password'] = $this->ask('Please specify a password for the new admin user (8 characters min)');
         }
 
         $validator = Validator::make($details, [
-            'email'            => ['required', 'email', 'min:5', new Unique('users', 'email')],
-            'name'             => ['required', 'min:2'],
-            'password'         => ['required_without:external_auth_id', Password::default()],
-            'external_auth_id' => ['required_without:password'],
+            'email'    => ['required', 'email', 'min:5', new Unique('users', 'email')],
+            'name'     => ['required', 'min:2'],
+            'password' => ['required', Password::default()],
         ]);
 
         if ($validator->fails()) {
@@ -85,8 +74,9 @@ class CreateAdmin extends Command
             return SymfonyCommand::FAILURE;
         }
 
-        $user = $this->userRepo->createWithoutActivity($validator->validated());
-        $user->attachRole(Role::getSystemRole('admin'));
+        $user = $this->userRepo->create($validator->validated());
+        $this->userRepo->attachSystemRole($user, 'admin');
+        $this->userRepo->downloadAndAssignUserAvatar($user);
         $user->email_confirmed = true;
         $user->save();
 
@@ -94,14 +84,4 @@ class CreateAdmin extends Command
 
         return SymfonyCommand::SUCCESS;
     }
-
-    protected function snakeCaseOptions(): array
-    {
-        $returnOpts = [];
-        foreach ($this->options() as $key => $value) {
-            $returnOpts[str_replace('-', '_', $key)] = $value;
-        }
-
-        return $returnOpts;
-    }
 }

app/Console/Commands/DeleteUsers.php

@@ -15,6 +15,8 @@ class DeleteUsers extends Command
      */
     protected $signature = 'bookstack:delete-users';
 
+    protected $user;
+
     protected $userRepo;
 
     /**
@@ -24,8 +26,9 @@ class DeleteUsers extends Command
      */
     protected $description = 'Delete users that are not "admin" or system users';
 
-    public function __construct(UserRepo $userRepo)
+    public function __construct(User $user, UserRepo $userRepo)
     {
+        $this->user = $user;
         $this->userRepo = $userRepo;
         parent::__construct();
     }
@@ -35,8 +38,8 @@ class DeleteUsers extends Command
         $confirm = $this->ask('This will delete all users from the system that are not "admin" or system users. Are you sure you want to continue? (Type "yes" to continue)');
         $numDeleted = 0;
         if (strtolower(trim($confirm)) === 'yes') {
-            $totalUsers = User::query()->count();
-            $users = User::query()->whereNull('system_name')->with('roles')->get();
+            $totalUsers = $this->user->count();
+            $users = $this->user->where('system_name', '=', null)->with('roles')->get();
             foreach ($users as $user) {
                 if ($user->hasSystemRole('admin')) {
                     // don't delete users with "admin" role

app/Entities/Models/Deletion.php

@@ -10,16 +10,10 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\MorphTo;
 
 /**
- * @property int       $id
- * @property int       $deleted_by
- * @property string    $deletable_type
- * @property int       $deletable_id
  * @property Deletable $deletable
  */
 class Deletion extends Model implements Loggable
 {
-    protected $hidden = [];
-
     /**
      * Get the related deletable record.
      */
@@ -65,7 +59,7 @@ class Deletion extends Model implements Loggable
     /**
      * Get a URL for this specific deletion.
      */
-    public function getUrl(string $path = 'restore'): string
+    public function getUrl($path): string
     {
         return url("/settings/recycle-bin/{$this->id}/" . ltrim($path, '/'));
     }

app/Entities/Models/Entity.php

@@ -36,7 +36,6 @@ use Illuminate\Database\Eloquent\SoftDeletes;
  * @property string     $slug
  * @property Carbon     $created_at
  * @property Carbon     $updated_at
- * @property Carbon     $deleted_at
  * @property int        $created_by
  * @property int        $updated_by
  * @property bool       $restricted

app/Entities/Models/Page.php

@@ -10,23 +10,19 @@ use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\HasMany;
-use Illuminate\Database\Eloquent\Relations\HasOne;
 
 /**
  * Class Page.
  *
- * @property int          $chapter_id
- * @property string       $html
- * @property string       $markdown
- * @property string       $text
- * @property bool         $template
- * @property bool         $draft
- * @property int          $revision_count
- * @property string       $editor
- * @property Chapter      $chapter
- * @property Collection   $attachments
- * @property Collection   $revisions
- * @property PageRevision $currentRevision
+ * @property int        $chapter_id
+ * @property string     $html
+ * @property string     $markdown
+ * @property string     $text
+ * @property bool       $template
+ * @property bool       $draft
+ * @property int        $revision_count
+ * @property Chapter    $chapter
+ * @property Collection $attachments
  */
 class Page extends BookChild
 {
@@ -86,19 +82,6 @@ class Page extends BookChild
             ->orderBy('id', 'desc');
     }
 
-    /**
-     * Get the current revision for the page if existing.
-     *
-     * @return PageRevision|null
-     */
-    public function currentRevision(): HasOne
-    {
-        return $this->hasOne(PageRevision::class)
-            ->where('type', '=', 'version')
-            ->orderBy('created_at', 'desc')
-            ->orderBy('id', 'desc');
-    }
-
     /**
      * Get all revision instances assigned to this page.
      * Includes all types of revisions.
@@ -134,6 +117,16 @@ class Page extends BookChild
         return url('/' . implode('/', $parts));
     }
 
+    /**
+     * Get the current revision for the page if existing.
+     *
+     * @return PageRevision|null
+     */
+    public function getCurrentRevision()
+    {
+        return $this->revisions()->first();
+    }
+
     /**
      * Get this page for JSON display.
      */

app/Entities/Models/PageRevision.php

@@ -10,9 +10,7 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
 /**
  * Class PageRevision.
  *
- * @property mixed  $id
  * @property int    $page_id
- * @property string $name
  * @property string $slug
  * @property string $book_slug
  * @property int    $created_by
@@ -22,15 +20,13 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
  * @property string $summary
  * @property string $markdown
  * @property string $html
- * @property string $text
  * @property int    $revision_number
  * @property Page   $page
  * @property-read ?User $createdBy
  */
 class PageRevision extends Model
 {
-    protected $fillable = ['name', 'text', 'summary'];
-    protected $hidden = ['html', 'markdown', 'restricted', 'text'];
+    protected $fillable = ['name', 'html', 'text', 'markdown', 'summary'];
 
     /**
      * Get the user that created the page revision.
@@ -50,10 +46,19 @@ class PageRevision extends Model
 
     /**
      * Get the url for this revision.
+     *
+     * @param null|string $path
+     *
+     * @return string
      */
-    public function getUrl(string $path = ''): string
+    public function getUrl($path = null)
     {
-        return $this->page->getUrl('/revisions/' . $this->id . '/' . ltrim($path, '/'));
+        $url = $this->page->getUrl() . '/revisions/' . $this->id;
+        if ($path) {
+            return $url . '/' . trim($path, '/');
+        }
+
+        return $url;
     }
 
     /**

app/Entities/Repos/BaseRepo.php

@@ -11,8 +11,8 @@ use Illuminate\Http\UploadedFile;
 
 class BaseRepo
 {
-    protected TagRepo $tagRepo;
-    protected ImageRepo $imageRepo;
+    protected $tagRepo;
+    protected $imageRepo;
 
     public function __construct(TagRepo $tagRepo, ImageRepo $imageRepo)
     {
@@ -58,7 +58,6 @@ class BaseRepo
 
         if (isset($input['tags'])) {
             $this->tagRepo->saveTagsToEntity($entity, $input['tags']);
-            $entity->touch();
         }
 
         $entity->rebuildPermissions();

app/Entities/Repos/DeletionRepo.php

@@ -1,36 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Repos;
-
-use BookStack\Actions\ActivityType;
-use BookStack\Entities\Models\Deletion;
-use BookStack\Entities\Tools\TrashCan;
-use BookStack\Facades\Activity;
-
-class DeletionRepo
-{
-    private TrashCan $trashCan;
-
-    public function __construct(TrashCan $trashCan)
-    {
-        $this->trashCan = $trashCan;
-    }
-
-    public function restore(int $id): int
-    {
-        /** @var Deletion $deletion */
-        $deletion = Deletion::query()->findOrFail($id);
-        Activity::add(ActivityType::RECYCLE_BIN_RESTORE, $deletion);
-
-        return $this->trashCan->restoreFromDeletion($deletion);
-    }
-
-    public function destroy(int $id): int
-    {
-        /** @var Deletion $deletion */
-        $deletion = Deletion::query()->findOrFail($id);
-        Activity::add(ActivityType::RECYCLE_BIN_DESTROY, $deletion);
-
-        return $this->trashCan->destroyFromDeletion($deletion);
-    }
-}

app/Entities/Repos/PageRepo.php

@@ -10,7 +10,6 @@ use BookStack\Entities\Models\Page;
 use BookStack\Entities\Models\PageRevision;
 use BookStack\Entities\Tools\BookContents;
 use BookStack\Entities\Tools\PageContent;
-use BookStack\Entities\Tools\PageEditorData;
 use BookStack\Entities\Tools\TrashCan;
 use BookStack\Exceptions\MoveOperationException;
 use BookStack\Exceptions\NotFoundException;
@@ -218,25 +217,11 @@ class PageRepo
         }
 
         $pageContent = new PageContent($page);
-        $currentEditor = $page->editor ?: PageEditorData::getSystemDefaultEditor();
-        $newEditor = $currentEditor;
-
-        $haveInput = isset($input['markdown']) || isset($input['html']);
-        $inputEmpty = empty($input['markdown']) && empty($input['html']);
-
-        if ($haveInput && $inputEmpty) {
-            $pageContent->setNewHTML('');
-        } elseif (!empty($input['markdown']) && is_string($input['markdown'])) {
-            $newEditor = 'markdown';
+        if (!empty($input['markdown'] ?? '')) {
             $pageContent->setNewMarkdown($input['markdown']);
         } elseif (isset($input['html'])) {
-            $newEditor = 'wysiwyg';
             $pageContent->setNewHTML($input['html']);
         }
-
-        if ($newEditor !== $currentEditor && userCan('editor-change')) {
-            $page->editor = $newEditor;
-        }
     }
 
     /**
@@ -244,12 +229,8 @@ class PageRepo
      */
     protected function savePageRevision(Page $page, string $summary = null): PageRevision
     {
-        $revision = new PageRevision();
+        $revision = new PageRevision($page->getAttributes());
 
-        $revision->name = $page->name;
-        $revision->html = $page->html;
-        $revision->markdown = $page->markdown;
-        $revision->text = $page->text;
         $revision->page_id = $page->id;
         $revision->slug = $page->slug;
         $revision->book_slug = $page->book->slug;
@@ -279,15 +260,10 @@ class PageRepo
             return $page;
         }
 
-        // Otherwise, save the data to a revision
+        // Otherwise save the data to a revision
         $draft = $this->getPageRevisionToUpdate($page);
         $draft->fill($input);
-
-        if (!empty($input['markdown'])) {
-            $draft->markdown = $input['markdown'];
-            $draft->html = '';
-        } else {
-            $draft->html = $input['html'];
+        if (setting('app-editor') !== 'markdown') {
             $draft->markdown = '';
         }
 

app/Entities/Tools/ExportFormatter.php

@@ -7,7 +7,6 @@ use BookStack\Entities\Models\Chapter;
 use BookStack\Entities\Models\Page;
 use BookStack\Entities\Tools\Markdown\HtmlToMarkdown;
 use BookStack\Uploads\ImageService;
-use BookStack\Util\CspService;
 use DOMDocument;
 use DOMElement;
 use DOMXPath;
@@ -16,18 +15,16 @@ use Throwable;
 
 class ExportFormatter
 {
-    protected ImageService $imageService;
-    protected PdfGenerator $pdfGenerator;
-    protected CspService $cspService;
+    protected $imageService;
+    protected $pdfGenerator;
 
     /**
      * ExportService constructor.
      */
-    public function __construct(ImageService $imageService, PdfGenerator $pdfGenerator, CspService $cspService)
+    public function __construct(ImageService $imageService, PdfGenerator $pdfGenerator)
     {
         $this->imageService = $imageService;
         $this->pdfGenerator = $pdfGenerator;
-        $this->cspService = $cspService;
     }
 
     /**
@@ -40,9 +37,8 @@ class ExportFormatter
     {
         $page->html = (new PageContent($page))->render();
         $pageHtml = view('pages.export', [
-            'page'       => $page,
-            'format'     => 'html',
-            'cspContent' => $this->cspService->getCspMetaTagValue(),
+            'page'   => $page,
+            'format' => 'html',
         ])->render();
 
         return $this->containHtml($pageHtml);
@@ -60,10 +56,9 @@ class ExportFormatter
             $page->html = (new PageContent($page))->render();
         });
         $html = view('chapters.export', [
-            'chapter'    => $chapter,
-            'pages'      => $pages,
-            'format'     => 'html',
-            'cspContent' => $this->cspService->getCspMetaTagValue(),
+            'chapter' => $chapter,
+            'pages'   => $pages,
+            'format'  => 'html',
         ])->render();
 
         return $this->containHtml($html);
@@ -81,7 +76,6 @@ class ExportFormatter
             'book'         => $book,
             'bookChildren' => $bookTree,
             'format'       => 'html',
-            'cspContent'   => $this->cspService->getCspMetaTagValue(),
         ])->render();
 
         return $this->containHtml($html);
@@ -98,7 +92,6 @@ class ExportFormatter
         $html = view('pages.export', [
             'page'   => $page,
             'format' => 'pdf',
-            'engine' => $this->pdfGenerator->getActiveEngine(),
         ])->render();
 
         return $this->htmlToPdf($html);
@@ -120,7 +113,6 @@ class ExportFormatter
             'chapter' => $chapter,
             'pages'   => $pages,
             'format'  => 'pdf',
-            'engine'  => $this->pdfGenerator->getActiveEngine(),
         ])->render();
 
         return $this->htmlToPdf($html);
@@ -138,7 +130,6 @@ class ExportFormatter
             'book'         => $book,
             'bookChildren' => $bookTree,
             'format'       => 'pdf',
-            'engine'       => $this->pdfGenerator->getActiveEngine(),
         ])->render();
 
         return $this->htmlToPdf($html);
@@ -153,31 +144,10 @@ class ExportFormatter
     {
         $html = $this->containHtml($html);
         $html = $this->replaceIframesWithLinks($html);
-        $html = $this->openDetailElements($html);
 
         return $this->pdfGenerator->fromHtml($html);
     }
 
-    /**
-     * Within the given HTML content, Open any detail blocks.
-     */
-    protected function openDetailElements(string $html): string
-    {
-        libxml_use_internal_errors(true);
-
-        $doc = new DOMDocument();
-        $doc->loadHTML(mb_convert_encoding($html, 'HTML-ENTITIES', 'UTF-8'));
-        $xPath = new DOMXPath($doc);
-
-        $details = $xPath->query('//details');
-        /** @var DOMElement $detail */
-        foreach ($details as $detail) {
-            $detail->setAttribute('open', 'open');
-        }
-
-        return $doc->saveHTML();
-    }
-
     /**
      * Within the given HTML content, replace any iframe elements
      * with anchor links within paragraph blocks.
@@ -326,7 +296,7 @@ class ExportFormatter
             $text .= $this->pageToMarkdown($page) . "\n\n";
         }
 
-        return trim($text);
+        return $text;
     }
 
     /**
@@ -338,12 +308,12 @@ class ExportFormatter
         $text = '# ' . $book->name . "\n\n";
         foreach ($bookTree as $bookChild) {
             if ($bookChild instanceof Chapter) {
-                $text .= $this->chapterToMarkdown($bookChild) . "\n\n";
+                $text .= $this->chapterToMarkdown($bookChild);
             } else {
-                $text .= $this->pageToMarkdown($bookChild) . "\n\n";
+                $text .= $this->pageToMarkdown($bookChild);
             }
         }
 
-        return trim($text);
+        return $text;
     }
 }

app/Entities/Tools/Markdown/CheckboxConverter.php

@@ -1,28 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools\Markdown;
-
-use League\HTMLToMarkdown\Converter\ConverterInterface;
-use League\HTMLToMarkdown\ElementInterface;
-
-class CheckboxConverter implements ConverterInterface
-{
-    public function convert(ElementInterface $element): string
-    {
-        if (strtolower($element->getAttribute('type')) === 'checkbox') {
-            $isChecked = $element->getAttribute('checked') === 'checked';
-
-            return $isChecked ? ' [x] ' : ' [ ] ';
-        }
-
-        return $element->getValue();
-    }
-
-    /**
-     * @return string[]
-     */
-    public function getSupportedTags(): array
-    {
-        return ['input'];
-    }
-}

app/Entities/Tools/Markdown/CustomDivConverter.php

@@ -1,20 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools\Markdown;
-
-use League\HTMLToMarkdown\Converter\DivConverter;
-use League\HTMLToMarkdown\ElementInterface;
-
-class CustomDivConverter extends DivConverter
-{
-    public function convert(ElementInterface $element): string
-    {
-        // Clean up draw.io diagrams
-        $drawIoDiagram = $element->getAttribute('drawio-diagram');
-        if ($drawIoDiagram) {
-            return "<div drawio-diagram=\"{$drawIoDiagram}\">{$element->getValue()}</div>\n\n";
-        }
-
-        return parent::convert($element);
-    }
-}

app/Entities/Tools/Markdown/CustomImageConverter.php

@@ -1,25 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools\Markdown;
-
-use League\HTMLToMarkdown\Converter\ImageConverter;
-use League\HTMLToMarkdown\ElementInterface;
-
-class CustomImageConverter extends ImageConverter
-{
-    public function convert(ElementInterface $element): string
-    {
-        $parent = $element->getParent();
-
-        // Remain as HTML if within diagram block.
-        $withinDrawing = $parent && !empty($parent->getAttribute('drawio-diagram'));
-        if ($withinDrawing) {
-            $src = e($element->getAttribute('src'));
-            $alt = e($element->getAttribute('alt'));
-
-            return "<img src=\"{$src}\" alt=\"{$alt}\"/>";
-        }
-
-        return parent::convert($element);
-    }
-}

app/Entities/Tools/Markdown/CustomParagraphConverter.php

@@ -9,7 +9,7 @@ class CustomParagraphConverter extends ParagraphConverter
 {
     public function convert(ElementInterface $element): string
     {
-        $class = e($element->getAttribute('class'));
+        $class = $element->getAttribute('class');
         if (strpos($class, 'callout') !== false) {
             return "<{$element->getTagName()} class=\"{$class}\">{$element->getValue()}</{$element->getTagName()}>\n\n";
         }

app/Entities/Tools/Markdown/HtmlToMarkdown.php

@@ -5,10 +5,12 @@ namespace BookStack\Entities\Tools\Markdown;
 use League\HTMLToMarkdown\Converter\BlockquoteConverter;
 use League\HTMLToMarkdown\Converter\CodeConverter;
 use League\HTMLToMarkdown\Converter\CommentConverter;
+use League\HTMLToMarkdown\Converter\DivConverter;
 use League\HTMLToMarkdown\Converter\EmphasisConverter;
 use League\HTMLToMarkdown\Converter\HardBreakConverter;
 use League\HTMLToMarkdown\Converter\HeaderConverter;
 use League\HTMLToMarkdown\Converter\HorizontalRuleConverter;
+use League\HTMLToMarkdown\Converter\ImageConverter;
 use League\HTMLToMarkdown\Converter\LinkConverter;
 use League\HTMLToMarkdown\Converter\ListBlockConverter;
 use League\HTMLToMarkdown\Converter\ListItemConverter;
@@ -19,7 +21,7 @@ use League\HTMLToMarkdown\HtmlConverter;
 
 class HtmlToMarkdown
 {
-    protected string $html;
+    protected $html;
 
     public function __construct(string $html)
     {
@@ -73,20 +75,18 @@ class HtmlToMarkdown
         $environment->addConverter(new BlockquoteConverter());
         $environment->addConverter(new CodeConverter());
         $environment->addConverter(new CommentConverter());
-        $environment->addConverter(new CustomDivConverter());
+        $environment->addConverter(new DivConverter());
         $environment->addConverter(new EmphasisConverter());
         $environment->addConverter(new HardBreakConverter());
         $environment->addConverter(new HeaderConverter());
         $environment->addConverter(new HorizontalRuleConverter());
-        $environment->addConverter(new CustomImageConverter());
+        $environment->addConverter(new ImageConverter());
         $environment->addConverter(new LinkConverter());
         $environment->addConverter(new ListBlockConverter());
         $environment->addConverter(new ListItemConverter());
         $environment->addConverter(new CustomParagraphConverter());
         $environment->addConverter(new PreformattedConverter());
         $environment->addConverter(new TextConverter());
-        $environment->addConverter(new CheckboxConverter());
-        $environment->addConverter(new SpacedTagFallbackConverter());
 
         return $environment;
     }

app/Entities/Tools/Markdown/MarkdownToHtml.php

@@ -1,35 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools\Markdown;
-
-use BookStack\Facades\Theme;
-use BookStack\Theming\ThemeEvents;
-use League\CommonMark\Block\Element\ListItem;
-use League\CommonMark\CommonMarkConverter;
-use League\CommonMark\Environment;
-use League\CommonMark\Extension\Table\TableExtension;
-use League\CommonMark\Extension\TaskList\TaskListExtension;
-
-class MarkdownToHtml
-{
-    protected string $markdown;
-
-    public function __construct(string $markdown)
-    {
-        $this->markdown = $markdown;
-    }
-
-    public function convert(): string
-    {
-        $environment = Environment::createCommonMarkEnvironment();
-        $environment->addExtension(new TableExtension());
-        $environment->addExtension(new TaskListExtension());
-        $environment->addExtension(new CustomStrikeThroughExtension());
-        $environment = Theme::dispatch(ThemeEvents::COMMONMARK_ENVIRONMENT_CONFIGURE, $environment) ?? $environment;
-        $converter = new CommonMarkConverter([], $environment);
-
-        $environment->addBlockRenderer(ListItem::class, new CustomListItemRenderer(), 10);
-
-        return $converter->convertToHtml($this->markdown);
-    }
-}

app/Entities/Tools/Markdown/SpacedTagFallbackConverter.php

@@ -1,23 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools\Markdown;
-
-use League\HTMLToMarkdown\Converter\ConverterInterface;
-use League\HTMLToMarkdown\ElementInterface;
-
-/**
- * For certain defined tags, add additional spacing upon the retained HTML content
- * to separate it out from anything that may be markdown soon afterwards or within.
- */
-class SpacedTagFallbackConverter implements ConverterInterface
-{
-    public function convert(ElementInterface $element): string
-    {
-        return \html_entity_decode($element->getChildrenAsString()) . "\n\n";
-    }
-
-    public function getSupportedTags(): array
-    {
-        return ['summary', 'iframe'];
-    }
-}

app/Entities/Tools/PageContent.php

@@ -3,8 +3,11 @@
 namespace BookStack\Entities\Tools;
 
 use BookStack\Entities\Models\Page;
-use BookStack\Entities\Tools\Markdown\MarkdownToHtml;
+use BookStack\Entities\Tools\Markdown\CustomListItemRenderer;
+use BookStack\Entities\Tools\Markdown\CustomStrikeThroughExtension;
 use BookStack\Exceptions\ImageUploadException;
+use BookStack\Facades\Theme;
+use BookStack\Theming\ThemeEvents;
 use BookStack\Uploads\ImageRepo;
 use BookStack\Uploads\ImageService;
 use BookStack\Util\HtmlContentFilter;
@@ -14,10 +17,15 @@ use DOMNode;
 use DOMNodeList;
 use DOMXPath;
 use Illuminate\Support\Str;
+use League\CommonMark\Block\Element\ListItem;
+use League\CommonMark\CommonMarkConverter;
+use League\CommonMark\Environment;
+use League\CommonMark\Extension\Table\TableExtension;
+use League\CommonMark\Extension\TaskList\TaskListExtension;
 
 class PageContent
 {
-    protected Page $page;
+    protected $page;
 
     /**
      * PageContent constructor.
@@ -45,11 +53,28 @@ class PageContent
     {
         $markdown = $this->extractBase64ImagesFromMarkdown($markdown);
         $this->page->markdown = $markdown;
-        $html = (new MarkdownToHtml($markdown))->convert();
+        $html = $this->markdownToHtml($markdown);
         $this->page->html = $this->formatHtml($html);
         $this->page->text = $this->toPlainText();
     }
 
+    /**
+     * Convert the given Markdown content to a HTML string.
+     */
+    protected function markdownToHtml(string $markdown): string
+    {
+        $environment = Environment::createCommonMarkEnvironment();
+        $environment->addExtension(new TableExtension());
+        $environment->addExtension(new TaskListExtension());
+        $environment->addExtension(new CustomStrikeThroughExtension());
+        $environment = Theme::dispatch(ThemeEvents::COMMONMARK_ENVIRONMENT_CONFIGURE, $environment) ?? $environment;
+        $converter = new CommonMarkConverter([], $environment);
+
+        $environment->addBlockRenderer(ListItem::class, new CustomListItemRenderer(), 10);
+
+        return $converter->convertToHtml($markdown);
+    }
+
     /**
      * Convert all base64 image data to saved images.
      */
@@ -84,35 +109,15 @@ class PageContent
 
     /**
      * Convert all inline base64 content to uploaded image files.
-     * Regex is used to locate the start of data-uri definitions then
-     * manual looping over content is done to parse the whole data uri.
-     * Attempting to capture the whole data uri using regex can cause PHP
-     * PCRE limits to be hit with larger, multi-MB, files.
      */
     protected function extractBase64ImagesFromMarkdown(string $markdown)
     {
         $matches = [];
-        $contentLength = strlen($markdown);
-        $replacements = [];
-        preg_match_all('/!\[.*?]\(.*?(data:image\/.{1,6};base64,)/', $markdown, $matches, PREG_OFFSET_CAPTURE);
+        preg_match_all('/!\[.*?]\(.*?(data:image\/.*?)[)"\s]/', $markdown, $matches);
 
-        foreach ($matches[1] as $base64MatchPair) {
-            [$dataUri, $index] = $base64MatchPair;
-
-            for ($i = strlen($dataUri) + $index; $i < $contentLength; $i++) {
-                $char = $markdown[$i];
-                if ($char === ')' || $char === ' ' || $char === "\n" || $char === '"') {
-                    break;
-                }
-                $dataUri .= $char;
-            }
-
-            $newUrl = $this->base64ImageUriToUploadedImageUrl($dataUri);
-            $replacements[] = [$dataUri, $newUrl];
-        }
-
-        foreach ($replacements as [$dataUri, $newUrl]) {
-            $markdown = str_replace($dataUri, $newUrl, $markdown);
+        foreach ($matches[1] as $base64Match) {
+            $newUrl = $this->base64ImageUriToUploadedImageUrl($base64Match);
+            $markdown = str_replace($base64Match, $newUrl, $markdown);
         }
 
         return $markdown;
@@ -214,9 +219,6 @@ class PageContent
             $html .= $doc->saveHTML($childNode);
         }
 
-        // Perform required string-level tweaks
-        $html = str_replace(' ', '&nbsp;', $html);
-
         return $html;
     }
 

app/Entities/Tools/PageEditActivity.php

@@ -9,7 +9,7 @@ use Illuminate\Database\Eloquent\Builder;
 
 class PageEditActivity
 {
-    protected Page $page;
+    protected $page;
 
     /**
      * PageEditActivity constructor.

app/Entities/Tools/PageEditorData.php

@@ -1,115 +0,0 @@
-<?php
-
-namespace BookStack\Entities\Tools;
-
-use BookStack\Entities\Models\Page;
-use BookStack\Entities\Repos\PageRepo;
-use BookStack\Entities\Tools\Markdown\HtmlToMarkdown;
-use BookStack\Entities\Tools\Markdown\MarkdownToHtml;
-
-class PageEditorData
-{
-    protected Page $page;
-    protected PageRepo $pageRepo;
-    protected string $requestedEditor;
-
-    protected array $viewData;
-    protected array $warnings;
-
-    public function __construct(Page $page, PageRepo $pageRepo, string $requestedEditor)
-    {
-        $this->page = $page;
-        $this->pageRepo = $pageRepo;
-        $this->requestedEditor = $requestedEditor;
-
-        $this->viewData = $this->build();
-    }
-
-    public function getViewData(): array
-    {
-        return $this->viewData;
-    }
-
-    public function getWarnings(): array
-    {
-        return $this->warnings;
-    }
-
-    protected function build(): array
-    {
-        $page = clone $this->page;
-        $isDraft = boolval($this->page->draft);
-        $templates = $this->pageRepo->getTemplates(10);
-        $draftsEnabled = auth()->check();
-
-        $isDraftRevision = false;
-        $this->warnings = [];
-        $editActivity = new PageEditActivity($page);
-
-        if ($editActivity->hasActiveEditing()) {
-            $this->warnings[] = $editActivity->activeEditingMessage();
-        }
-
-        // Check for a current draft version for this user
-        $userDraft = $this->pageRepo->getUserDraft($page);
-        if ($userDraft !== null) {
-            $page->forceFill($userDraft->only(['name', 'html', 'markdown']));
-            $isDraftRevision = true;
-            $this->warnings[] = $editActivity->getEditingActiveDraftMessage($userDraft);
-        }
-
-        $editorType = $this->getEditorType($page);
-        $this->updateContentForEditor($page, $editorType);
-
-        return [
-            'page'            => $page,
-            'book'            => $page->book,
-            'isDraft'         => $isDraft,
-            'isDraftRevision' => $isDraftRevision,
-            'draftsEnabled'   => $draftsEnabled,
-            'templates'       => $templates,
-            'editor'          => $editorType,
-        ];
-    }
-
-    protected function updateContentForEditor(Page $page, string $editorType): void
-    {
-        $isHtml = !empty($page->html) && empty($page->markdown);
-
-        // HTML to markdown-clean conversion
-        if ($editorType === 'markdown' && $isHtml && $this->requestedEditor === 'markdown-clean') {
-            $page->markdown = (new HtmlToMarkdown($page->html))->convert();
-        }
-
-        // Markdown to HTML conversion if we don't have HTML
-        if ($editorType === 'wysiwyg' && !$isHtml) {
-            $page->html = (new MarkdownToHtml($page->markdown))->convert();
-        }
-    }
-
-    /**
-     * Get the type of editor to show for editing the given page.
-     * Defaults based upon the current content of the page otherwise will fall back
-     * to system default but will take a requested type (if provided) if permissions allow.
-     */
-    protected function getEditorType(Page $page): string
-    {
-        $editorType = $page->editor ?: self::getSystemDefaultEditor();
-
-        // Use requested editor if valid and if we have permission
-        $requestedType = explode('-', $this->requestedEditor)[0];
-        if (($requestedType === 'markdown' || $requestedType === 'wysiwyg') && userCan('editor-change')) {
-            $editorType = $requestedType;
-        }
-
-        return $editorType;
-    }
-
-    /**
-     * Get the configured system default editor.
-     */
-    public static function getSystemDefaultEditor(): string
-    {
-        return setting('app-editor') === 'markdown' ? 'markdown' : 'wysiwyg';
-    }
-}

app/Entities/Tools/PdfGenerator.php

@@ -7,15 +7,14 @@ use Barryvdh\Snappy\Facades\SnappyPdf;
 
 class PdfGenerator
 {
-    const ENGINE_DOMPDF = 'dompdf';
-    const ENGINE_WKHTML = 'wkhtml';
-
     /**
      * Generate PDF content from the given HTML content.
      */
     public function fromHtml(string $html): string
     {
-        if ($this->getActiveEngine() === self::ENGINE_WKHTML) {
+        $useWKHTML = config('snappy.pdf.binary') !== false && config('app.allow_untrusted_server_fetching') === true;
+
+        if ($useWKHTML) {
             $pdf = SnappyPDF::loadHTML($html);
             $pdf->setOption('print-media-type', true);
         } else {
@@ -24,15 +23,4 @@ class PdfGenerator
 
         return $pdf->output();
     }
-
-    /**
-     * Get the currently active PDF engine.
-     * Returns the value of an `ENGINE_` const on this class.
-     */
-    public function getActiveEngine(): string
-    {
-        $useWKHTML = config('snappy.pdf.binary') !== false && config('app.allow_untrusted_server_fetching') === true;
-
-        return $useWKHTML ? self::ENGINE_WKHTML : self::ENGINE_DOMPDF;
-    }
 }

app/Entities/Tools/SearchRunner.php

@@ -360,7 +360,7 @@ class SearchRunner
                     /** @var Connection $connection */
                     $connection = $query->getConnection();
                     $tagValue = (float) trim($connection->getPdo()->quote($tagValue), "'");
-                    $query->whereRaw("value {$tagOperator} {$tagValue}");
+                    $query->whereRaw("value ${tagOperator} ${tagValue}");
                 } else {
                     $query->where('value', $tagOperator, $tagValue);
                 }

app/Entities/Tools/TrashCan.php

@@ -22,12 +22,9 @@ class TrashCan
 {
     /**
      * Send a shelf to the recycle bin.
-     *
-     * @throws NotifyException
      */
     public function softDestroyShelf(Bookshelf $shelf)
     {
-        $this->ensureDeletable($shelf);
         Deletion::createForEntity($shelf);
         $shelf->delete();
     }
@@ -39,7 +36,6 @@ class TrashCan
      */
     public function softDestroyBook(Book $book)
     {
-        $this->ensureDeletable($book);
         Deletion::createForEntity($book);
 
         foreach ($book->pages as $page) {
@@ -61,7 +57,6 @@ class TrashCan
     public function softDestroyChapter(Chapter $chapter, bool $recordDelete = true)
     {
         if ($recordDelete) {
-            $this->ensureDeletable($chapter);
             Deletion::createForEntity($chapter);
         }
 
@@ -82,47 +77,19 @@ class TrashCan
     public function softDestroyPage(Page $page, bool $recordDelete = true)
     {
         if ($recordDelete) {
-            $this->ensureDeletable($page);
             Deletion::createForEntity($page);
         }
 
-        $page->delete();
-    }
-
-    /**
-     * Ensure the given entity is deletable.
-     * Is not for permissions, but logical conditions within the application.
-     * Will throw if not deletable.
-     *
-     * @throws NotifyException
-     */
-    protected function ensureDeletable(Entity $entity): void
-    {
-        $customHomeId = intval(explode(':', setting('app-homepage', '0:'))[0]);
-        $customHomeActive = setting('app-homepage-type') === 'page';
-        $removeCustomHome = false;
-
-        // Check custom homepage usage for pages
-        if ($entity instanceof Page && $entity->id === $customHomeId) {
-            if ($customHomeActive) {
-                throw new NotifyException(trans('errors.page_custom_home_deletion'), $entity->getUrl());
+        // Check if set as custom homepage & remove setting if not used or throw error if active
+        $customHome = setting('app-homepage', '0:');
+        if (intval($page->id) === intval(explode(':', $customHome)[0])) {
+            if (setting('app-homepage-type') === 'page') {
+                throw new NotifyException(trans('errors.page_custom_home_deletion'), $page->getUrl());
             }
-            $removeCustomHome = true;
-        }
-
-        // Check custom homepage usage within chapters or books
-        if ($entity instanceof Chapter || $entity instanceof Book) {
-            if ($entity->pages()->where('id', '=', $customHomeId)->exists()) {
-                if ($customHomeActive) {
-                    throw new NotifyException(trans('errors.page_custom_home_deletion'), $entity->getUrl());
-                }
-                $removeCustomHome = true;
-            }
-        }
-
-        if ($removeCustomHome) {
             setting()->remove('app-homepage');
         }
+
+        $page->delete();
     }
 
     /**

app/Exceptions/Handler.php

@@ -101,10 +101,6 @@ class Handler extends ExceptionHandler
             $code = $e->status;
         }
 
-        if (method_exists($e, 'getStatus')) {
-            $code = $e->getStatus();
-        }
-
         $responseData['error']['code'] = $code;
 
         return new JsonResponse($responseData, $code, $headers);

app/Exceptions/JsonDebugException.php

@@ -3,29 +3,24 @@
 namespace BookStack\Exceptions;
 
 use Exception;
-use Illuminate\Http\JsonResponse;
 
 class JsonDebugException extends Exception
 {
-    protected array $data;
+    protected $data;
 
     /**
      * JsonDebugException constructor.
      */
-    public function __construct(array $data)
+    public function __construct($data)
     {
         $this->data = $data;
-        parent::__construct();
     }
 
     /**
-     * Convert this exception into a response.
-     * We add a manual data conversion to UTF8 to ensure any binary data is presentable as a JSON string.
+     * Covert this exception into a response.
      */
-    public function render(): JsonResponse
+    public function render()
     {
-        $cleaned = mb_convert_encoding($this->data, 'UTF-8');
-
-        return response()->json($cleaned);
+        return response()->json($this->data);
     }
 }

app/Exceptions/NotifyException.php

@@ -9,24 +9,17 @@ class NotifyException extends Exception implements Responsable
 {
     public $message;
     public $redirectLocation;
-    protected $status;
 
-    public function __construct(string $message, string $redirectLocation = '/', int $status = 500)
+    /**
+     * NotifyException constructor.
+     */
+    public function __construct(string $message, string $redirectLocation = '/')
     {
         $this->message = $message;
         $this->redirectLocation = $redirectLocation;
-        $this->status = $status;
         parent::__construct();
     }
 
-    /**
-     * Get the desired status code for this exception.
-     */
-    public function getStatus(): int
-    {
-        return $this->status;
-    }
-
     /**
      * Send the response for this type of exception.
      *
@@ -36,11 +29,6 @@ class NotifyException extends Exception implements Responsable
     {
         $message = $this->getMessage();
 
-        // Front-end JSON handling. API-side handling managed via handler.
-        if ($request->wantsJson()) {
-            return response()->json(['error' => $message], 403);
-        }
-
         if (!empty($message)) {
             session()->flash('error', $message);
         }

app/Exceptions/OpenIdConnectException.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace BookStack\Exceptions;
+
+class OpenIdConnectException extends NotifyException
+{
+}

app/Http/Controllers/Api/ApiController.php

@@ -15,14 +15,10 @@ abstract class ApiController extends Controller
      * Provide a paginated listing JSON response in a standard format
      * taking into account any pagination parameters passed by the user.
      */
-    protected function apiListingResponse(Builder $query, array $fields, array $modifiers = []): JsonResponse
+    protected function apiListingResponse(Builder $query, array $fields): JsonResponse
     {
         $listing = new ListingResponseBuilder($query, request(), $fields);
 
-        foreach ($modifiers as $modifier) {
-            $listing->modifyResults($modifier);
-        }
-
         return $listing->toResponse();
     }
 
@@ -30,7 +26,7 @@ abstract class ApiController extends Controller
      * Get the validation rules for this controller.
      * Defaults to a $rules property but can be a rules() method.
      */
-    public function getValidationRules(): array
+    public function getValdationRules(): array
     {
         if (method_exists($this, 'rules')) {
             return $this->rules();

app/Http/Controllers/Api/AttachmentApiController.php

@@ -87,33 +87,14 @@ class AttachmentApiController extends ApiController
             'markdown' => $attachment->markdownLink(),
         ]);
 
-        // Simply return a JSON response of the attachment for link-based attachments
-        if ($attachment->external) {
+        if (!$attachment->external) {
+            $attachmentContents = $this->attachmentService->getAttachmentFromStorage($attachment);
+            $attachment->setAttribute('content', base64_encode($attachmentContents));
+        } else {
             $attachment->setAttribute('content', $attachment->path);
-
-            return response()->json($attachment);
         }
 
-        // Build and split our core JSON, at point of content.
-        $splitter = 'CONTENT_SPLIT_LOCATION_' . time() . '_' . rand(1, 40000);
-        $attachment->setAttribute('content', $splitter);
-        $json = $attachment->toJson();
-        $jsonParts = explode($splitter, $json);
-        // Get a stream for the file data from storage
-        $stream = $this->attachmentService->streamAttachmentFromStorage($attachment);
-
-        return response()->stream(function () use ($jsonParts, $stream) {
-            // Output the pre-content JSON data
-            echo $jsonParts[0];
-
-            // Stream out our attachment data as base64 content
-            stream_filter_append($stream, 'convert.base64-encode', STREAM_FILTER_READ);
-            fpassthru($stream);
-            fclose($stream);
-
-            // Output our post-content JSON data
-            echo $jsonParts[1];
-        }, 200, ['Content-Type' => 'application/json']);
+        return response()->json($attachment);
     }
 
     /**

app/Http/Controllers/Api/BookshelfApiController.php

@@ -11,20 +11,21 @@ use Illuminate\Validation\ValidationException;
 
 class BookshelfApiController extends ApiController
 {
-    protected BookshelfRepo $bookshelfRepo;
+    /**
+     * @var BookshelfRepo
+     */
+    protected $bookshelfRepo;
 
     protected $rules = [
         'create' => [
             'name'        => ['required', 'string', 'max:255'],
             'description' => ['string', 'max:1000'],
             'books'       => ['array'],
-            'tags'        => ['array'],
         ],
         'update' => [
             'name'        => ['string', 'min:1', 'max:255'],
             'description' => ['string', 'max:1000'],
             'books'       => ['array'],
-            'tags'        => ['array'],
         ],
     ];
 

app/Http/Controllers/Api/PageApiController.php

@@ -12,7 +12,7 @@ use Illuminate\Http\Request;
 
 class PageApiController extends ApiController
 {
-    protected PageRepo $pageRepo;
+    protected $pageRepo;
 
     protected $rules = [
         'create' => [
@@ -24,8 +24,8 @@ class PageApiController extends ApiController
             'tags'       => ['array'],
         ],
         'update' => [
-            'book_id'    => ['integer'],
-            'chapter_id' => ['integer'],
+            'book_id'    => ['required', 'integer'],
+            'chapter_id' => ['required', 'integer'],
             'name'       => ['string', 'min:1', 'max:255'],
             'html'       => ['string'],
             'markdown'   => ['string'],
@@ -103,8 +103,6 @@ class PageApiController extends ApiController
      */
     public function update(Request $request, string $id)
     {
-        $requestData = $this->validate($request, $this->rules['update']);
-
         $page = $this->pageRepo->getById($id, []);
         $this->checkOwnablePermission('page-update', $page);
 
@@ -129,7 +127,7 @@ class PageApiController extends ApiController
             }
         }
 
-        $updatedPage = $this->pageRepo->update($page, $requestData);
+        $updatedPage = $this->pageRepo->update($page, $request->all());
 
         return response()->json($updatedPage->forJsonDisplay());
     }

app/Http/Controllers/Api/RecycleBinApiController.php

@@ -1,90 +0,0 @@
-<?php
-
-namespace BookStack\Http\Controllers\Api;
-
-use BookStack\Entities\Models\Book;
-use BookStack\Entities\Models\BookChild;
-use BookStack\Entities\Models\Chapter;
-use BookStack\Entities\Models\Deletion;
-use BookStack\Entities\Repos\DeletionRepo;
-use Closure;
-use Illuminate\Database\Eloquent\Builder;
-
-class RecycleBinApiController extends ApiController
-{
-    public function __construct()
-    {
-        $this->middleware(function ($request, $next) {
-            $this->checkPermission('settings-manage');
-            $this->checkPermission('restrictions-manage-all');
-
-            return $next($request);
-        });
-    }
-
-    /**
-     * Get a top-level listing of the items in the recycle bin.
-     * The "deletable" property will reflect the main item deleted.
-     * For books and chapters, counts of child pages/chapters will
-     * be loaded within this "deletable" data.
-     * For chapters & pages, the parent item will be loaded within this "deletable" data.
-     * Requires permission to manage both system settings and permissions.
-     */
-    public function list()
-    {
-        return $this->apiListingResponse(Deletion::query()->with('deletable'), [
-            'id',
-            'deleted_by',
-            'created_at',
-            'updated_at',
-            'deletable_type',
-            'deletable_id',
-        ], [Closure::fromCallable([$this, 'listFormatter'])]);
-    }
-
-    /**
-     * Restore a single deletion from the recycle bin.
-     * Requires permission to manage both system settings and permissions.
-     */
-    public function restore(DeletionRepo $deletionRepo, string $deletionId)
-    {
-        $restoreCount = $deletionRepo->restore(intval($deletionId));
-
-        return response()->json(['restore_count' => $restoreCount]);
-    }
-
-    /**
-     * Remove a single deletion from the recycle bin.
-     * Use this endpoint carefully as it will entirely remove the underlying deleted items from the system.
-     * Requires permission to manage both system settings and permissions.
-     */
-    public function destroy(DeletionRepo $deletionRepo, string $deletionId)
-    {
-        $deleteCount = $deletionRepo->destroy(intval($deletionId));
-
-        return response()->json(['delete_count' => $deleteCount]);
-    }
-
-    /**
-     * Load some related details for the deletion listing.
-     */
-    protected function listFormatter(Deletion $deletion)
-    {
-        $deletable = $deletion->deletable;
-        $withTrashedQuery = fn (Builder $query) => $query->withTrashed();
-
-        if ($deletable instanceof BookChild) {
-            $parent = $deletable->getParent();
-            $parent->setAttribute('type', $parent->getType());
-            $deletable->setRelation('parent', $parent);
-        }
-
-        if ($deletable instanceof Book || $deletable instanceof Chapter) {
-            $countsToLoad = ['pages' => $withTrashedQuery];
-            if ($deletable instanceof Book) {
-                $countsToLoad['chapters'] = $withTrashedQuery;
-            }
-            $deletable->loadCount($countsToLoad);
-        }
-    }
-}

app/Http/Controllers/Api/UserApiController.php

@@ -1,168 +0,0 @@
-<?php
-
-namespace BookStack\Http\Controllers\Api;
-
-use BookStack\Auth\User;
-use BookStack\Auth\UserRepo;
-use BookStack\Exceptions\UserUpdateException;
-use Closure;
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Validation\Rules\Password;
-use Illuminate\Validation\Rules\Unique;
-
-class UserApiController extends ApiController
-{
-    protected $userRepo;
-
-    protected $fieldsToExpose = [
-        'email', 'created_at', 'updated_at', 'last_activity_at', 'external_auth_id',
-    ];
-
-    public function __construct(UserRepo $userRepo)
-    {
-        $this->userRepo = $userRepo;
-
-        // Checks for all endpoints in this controller
-        $this->middleware(function ($request, $next) {
-            $this->checkPermission('users-manage');
-            $this->preventAccessInDemoMode();
-
-            return $next($request);
-        });
-    }
-
-    protected function rules(int $userId = null): array
-    {
-        return [
-            'create' => [
-                'name'  => ['required', 'min:2'],
-                'email' => [
-                    'required', 'min:2', 'email', new Unique('users', 'email'),
-                ],
-                'external_auth_id' => ['string'],
-                'language'         => ['string'],
-                'password'         => [Password::default()],
-                'roles'            => ['array'],
-                'roles.*'          => ['integer'],
-                'send_invite'      => ['boolean'],
-            ],
-            'update' => [
-                'name'  => ['min:2'],
-                'email' => [
-                    'min:2',
-                    'email',
-                    (new Unique('users', 'email'))->ignore($userId ?? null),
-                ],
-                'external_auth_id' => ['string'],
-                'language'         => ['string'],
-                'password'         => [Password::default()],
-                'roles'            => ['array'],
-                'roles.*'          => ['integer'],
-            ],
-            'delete' => [
-                'migrate_ownership_id' => ['integer', 'exists:users,id'],
-            ],
-        ];
-    }
-
-    /**
-     * Get a listing of users in the system.
-     * Requires permission to manage users.
-     */
-    public function list()
-    {
-        $users = User::query()->select(['*'])
-            ->scopes('withLastActivityAt')
-            ->with(['avatar']);
-
-        return $this->apiListingResponse($users, [
-            'id', 'name', 'slug', 'email', 'external_auth_id',
-            'created_at', 'updated_at', 'last_activity_at',
-        ], [Closure::fromCallable([$this, 'listFormatter'])]);
-    }
-
-    /**
-     * Create a new user in the system.
-     * Requires permission to manage users.
-     */
-    public function create(Request $request)
-    {
-        $data = $this->validate($request, $this->rules()['create']);
-        $sendInvite = ($data['send_invite'] ?? false) === true;
-
-        $user = null;
-        DB::transaction(function () use ($data, $sendInvite, &$user) {
-            $user = $this->userRepo->create($data, $sendInvite);
-        });
-
-        $this->singleFormatter($user);
-
-        return response()->json($user);
-    }
-
-    /**
-     * View the details of a single user.
-     * Requires permission to manage users.
-     */
-    public function read(string $id)
-    {
-        $user = $this->userRepo->getById($id);
-        $this->singleFormatter($user);
-
-        return response()->json($user);
-    }
-
-    /**
-     * Update an existing user in the system.
-     * Requires permission to manage users.
-     *
-     * @throws UserUpdateException
-     */
-    public function update(Request $request, string $id)
-    {
-        $data = $this->validate($request, $this->rules($id)['update']);
-        $user = $this->userRepo->getById($id);
-        $this->userRepo->update($user, $data, userCan('users-manage'));
-        $this->singleFormatter($user);
-
-        return response()->json($user);
-    }
-
-    /**
-     * Delete a user from the system.
-     * Can optionally accept a user id via `migrate_ownership_id` to indicate
-     * who should be the new owner of their related content.
-     * Requires permission to manage users.
-     */
-    public function delete(Request $request, string $id)
-    {
-        $user = $this->userRepo->getById($id);
-        $newOwnerId = $request->get('migrate_ownership_id', null);
-
-        $this->userRepo->destroy($user, $newOwnerId);
-
-        return response('', 204);
-    }
-
-    /**
-     * Format the given user model for single-result display.
-     */
-    protected function singleFormatter(User $user)
-    {
-        $this->listFormatter($user);
-        $user->load('roles:id,display_name');
-        $user->makeVisible(['roles']);
-    }
-
-    /**
-     * Format the given user model for a listing multi-result display.
-     */
-    protected function listFormatter(User $user)
-    {
-        $user->makeVisible($this->fieldsToExpose);
-        $user->setAttribute('profile_url', $user->getProfileUrl());
-        $user->setAttribute('edit_url', $user->getEditUrl());
-        $user->setAttribute('avatar_url', $user->getAvatar());
-    }
-}

app/Http/Controllers/AttachmentController.php

@@ -15,8 +15,8 @@ use Illuminate\Validation\ValidationException;
 
 class AttachmentController extends Controller
 {
-    protected AttachmentService $attachmentService;
-    protected PageRepo $pageRepo;
+    protected $attachmentService;
+    protected $pageRepo;
 
     /**
      * AttachmentController constructor.
@@ -230,13 +230,13 @@ class AttachmentController extends Controller
         }
 
         $fileName = $attachment->getFileName();
-        $attachmentStream = $this->attachmentService->streamAttachmentFromStorage($attachment);
+        $attachmentContents = $this->attachmentService->getAttachmentFromStorage($attachment);
 
         if ($request->get('open') === 'true') {
-            return $this->streamedInlineDownloadResponse($attachmentStream, $fileName);
+            return $this->inlineDownloadResponse($attachmentContents, $fileName);
         }
 
-        return $this->streamedDownloadResponse($attachmentStream, $fileName);
+        return $this->downloadResponse($attachmentContents, $fileName);
     }
 
     /**

app/Http/Controllers/Auth/OidcController.php

@@ -2,14 +2,13 @@
 
 namespace BookStack\Http\Controllers\Auth;
 
-use BookStack\Auth\Access\Oidc\OidcException;
 use BookStack\Auth\Access\Oidc\OidcService;
 use BookStack\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 
 class OidcController extends Controller
 {
-    protected OidcService $oidcService;
+    protected $oidcService;
 
     /**
      * OpenIdController constructor.
@@ -25,14 +24,7 @@ class OidcController extends Controller
      */
     public function login()
     {
-        try {
-            $loginDetails = $this->oidcService->login();
-        } catch (OidcException $exception) {
-            $this->showErrorNotification($exception->getMessage());
-
-            return redirect('/login');
-        }
-
+        $loginDetails = $this->oidcService->login();
         session()->flash('oidc_state', $loginDetails['state']);
 
         return redirect($loginDetails['url']);
@@ -53,13 +45,7 @@ class OidcController extends Controller
             return redirect('/login');
         }
 
-        try {
-            $this->oidcService->processAuthorizeResponse($request->query('code'));
-        } catch (OidcException $oidcException) {
-            $this->showErrorNotification($oidcException->getMessage());
-
-            return redirect('/login');
-        }
+        $this->oidcService->processAuthorizeResponse($request->query('code'));
 
         return redirect()->intended();
     }

app/Http/Controllers/Controller.php

@@ -2,17 +2,16 @@
 
 namespace BookStack\Http\Controllers;
 
-use BookStack\Exceptions\NotifyException;
 use BookStack\Facades\Activity;
 use BookStack\Interfaces\Loggable;
 use BookStack\Model;
 use BookStack\Util\WebSafeMimeSniffer;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Http\Exceptions\HttpResponseException;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Response;
 use Illuminate\Routing\Controller as BaseController;
-use Symfony\Component\HttpFoundation\StreamedResponse;
 
 abstract class Controller extends BaseController
 {
@@ -54,9 +53,14 @@ abstract class Controller extends BaseController
      */
     protected function showPermissionError()
     {
-        $message = request()->wantsJson() ? trans('errors.permissionJson') : trans('errors.permission');
+        if (request()->wantsJson()) {
+            $response = response()->json(['error' => trans('errors.permissionJson')], 403);
+        } else {
+            $response = redirect('/');
+            $this->showErrorNotification(trans('errors.permission'));
+        }
 
-        throw new NotifyException($message, '/', 403);
+        throw new HttpResponseException($response);
     }
 
     /**
@@ -116,30 +120,7 @@ abstract class Controller extends BaseController
     {
         return response()->make($content, 200, [
             'Content-Type'           => 'application/octet-stream',
-            'Content-Disposition'    => 'attachment; filename="' . str_replace('"', '', $fileName) . '"',
-            'X-Content-Type-Options' => 'nosniff',
-        ]);
-    }
-
-    /**
-     * Create a response that forces a download, from a given stream of content.
-     */
-    protected function streamedDownloadResponse($stream, string $fileName): StreamedResponse
-    {
-        return response()->stream(function () use ($stream) {
-
-            // End & flush the output buffer, if we're in one, otherwise we still use memory.
-            // Output buffer may or may not exist depending on PHP `output_buffering` setting.
-            // Ignore in testing since output buffers are used to gather a response.
-            if (!empty(ob_get_status()) && !app()->runningUnitTests()) {
-                ob_end_clean();
-            }
-
-            fpassthru($stream);
-            fclose($stream);
-        }, 200, [
-            'Content-Type'           => 'application/octet-stream',
-            'Content-Disposition'    => 'attachment; filename="' . str_replace('"', '', $fileName) . '"',
+            'Content-Disposition'    => 'attachment; filename="' . $fileName . '"',
             'X-Content-Type-Options' => 'nosniff',
         ]);
     }
@@ -154,28 +135,7 @@ abstract class Controller extends BaseController
 
         return response()->make($content, 200, [
             'Content-Type'           => $mime,
-            'Content-Disposition'    => 'inline; filename="' . str_replace('"', '', $fileName) . '"',
-            'X-Content-Type-Options' => 'nosniff',
-        ]);
-    }
-
-    /**
-     * Create a file download response that provides the file with a content-type
-     * correct for the file, in a way so the browser can show the content in browser,
-     * for a given content stream.
-     */
-    protected function streamedInlineDownloadResponse($stream, string $fileName): StreamedResponse
-    {
-        $sniffContent = fread($stream, 1000);
-        $mime = (new WebSafeMimeSniffer())->sniff($sniffContent);
-
-        return response()->stream(function () use ($sniffContent, $stream) {
-            echo $sniffContent;
-            fpassthru($stream);
-            fclose($stream);
-        }, 200, [
-            'Content-Type'           => $mime,
-            'Content-Disposition'    => 'inline; filename="' . str_replace('"', '', $fileName) . '"',
+            'Content-Disposition'    => 'inline; filename="' . $fileName . '"',
             'X-Content-Type-Options' => 'nosniff',
         ]);
     }

app/Http/Controllers/HomeController.php

@@ -107,6 +107,14 @@ class HomeController extends Controller
         return view('home.default', $commonData);
     }
 
+    /**
+     * Get custom head HTML, Used in ajax calls to show in editor.
+     */
+    public function customHeadContent()
+    {
+        return view('common.custom-head');
+    }
+
     /**
      * Show the view for /robots.txt.
      */

app/Http/Controllers/PageController.php

@@ -10,19 +10,17 @@ use BookStack\Entities\Tools\Cloner;
 use BookStack\Entities\Tools\NextPreviousContentLocator;
 use BookStack\Entities\Tools\PageContent;
 use BookStack\Entities\Tools\PageEditActivity;
-use BookStack\Entities\Tools\PageEditorData;
 use BookStack\Entities\Tools\PermissionsUpdater;
 use BookStack\Exceptions\NotFoundException;
 use BookStack\Exceptions\PermissionsException;
 use Exception;
-use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Http\Request;
 use Illuminate\Validation\ValidationException;
 use Throwable;
 
 class PageController extends Controller
 {
-    protected PageRepo $pageRepo;
+    protected $pageRepo;
 
     /**
      * PageController constructor.
@@ -83,15 +81,22 @@ class PageController extends Controller
      *
      * @throws NotFoundException
      */
-    public function editDraft(Request $request, string $bookSlug, int $pageId)
+    public function editDraft(string $bookSlug, int $pageId)
     {
         $draft = $this->pageRepo->getById($pageId);
         $this->checkOwnablePermission('page-create', $draft->getParent());
-
-        $editorData = new PageEditorData($draft, $this->pageRepo, $request->query('editor', ''));
         $this->setPageTitle(trans('entities.pages_edit_draft'));
 
-        return view('pages.edit', $editorData->getViewData());
+        $draftsEnabled = $this->isSignedIn();
+        $templates = $this->pageRepo->getTemplates(10);
+
+        return view('pages.edit', [
+            'page'          => $draft,
+            'book'          => $draft->book,
+            'isDraft'       => true,
+            'draftsEnabled' => $draftsEnabled,
+            'templates'     => $templates,
+        ]);
     }
 
     /**
@@ -182,19 +187,43 @@ class PageController extends Controller
      *
      * @throws NotFoundException
      */
-    public function edit(Request $request, string $bookSlug, string $pageSlug)
+    public function edit(string $bookSlug, string $pageSlug)
     {
         $page = $this->pageRepo->getBySlug($bookSlug, $pageSlug);
         $this->checkOwnablePermission('page-update', $page);
 
-        $editorData = new PageEditorData($page, $this->pageRepo, $request->query('editor', ''));
-        if ($editorData->getWarnings()) {
-            $this->showWarningNotification(implode("\n", $editorData->getWarnings()));
+        $page->isDraft = false;
+        $editActivity = new PageEditActivity($page);
+
+        // Check for active editing
+        $warnings = [];
+        if ($editActivity->hasActiveEditing()) {
+            $warnings[] = $editActivity->activeEditingMessage();
         }
 
+        // Check for a current draft version for this user
+        $userDraft = $this->pageRepo->getUserDraft($page);
+        if ($userDraft !== null) {
+            $page->forceFill($userDraft->only(['name', 'html', 'markdown']));
+            $page->isDraft = true;
+            $warnings[] = $editActivity->getEditingActiveDraftMessage($userDraft);
+        }
+
+        if (count($warnings) > 0) {
+            $this->showWarningNotification(implode("\n", $warnings));
+        }
+
+        $templates = $this->pageRepo->getTemplates(10);
+        $draftsEnabled = $this->isSignedIn();
         $this->setPageTitle(trans('entities.pages_editing_named', ['pageName' => $page->getShortName()]));
 
-        return view('pages.edit', $editorData->getViewData());
+        return view('pages.edit', [
+            'page'          => $page,
+            'book'          => $page->book,
+            'current'       => $page,
+            'draftsEnabled' => $draftsEnabled,
+            'templates'     => $templates,
+        ]);
     }
 
     /**
@@ -335,22 +364,15 @@ class PageController extends Controller
      */
     public function showRecentlyUpdated()
     {
-        $visibleBelongsScope = function (BelongsTo $query) {
-            $query->scopes('visible');
-        };
-
-        $pages = Page::visible()->with(['updatedBy', 'book' => $visibleBelongsScope, 'chapter' => $visibleBelongsScope])
-            ->orderBy('updated_at', 'desc')
+        $pages = Page::visible()->orderBy('updated_at', 'desc')
             ->paginate(20)
             ->setPath(url('/pages/recently-updated'));
 
         $this->setPageTitle(trans('entities.recently_updated_pages'));
 
         return view('common.detailed-listing-paginated', [
-            'title'         => trans('entities.recently_updated_pages'),
-            'entities'      => $pages,
-            'showUpdatedBy' => true,
-            'showPath'      => true,
+            'title'    => trans('entities.recently_updated_pages'),
+            'entities' => $pages,
         ]);
     }
 

app/Http/Controllers/PageRevisionController.php

@@ -124,8 +124,11 @@ class PageRevisionController extends Controller
             throw new NotFoundException("Revision #{$revId} not found");
         }
 
-        // Check if it's the latest revision, cannot delete the latest revision.
-        if (intval($page->currentRevision->id ?? null) === intval($revId)) {
+        // Get the current revision for the page
+        $currentRevision = $page->getCurrentRevision();
+
+        // Check if its the latest revision, cannot delete latest revision.
+        if (intval($currentRevision->id) === intval($revId)) {
             $this->showErrorNotification(trans('entities.revision_cannot_delete_latest'));
 
             return redirect($page->getUrl('/revisions'));

app/Http/Controllers/RecycleBinController.php

@@ -5,7 +5,6 @@ namespace BookStack\Http\Controllers;
 use BookStack\Actions\ActivityType;
 use BookStack\Entities\Models\Deletion;
 use BookStack\Entities\Models\Entity;
-use BookStack\Entities\Repos\DeletionRepo;
 use BookStack\Entities\Tools\TrashCan;
 
 class RecycleBinController extends Controller
@@ -74,9 +73,12 @@ class RecycleBinController extends Controller
      *
      * @throws \Exception
      */
-    public function restore(DeletionRepo $deletionRepo, string $id)
+    public function restore(string $id)
     {
-        $restoreCount = $deletionRepo->restore((int) $id);
+        /** @var Deletion $deletion */
+        $deletion = Deletion::query()->findOrFail($id);
+        $this->logActivity(ActivityType::RECYCLE_BIN_RESTORE, $deletion);
+        $restoreCount = (new TrashCan())->restoreFromDeletion($deletion);
 
         $this->showSuccessNotification(trans('settings.recycle_bin_restore_notification', ['count' => $restoreCount]));
 
@@ -101,9 +103,12 @@ class RecycleBinController extends Controller
      *
      * @throws \Exception
      */
-    public function destroy(DeletionRepo $deletionRepo, string $id)
+    public function destroy(string $id)
     {
-        $deleteCount = $deletionRepo->destroy((int) $id);
+        /** @var Deletion $deletion */
+        $deletion = Deletion::query()->findOrFail($id);
+        $this->logActivity(ActivityType::RECYCLE_BIN_DESTROY, $deletion);
+        $deleteCount = (new TrashCan())->destroyFromDeletion($deletion);
 
         $this->showSuccessNotification(trans('settings.recycle_bin_destroy_notification', ['count' => $deleteCount]));
 

app/Http/Controllers/SettingController.php

@@ -9,37 +9,28 @@ use Illuminate\Http\Request;
 
 class SettingController extends Controller
 {
-    protected ImageRepo $imageRepo;
-
-    protected array $settingCategories = ['features', 'customization', 'registration'];
+    protected $imageRepo;
 
+    /**
+     * SettingController constructor.
+     */
     public function __construct(ImageRepo $imageRepo)
     {
         $this->imageRepo = $imageRepo;
     }
 
     /**
-     * Handle requests to the settings index path.
+     * Display a listing of the settings.
      */
     public function index()
     {
-        return redirect('/settings/features');
-    }
-
-    /**
-     * Display the settings for the given category.
-     */
-    public function category(string $category)
-    {
-        $this->ensureCategoryExists($category);
         $this->checkPermission('settings-manage');
         $this->setPageTitle(trans('settings.settings'));
 
         // Get application version
         $version = trim(file_get_contents(base_path('version')));
 
-        return view('settings.' . $category, [
-            'category'  => $category,
+        return view('settings.index', [
             'version'   => $version,
             'guestUser' => User::getDefault(),
         ]);
@@ -48,9 +39,8 @@ class SettingController extends Controller
     /**
      * Update the specified settings in storage.
      */
-    public function update(Request $request, string $category)
+    public function update(Request $request)
     {
-        $this->ensureCategoryExists($category);
         $this->preventAccessInDemoMode();
         $this->checkPermission('settings-manage');
         $this->validate($request, [
@@ -67,7 +57,7 @@ class SettingController extends Controller
         }
 
         // Update logo image if set
-        if ($category === 'customization' && $request->hasFile('app_logo')) {
+        if ($request->hasFile('app_logo')) {
             $logoFile = $request->file('app_logo');
             $this->imageRepo->destroyByType('system');
             $image = $this->imageRepo->saveNew($logoFile, 'system', 0, null, 86);
@@ -75,21 +65,16 @@ class SettingController extends Controller
         }
 
         // Clear logo image if requested
-        if ($category === 'customization' && $request->get('app_logo_reset', null)) {
+        if ($request->get('app_logo_reset', null)) {
             $this->imageRepo->destroyByType('system');
             setting()->remove('app-logo');
         }
 
-        $this->logActivity(ActivityType::SETTINGS_UPDATE, $category);
+        $section = $request->get('section', '');
+        $this->logActivity(ActivityType::SETTINGS_UPDATE, $section);
         $this->showSuccessNotification(trans('settings.settings_save_success'));
+        $redirectLocation = '/settings#' . $section;
 
-        return redirect("/settings/{$category}");
-    }
-
-    protected function ensureCategoryExists(string $category): void
-    {
-        if (!in_array($category, $this->settingCategories)) {
-            abort(404);
-        }
+        return redirect(rtrim($redirectLocation, '#'));
     }
 }

app/Http/Controllers/UserController.php

@@ -2,9 +2,9 @@
 
 namespace BookStack\Http\Controllers;
 
+use BookStack\Actions\ActivityType;
 use BookStack\Auth\Access\SocialAuthService;
-use BookStack\Auth\Queries\AllUsersPaginatedAndSorted;
-use BookStack\Auth\Role;
+use BookStack\Auth\Access\UserInviteService;
 use BookStack\Auth\User;
 use BookStack\Auth\UserRepo;
 use BookStack\Exceptions\ImageUploadException;
@@ -12,21 +12,25 @@ use BookStack\Exceptions\UserUpdateException;
 use BookStack\Uploads\ImageRepo;
 use Exception;
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Str;
 use Illuminate\Validation\Rules\Password;
 use Illuminate\Validation\ValidationException;
 
 class UserController extends Controller
 {
+    protected $user;
     protected $userRepo;
+    protected $inviteService;
     protected $imageRepo;
 
     /**
      * UserController constructor.
      */
-    public function __construct(UserRepo $userRepo, ImageRepo $imageRepo)
+    public function __construct(User $user, UserRepo $userRepo, UserInviteService $inviteService, ImageRepo $imageRepo)
     {
+        $this->user = $user;
         $this->userRepo = $userRepo;
+        $this->inviteService = $inviteService;
         $this->imageRepo = $imageRepo;
     }
 
@@ -41,16 +45,12 @@ class UserController extends Controller
             'search' => $request->get('search', ''),
             'sort'   => $request->get('sort', 'name'),
         ];
-
-        $users = (new AllUsersPaginatedAndSorted())->run(20, $listDetails);
+        $users = $this->userRepo->getAllUsersPaginatedAndSorted(20, $listDetails);
 
         $this->setPageTitle(trans('settings.users'));
         $users->appends($listDetails);
 
-        return view('users.index', [
-            'users'       => $users,
-            'listDetails' => $listDetails,
-        ]);
+        return view('users.index', ['users' => $users, 'listDetails' => $listDetails]);
     }
 
     /**
@@ -60,42 +60,59 @@ class UserController extends Controller
     {
         $this->checkPermission('users-manage');
         $authMethod = config('auth.method');
-        $roles = Role::query()->orderBy('display_name', 'asc')->get();
-        $this->setPageTitle(trans('settings.users_add_new'));
+        $roles = $this->userRepo->getAllRoles();
 
         return view('users.create', ['authMethod' => $authMethod, 'roles' => $roles]);
     }
 
     /**
-     * Store a new user in storage.
+     * Store a newly created user in storage.
      *
+     * @throws UserUpdateException
      * @throws ValidationException
      */
     public function store(Request $request)
     {
         $this->checkPermission('users-manage');
+        $validationRules = [
+            'name'  => ['required'],
+            'email' => ['required', 'email', 'unique:users,email'],
+        ];
 
         $authMethod = config('auth.method');
         $sendInvite = ($request->get('send_invite', 'false') === 'true');
-        $externalAuth = $authMethod === 'ldap' || $authMethod === 'saml2' || $authMethod === 'oidc';
-        $passwordRequired = ($authMethod === 'standard' && !$sendInvite);
 
-        $validationRules = [
-            'name'             => ['required'],
-            'email'            => ['required', 'email', 'unique:users,email'],
-            'language'         => ['string'],
-            'roles'            => ['array'],
-            'roles.*'          => ['integer'],
-            'password'         => $passwordRequired ? ['required', Password::default()] : null,
-            'password-confirm' => $passwordRequired ? ['required', 'same:password'] : null,
-            'external_auth_id' => $externalAuth ? ['required'] : null,
-        ];
+        if ($authMethod === 'standard' && !$sendInvite) {
+            $validationRules['password'] = ['required', Password::default()];
+            $validationRules['password-confirm'] = ['required', 'same:password'];
+        } elseif ($authMethod === 'ldap' || $authMethod === 'saml2' || $authMethod === 'openid') {
+            $validationRules['external_auth_id'] = ['required'];
+        }
+        $this->validate($request, $validationRules);
 
-        $validated = $this->validate($request, array_filter($validationRules));
+        $user = $this->user->fill($request->all());
 
-        DB::transaction(function () use ($validated, $sendInvite) {
-            $this->userRepo->create($validated, $sendInvite);
-        });
+        if ($authMethod === 'standard') {
+            $user->password = bcrypt($request->get('password', Str::random(32)));
+        } elseif ($authMethod === 'ldap' || $authMethod === 'saml2' || $authMethod === 'openid') {
+            $user->external_auth_id = $request->get('external_auth_id');
+        }
+
+        $user->refreshSlug();
+        $user->save();
+
+        if ($sendInvite) {
+            $this->inviteService->sendInvitation($user);
+        }
+
+        if ($request->filled('roles')) {
+            $roles = $request->get('roles');
+            $this->userRepo->setUserRoles($user, $roles);
+        }
+
+        $this->userRepo->downloadAndAssignUserAvatar($user);
+
+        $this->logActivity(ActivityType::USER_CREATE, $user);
 
         return redirect('/settings/users');
     }
@@ -108,14 +125,14 @@ class UserController extends Controller
         $this->checkPermissionOrCurrentUser('users-manage', $id);
 
         /** @var User $user */
-        $user = User::query()->with(['apiTokens', 'mfaValues'])->findOrFail($id);
+        $user = $this->user->newQuery()->with(['apiTokens', 'mfaValues'])->findOrFail($id);
 
         $authMethod = ($user->system_name) ? 'system' : config('auth.method');
 
         $activeSocialDrivers = $socialAuthService->getActiveDrivers();
         $mfaMethods = $user->mfaValues->groupBy('method');
         $this->setPageTitle(trans('settings.user_profile'));
-        $roles = Role::query()->orderBy('display_name', 'asc')->get();
+        $roles = $this->userRepo->getAllRoles();
 
         return view('users.edit', [
             'user'                => $user,
@@ -138,20 +155,51 @@ class UserController extends Controller
         $this->preventAccessInDemoMode();
         $this->checkPermissionOrCurrentUser('users-manage', $id);
 
-        $validated = $this->validate($request, [
+        $this->validate($request, [
             'name'             => ['min:2'],
             'email'            => ['min:2', 'email', 'unique:users,email,' . $id],
             'password'         => ['required_with:password_confirm', Password::default()],
             'password-confirm' => ['same:password', 'required_with:password'],
-            'language'         => ['string'],
-            'roles'            => ['array'],
-            'roles.*'          => ['integer'],
-            'external_auth_id' => ['string'],
+            'setting'          => ['array'],
             'profile_image'    => array_merge(['nullable'], $this->getImageValidationRules()),
         ]);
 
         $user = $this->userRepo->getById($id);
-        $this->userRepo->update($user, $validated, userCan('users-manage'));
+        $user->fill($request->except(['email']));
+
+        // Email updates
+        if (userCan('users-manage') && $request->filled('email')) {
+            $user->email = $request->get('email');
+        }
+
+        // Refresh the slug if the user's name has changed
+        if ($user->isDirty('name')) {
+            $user->refreshSlug();
+        }
+
+        // Role updates
+        if (userCan('users-manage') && $request->filled('roles')) {
+            $roles = $request->get('roles');
+            $this->userRepo->setUserRoles($user, $roles);
+        }
+
+        // Password updates
+        if ($request->filled('password')) {
+            $password = $request->get('password');
+            $user->password = bcrypt($password);
+        }
+
+        // External auth id updates
+        if (user()->can('users-manage') && $request->filled('external_auth_id')) {
+            $user->external_auth_id = $request->get('external_auth_id');
+        }
+
+        // Save an user-specific settings
+        if ($request->filled('setting')) {
+            foreach ($request->get('setting') as $key => $value) {
+                setting()->putUser($user, $key, $value);
+            }
+        }
 
         // Save profile image if in request
         if ($request->hasFile('profile_image')) {
@@ -159,7 +207,6 @@ class UserController extends Controller
             $this->imageRepo->destroyImage($user->avatar);
             $image = $this->imageRepo->saveNew($imageUpload, 'user', $user->id);
             $user->image_id = $image->id;
-            $user->save();
         }
 
         // Delete the profile image if reset option is in request
@@ -167,7 +214,11 @@ class UserController extends Controller
             $this->imageRepo->destroyImage($user->avatar);
         }
 
-        $redirectUrl = userCan('users-manage') ? '/settings/users' : "/settings/users/{$user->id}";
+        $user->save();
+        $this->showSuccessNotification(trans('settings.users_edit_success'));
+        $this->logActivity(ActivityType::USER_UPDATE, $user);
+
+        $redirectUrl = userCan('users-manage') ? '/settings/users' : ('/settings/users/' . $user->id);
 
         return redirect($redirectUrl);
     }
@@ -198,7 +249,21 @@ class UserController extends Controller
         $user = $this->userRepo->getById($id);
         $newOwnerId = $request->get('new_owner_id', null);
 
+        if ($this->userRepo->isOnlyAdmin($user)) {
+            $this->showErrorNotification(trans('errors.users_cannot_delete_only_admin'));
+
+            return redirect($user->getEditUrl());
+        }
+
+        if ($user->system_name === 'public') {
+            $this->showErrorNotification(trans('errors.users_cannot_delete_guest'));
+
+            return redirect($user->getEditUrl());
+        }
+
         $this->userRepo->destroy($user, $newOwnerId);
+        $this->showSuccessNotification(trans('settings.users_delete_success'));
+        $this->logActivity(ActivityType::USER_DELETE, $user);
 
         return redirect('/settings/users');
     }
@@ -283,7 +348,7 @@ class UserController extends Controller
 
         $newState = $request->get('expand', 'false');
 
-        $user = $this->userRepo->getById($id);
+        $user = $this->user->findOrFail($id);
         setting()->putUser($user, 'section_expansion#' . $key, $newState);
 
         return response('', 204);
@@ -306,7 +371,7 @@ class UserController extends Controller
             $order = 'asc';
         }
 
-        $user = $this->userRepo->getById($userId);
+        $user = $this->user->findOrFail($userId);
         $sortKey = $listName . '_sort';
         $orderKey = $listName . '_sort_order';
         setting()->putUser($user, $sortKey, $sort);

app/Http/Controllers/UserProfileController.php

@@ -3,8 +3,6 @@
 namespace BookStack\Http\Controllers;
 
 use BookStack\Actions\ActivityQueries;
-use BookStack\Auth\Queries\UserContentCounts;
-use BookStack\Auth\Queries\UserRecentlyCreatedContent;
 use BookStack\Auth\UserRepo;
 
 class UserProfileController extends Controller
@@ -17,8 +15,8 @@ class UserProfileController extends Controller
         $user = $repo->getBySlug($slug);
 
         $userActivity = $activities->userActivity($user);
-        $recentlyCreated = (new UserRecentlyCreatedContent())->run($user, 5);
-        $assetCounts = (new UserContentCounts())->run($user);
+        $recentlyCreated = $repo->getRecentlyCreated($user, 5);
+        $assetCounts = $repo->getAssetCounts($user);
 
         $this->setPageTitle($user->name);
 

app/Http/Middleware/ApplyCspRules.php

@@ -8,7 +8,10 @@ use Illuminate\Http\Request;
 
 class ApplyCspRules
 {
-    protected CspService $cspService;
+    /**
+     * @var CspService
+     */
+    protected $cspService;
 
     public function __construct(CspService $cspService)
     {
@@ -32,8 +35,10 @@ class ApplyCspRules
 
         $response = $next($request);
 
-        $cspHeader = $this->cspService->getCspHeader();
-        $response->headers->set('Content-Security-Policy', $cspHeader, false);
+        $this->cspService->setFrameAncestors($response);
+        $this->cspService->setScriptSrc($response);
+        $this->cspService->setObjectSrc($response);
+        $this->cspService->setBaseUri($response);
 
         return $response;
     }

app/Http/Middleware/Localization.php

@@ -11,7 +11,7 @@ class Localization
     /**
      * Array of right-to-left locales.
      */
-    protected $rtlLocales = ['ar', 'fa', 'he'];
+    protected $rtlLocales = ['ar', 'he'];
 
     /**
      * Map of BookStack locale names to best-estimate system locale names.
@@ -29,8 +29,6 @@ class Localization
         'es'          => 'es_ES',
         'es_AR'       => 'es_AR',
         'et'          => 'et_EE',
-        'eu'          => 'eu_ES',
-        'fa'          => 'fa_IR',
         'fr'          => 'fr_FR',
         'he'          => 'he_IL',
         'hr'          => 'hr_HR',

app/Http/Request.php

@@ -8,38 +8,20 @@ class Request extends LaravelRequest
 {
     /**
      * Override the default request methods to get the scheme and host
-     * to directly use the custom APP_URL, if set.
+     * to set the custom APP_URL, if set.
      *
-     * @return string
+     * @return \Illuminate\Config\Repository|mixed|string
      */
     public function getSchemeAndHttpHost()
     {
-        $appUrl = config('app.url', null);
+        $base = config('app.url', null);
 
-        if ($appUrl) {
-            return implode('/', array_slice(explode('/', $appUrl), 0, 3));
+        if ($base) {
+            $base = trim($base, '/');
+        } else {
+            $base = $this->getScheme() . '://' . $this->getHttpHost();
         }
 
-        return parent::getSchemeAndHttpHost();
-    }
-
-    /**
-     * Override the default request methods to get the base URL
-     * to directly use the custom APP_URL, if set.
-     * The base URL never ends with a / but should start with one if not empty.
-     *
-     * @return string
-     */
-    public function getBaseUrl()
-    {
-        $appUrl = config('app.url', null);
-
-        if ($appUrl) {
-            $parsedBaseUrl = rtrim(implode('/', array_slice(explode('/', $appUrl), 3)), '/');
-
-            return empty($parsedBaseUrl) ? '' : ('/' . $parsedBaseUrl);
-        }
-
-        return parent::getBaseUrl();
+        return $base;
     }
 }

app/Notifications/UserInvite.php

@@ -2,33 +2,35 @@
 
 namespace BookStack\Notifications;
 
-use BookStack\Auth\User;
-use Illuminate\Notifications\Messages\MailMessage;
-
 class UserInvite extends MailNotification
 {
     public $token;
 
     /**
      * Create a new notification instance.
+     *
+     * @param string $token
      */
-    public function __construct(string $token)
+    public function __construct($token)
     {
         $this->token = $token;
     }
 
     /**
      * Get the mail representation of the notification.
+     *
+     * @param mixed $notifiable
+     *
+     * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail(User $notifiable): MailMessage
+    public function toMail($notifiable)
     {
         $appName = ['appName' => setting('app-name')];
-        $language = setting()->getUser($notifiable, 'language');
 
         return $this->newMailMessage()
-                ->subject(trans('auth.user_invite_email_subject', $appName, $language))
-                ->greeting(trans('auth.user_invite_email_greeting', $appName, $language))
-                ->line(trans('auth.user_invite_email_text', [], $language))
-                ->action(trans('auth.user_invite_email_action', [], $language), url('/register/invite/' . $this->token));
+                ->subject(trans('auth.user_invite_email_subject', $appName))
+                ->greeting(trans('auth.user_invite_email_greeting', $appName))
+                ->line(trans('auth.user_invite_email_text'))
+                ->action(trans('auth.user_invite_email_action'), url('/register/invite/' . $this->token));
     }
 }

app/Providers/AppServiceProvider.php

@@ -51,12 +51,12 @@ class AppServiceProvider extends ServiceProvider
         // Allow longer string lengths after upgrade to utf8mb4
         Schema::defaultStringLength(191);
 
-        // Set morph-map for our relations to friendlier aliases
-        Relation::enforceMorphMap([
-            'bookshelf' => Bookshelf::class,
-            'book'      => Book::class,
-            'chapter'   => Chapter::class,
-            'page'      => Page::class,
+        // Set morph-map due to namespace changes
+        Relation::morphMap([
+            'BookStack\\Bookshelf' => Bookshelf::class,
+            'BookStack\\Book'      => Book::class,
+            'BookStack\\Chapter'   => Chapter::class,
+            'BookStack\\Page'      => Page::class,
         ]);
 
         // View Composers

app/Providers/AuthServiceProvider.php

@@ -23,7 +23,6 @@ class AuthServiceProvider extends ServiceProvider
     public function boot()
     {
         // Password Configuration
-        // Changes here must be reflected in ApiDocsGenerate@getValidationAsString.
         Password::defaults(function () {
             return Password::min(8);
         });

app/Theming/ThemeEvents.php

@@ -93,8 +93,6 @@ class ThemeEvents
      * @param string                                $event
      * @param \BookStack\Actions\Webhook            $webhook
      * @param string|\BookStack\Interfaces\Loggable $detail
-     * @param \BookStack\Auth\User                  $initiator
-     * @param int                                   $initiatedTime
      */
     const WEBHOOK_CALL_BEFORE = 'webhook_call_before';
 }

app/Uploads/AttachmentService.php

@@ -14,7 +14,7 @@ use Symfony\Component\HttpFoundation\File\UploadedFile;
 
 class AttachmentService
 {
-    protected FilesystemManager $fileSystem;
+    protected $fileSystem;
 
     /**
      * AttachmentService constructor.
@@ -73,18 +73,6 @@ class AttachmentService
         return $this->getStorageDisk()->get($this->adjustPathForStorageDisk($attachment->path));
     }
 
-    /**
-     * Stream an attachment from storage.
-     *
-     * @throws FileNotFoundException
-     *
-     * @return resource|null
-     */
-    public function streamAttachmentFromStorage(Attachment $attachment)
-    {
-        return $this->getStorageDisk()->readStream($this->adjustPathForStorageDisk($attachment->path));
-    }
-
     /**
      * Store a new attachment upon user upload.
      *
@@ -223,6 +211,8 @@ class AttachmentService
      */
     protected function putFileInStorage(UploadedFile $uploadedFile): string
     {
+        $attachmentData = file_get_contents($uploadedFile->getRealPath());
+
         $storage = $this->getStorageDisk();
         $basePath = 'uploads/files/' . date('Y-m-M') . '/';
 
@@ -231,11 +221,10 @@ class AttachmentService
             $uploadFileName = Str::random(3) . $uploadFileName;
         }
 
-        $attachmentStream = fopen($uploadedFile->getRealPath(), 'r');
         $attachmentPath = $basePath . $uploadFileName;
 
         try {
-            $storage->writeStream($this->adjustPathForStorageDisk($attachmentPath), $attachmentStream);
+            $storage->put($this->adjustPathForStorageDisk($attachmentPath), $attachmentData);
         } catch (Exception $e) {
             Log::error('Error when attempting file upload:' . $e->getMessage());
 

app/Uploads/ImageService.php

@@ -5,7 +5,6 @@ namespace BookStack\Uploads;
 use BookStack\Exceptions\ImageUploadException;
 use ErrorException;
 use Exception;
-use GuzzleHttp\Psr7\Utils;
 use Illuminate\Contracts\Cache\Repository as Cache;
 use Illuminate\Contracts\Filesystem\FileNotFoundException;
 use Illuminate\Contracts\Filesystem\Filesystem as Storage;
@@ -15,7 +14,6 @@ use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;
 use Intervention\Image\Exception\NotSupportedException;
-use Intervention\Image\Image as InterventionImage;
 use Intervention\Image\ImageManager;
 use League\Flysystem\Util;
 use Psr\SimpleCache\InvalidArgumentException;
@@ -310,8 +308,6 @@ class ImageService
             throw new ImageUploadException(trans('errors.cannot_create_thumbs'));
         }
 
-        $this->orientImageToOriginalExif($thumb, $imageData);
-
         if ($keepRatio) {
             $thumb->resize($width, $height, function ($constraint) {
                 $constraint->aspectRatio();
@@ -332,49 +328,6 @@ class ImageService
         return $thumbData;
     }
 
-    /**
-     * Orientate the given intervention image based upon the given original image data.
-     * Intervention does have an `orientate` method but the exif data it needs is lost before it
-     * can be used (At least when created using binary string data) so we need to do some
-     * implementation on our side to use the original image data.
-     * Bulk of logic taken from: https://github.com/Intervention/image/blob/b734a4988b2148e7d10364b0609978a88d277536/src/Intervention/Image/Commands/OrientateCommand.php
-     * Copyright (c) Oliver Vogel, MIT License.
-     */
-    protected function orientImageToOriginalExif(InterventionImage $image, string $originalData): void
-    {
-        if (!extension_loaded('exif')) {
-            return;
-        }
-
-        $stream = Utils::streamFor($originalData)->detach();
-        $exif = @exif_read_data($stream);
-        $orientation = $exif ? ($exif['Orientation'] ?? null) : null;
-
-        switch ($orientation) {
-            case 2:
-                $image->flip();
-                break;
-            case 3:
-                $image->rotate(180);
-                break;
-            case 4:
-                $image->rotate(180)->flip();
-                break;
-            case 5:
-                $image->rotate(270)->flip();
-                break;
-            case 6:
-                $image->rotate(270);
-                break;
-            case 7:
-                $image->rotate(90)->flip();
-                break;
-            case 8:
-                $image->rotate(90);
-                break;
-        }
-    }
-
     /**
      * Get the raw data content from an image.
      *

app/Uploads/UserAvatars.php

@@ -2,6 +2,7 @@
 
 namespace BookStack\Uploads;
 
+use BookStack\Auth\Access\LdapService;
 use BookStack\Auth\User;
 use BookStack\Exceptions\HttpFetchException;
 use Exception;
@@ -16,6 +17,7 @@ class UserAvatars
     {
         $this->imageService = $imageService;
         $this->http = $http;
+        $ldapService = app()->make(LdapService::class);
     }
 
     /**

app/Util/CspService.php

@@ -3,10 +3,12 @@
 namespace BookStack\Util;
 
 use Illuminate\Support\Str;
+use Symfony\Component\HttpFoundation\Response;
 
 class CspService
 {
-    protected string $nonce;
+    /** @var string */
+    protected $nonce;
 
     public function __construct(string $nonce = '')
     {
@@ -22,34 +24,37 @@ class CspService
     }
 
     /**
-     * Get the CSP headers for the application.
+     * Sets CSP 'script-src' headers to restrict the forms of script that can
+     * run on the page.
      */
-    public function getCspHeader(): string
+    public function setScriptSrc(Response $response)
     {
-        $headers = [
-            $this->getFrameAncestors(),
-            $this->getFrameSrc(),
-            $this->getScriptSrc(),
-            $this->getObjectSrc(),
-            $this->getBaseUri(),
+        if (config('app.allow_content_scripts')) {
+            return;
+        }
+
+        $parts = [
+            'http:',
+            'https:',
+            '\'nonce-' . $this->nonce . '\'',
+            '\'strict-dynamic\'',
         ];
 
-        return implode('; ', array_filter($headers));
+        $value = 'script-src ' . implode(' ', $parts);
+        $response->headers->set('Content-Security-Policy', $value, false);
     }
 
     /**
-     * Get the CSP rules for the application for a HTML meta tag.
+     * Sets CSP "frame-ancestors" headers to restrict the hosts that BookStack can be
+     * iframed within. Also adjusts the cookie samesite options so that cookies will
+     * operate in the third-party context.
      */
-    public function getCspMetaTagValue(): string
+    public function setFrameAncestors(Response $response)
     {
-        $headers = [
-            $this->getFrameSrc(),
-            $this->getScriptSrc(),
-            $this->getObjectSrc(),
-            $this->getBaseUri(),
-        ];
-
-        return implode('; ', array_filter($headers));
+        $iframeHosts = $this->getAllowedIframeHosts();
+        array_unshift($iframeHosts, "'self'");
+        $cspValue = 'frame-ancestors ' . implode(' ', $iframeHosts);
+        $response->headers->set('Content-Security-Policy', $cspValue, false);
     }
 
     /**
@@ -61,67 +66,25 @@ class CspService
     }
 
     /**
-     * Create CSP 'script-src' rule to restrict the forms of script that can run on the page.
-     */
-    protected function getScriptSrc(): string
-    {
-        if (config('app.allow_content_scripts')) {
-            return '';
-        }
-
-        $parts = [
-            'http:',
-            'https:',
-            '\'nonce-' . $this->nonce . '\'',
-            '\'strict-dynamic\'',
-        ];
-
-        return 'script-src ' . implode(' ', $parts);
-    }
-
-    /**
-     * Create CSP "frame-ancestors" rule to restrict the hosts that BookStack can be iframed within.
-     */
-    protected function getFrameAncestors(): string
-    {
-        $iframeHosts = $this->getAllowedIframeHosts();
-        array_unshift($iframeHosts, "'self'");
-
-        return 'frame-ancestors ' . implode(' ', $iframeHosts);
-    }
-
-    /**
-     * Creates CSP "frame-src" rule to restrict what hosts/sources can be loaded
-     * within iframes to provide an allow-list-style approach to iframe content.
-     */
-    protected function getFrameSrc(): string
-    {
-        $iframeHosts = $this->getAllowedIframeSources();
-        array_unshift($iframeHosts, "'self'");
-
-        return 'frame-src ' . implode(' ', $iframeHosts);
-    }
-
-    /**
-     * Creates CSP 'object-src' rule to restrict the types of dynamic content
+     * Sets CSP 'object-src' headers to restrict the types of dynamic content
      * that can be embedded on the page.
      */
-    protected function getObjectSrc(): string
+    public function setObjectSrc(Response $response)
     {
         if (config('app.allow_content_scripts')) {
-            return '';
+            return;
         }
 
-        return "object-src 'self'";
+        $response->headers->set('Content-Security-Policy', 'object-src \'self\'', false);
     }
 
     /**
-     * Creates CSP 'base-uri' rule to restrict what base tags can be set on
+     * Sets CSP 'base-uri' headers to restrict what base tags can be set on
      * the page to prevent manipulation of relative links.
      */
-    protected function getBaseUri(): string
+    public function setBaseUri(Response $response)
     {
-        return "base-uri 'self'";
+        $response->headers->set('Content-Security-Policy', 'base-uri \'self\'', false);
     }
 
     protected function getAllowedIframeHosts(): array
@@ -130,21 +93,4 @@ class CspService
 
         return array_filter(explode(' ', $hosts));
     }
-
-    protected function getAllowedIframeSources(): array
-    {
-        $sources = config('app.iframe_sources', '');
-        $hosts = array_filter(explode(' ', $sources));
-
-        // Extract drawing service url to allow embedding if active
-        $drawioConfigValue = config('services.drawio');
-        if ($drawioConfigValue) {
-            $drawioSource = is_string($drawioConfigValue) ? $drawioConfigValue : 'https://embed.diagrams.net/';
-            $drawioSourceParsed = parse_url($drawioSource);
-            $drawioHost = $drawioSourceParsed['scheme'] . '://' . $drawioSourceParsed['host'];
-            $hosts[] = $drawioHost;
-        }
-
-        return $hosts;
-    }
 }

composer.json

@@ -8,7 +8,7 @@
     "license": "MIT",
     "type": "project",
     "require": {
-        "php": "^7.4|^8.0",
+        "php": "^7.3|^8.0",
         "ext-curl": "*",
         "ext-dom": "*",
         "ext-fileinfo": "*",
@@ -17,8 +17,8 @@
         "ext-mbstring": "*",
         "ext-xml": "*",
         "bacon/bacon-qr-code": "^2.0",
-        "barryvdh/laravel-dompdf": "^1.0",
-        "barryvdh/laravel-snappy": "^1.0",
+        "barryvdh/laravel-dompdf": "^0.9.0",
+        "barryvdh/laravel-snappy": "^0.4.8",
         "doctrine/dbal": "^3.1",
         "filp/whoops": "^2.14",
         "guzzlehttp/guzzle": "^7.4",
@@ -41,7 +41,7 @@
         "socialiteproviders/okta": "^4.1",
         "socialiteproviders/slack": "^4.1",
         "socialiteproviders/twitch": "^5.3",
-        "ssddanbrown/htmldiff": "^1.0.2"
+        "ssddanbrown/htmldiff": "^1.0.1"
     },
     "require-dev": {
         "fakerphp/faker": "^1.16",
@@ -95,7 +95,7 @@
         "preferred-install": "dist",
         "sort-packages": true,
         "platform": {
-            "php": "7.4.0"
+            "php": "7.3.0"
         }
     },
     "extra": {

database/migrations/2022_04_17_101741_add_editor_change_field_and_permission.php

@@ -1,62 +0,0 @@
-<?php
-
-use Carbon\Carbon;
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Facades\Schema;
-
-class AddEditorChangeFieldAndPermission extends Migration
-{
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-        // Add the new 'editor' column to the pages table
-        Schema::table('pages', function (Blueprint $table) {
-            $table->string('editor', 50)->default('');
-        });
-
-        // Populate the new 'editor' column
-        // We set it to 'markdown' for pages currently with markdown content
-        DB::table('pages')->where('markdown', '!=', '')->update(['editor' => 'markdown']);
-        // We set it to 'wysiwyg' where we have HTML but no markdown
-        DB::table('pages')->where('markdown', '=', '')
-            ->where('html', '!=', '')
-            ->update(['editor' => 'wysiwyg']);
-
-        // Give the admin user permission to change the editor
-        $adminRoleId = DB::table('roles')->where('system_name', '=', 'admin')->first()->id;
-
-        $permissionId = DB::table('role_permissions')->insertGetId([
-            'name'         => 'editor-change',
-            'display_name' => 'Change page editor',
-            'created_at'   => Carbon::now()->toDateTimeString(),
-            'updated_at'   => Carbon::now()->toDateTimeString(),
-        ]);
-
-        DB::table('permission_role')->insert([
-            'role_id'       => $adminRoleId,
-            'permission_id' => $permissionId,
-        ]);
-    }
-
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-        // Drop the new column from the pages table
-        Schema::table('pages', function (Blueprint $table) {
-            $table->dropColumn('editor');
-        });
-
-        // Remove traces of the role permission
-        DB::table('role_permissions')->where('name', '=', 'editor-change')->delete();
-    }
-}

database/migrations/2022_04_25_140741_update_polymorphic_types.php

@@ -1,64 +0,0 @@
-<?php
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Support\Facades\DB;
-
-class UpdatePolymorphicTypes extends Migration
-{
-    /**
-     * Mapping of old polymorphic types to new simpler values.
-     */
-    protected $changeMap = [
-        'BookStack\\Bookshelf' => 'bookshelf',
-        'BookStack\\Book'      => 'book',
-        'BookStack\\Chapter'   => 'chapter',
-        'BookStack\\Page'      => 'page',
-    ];
-
-    /**
-     * Mapping of tables and columns that contain polymorphic types.
-     */
-    protected $columnsByTable = [
-        'activities'         => 'entity_type',
-        'comments'           => 'entity_type',
-        'deletions'          => 'deletable_type',
-        'entity_permissions' => 'restrictable_type',
-        'favourites'         => 'favouritable_type',
-        'joint_permissions'  => 'entity_type',
-        'search_terms'       => 'entity_type',
-        'tags'               => 'entity_type',
-        'views'              => 'viewable_type',
-    ];
-
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-        foreach ($this->columnsByTable as $table => $column) {
-            foreach ($this->changeMap as $oldVal => $newVal) {
-                DB::table($table)
-                    ->where([$column => $oldVal])
-                    ->update([$column => $newVal]);
-            }
-        }
-    }
-
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-        foreach ($this->columnsByTable as $table => $column) {
-            foreach ($this->changeMap as $oldVal => $newVal) {
-                DB::table($table)
-                    ->where([$column => $newVal])
-                    ->update([$column => $oldVal]);
-            }
-        }
-    }
-}

dev/api/requests/users-create.json

@@ -1,7 +0,0 @@
-{
-  "name": "Dan Brown",
-  "email": "dannyb@example.com",
-  "roles": [1],
-  "language": "fr",
-  "send_invite": true
-}

dev/api/requests/users-delete.json

@@ -1,3 +0,0 @@
-{
-  "migrate_ownership_id": 5
-}

dev/api/requests/users-update.json

@@ -1,7 +0,0 @@
-{
-  "name": "Dan Spaggleforth",
-  "email": "dspaggles@example.com",
-  "roles": [2],
-  "language": "de",
-  "password": "hunter2000"
-}

dev/api/responses/recycle-bin-destroy.json

@@ -1,3 +0,0 @@
-{
-  "delete_count": 2
-}

dev/api/responses/recycle-bin-list.json

@@ -1,64 +0,0 @@
-{
-  "data": [
-    {
-      "id": 18,
-      "deleted_by": 1,
-      "created_at": "2022-04-20T12:57:46.000000Z",
-      "updated_at": "2022-04-20T12:57:46.000000Z",
-      "deletable_type": "page",
-      "deletable_id": 2582,
-      "deletable": {
-        "id": 2582,
-        "book_id": 25,
-        "chapter_id": 0,
-        "name": "A Wonderful Page",
-        "slug": "a-wonderful-page",
-        "priority": 9,
-        "created_at": "2022-02-08T00:44:45.000000Z",
-        "updated_at": "2022-04-20T12:57:46.000000Z",
-        "created_by": 1,
-        "updated_by": 1,
-        "draft": false,
-        "revision_count": 1,
-        "template": false,
-        "owned_by": 1,
-        "editor": "wysiwyg",
-        "book_slug": "a-great-book",
-        "parent": {
-          "id": 25,
-          "name": "A Great Book",
-          "slug": "a-great-book",
-          "description": "",
-          "created_at": "2022-01-24T16:14:28.000000Z",
-          "updated_at": "2022-03-06T15:14:50.000000Z",
-          "created_by": 1,
-          "updated_by": 1,
-          "owned_by": 1,
-          "type": "book"
-        }
-      }
-    },
-    {
-      "id": 19,
-      "deleted_by": 1,
-      "created_at": "2022-04-25T16:07:46.000000Z",
-      "updated_at": "2022-04-25T16:07:46.000000Z",
-      "deletable_type": "book",
-      "deletable_id": 13,
-      "deletable": {
-        "id": 13,
-        "name": "A Big Book!",
-        "slug": "a-big-book",
-        "description": "This is a very large book with loads of cool stuff in it!",
-        "created_at": "2021-11-08T11:26:43.000000Z",
-        "updated_at": "2022-04-25T16:07:47.000000Z",
-        "created_by": 27,
-        "updated_by": 1,
-        "owned_by": 1,
-        "pages_count": 208,
-        "chapters_count": 50
-      }
-    }
-  ],
-  "total": 2
-}

dev/api/responses/recycle-bin-restore.json

@@ -1,3 +0,0 @@
-{
-  "restore_count": 2
-}

dev/api/responses/users-create.json

@@ -1,19 +0,0 @@
-{
-  "id": 1,
-  "name": "Dan Brown",
-  "email": "dannyb@example.com",
-  "created_at": "2022-02-03T16:27:55.000000Z",
-  "updated_at": "2022-02-03T16:27:55.000000Z",
-  "external_auth_id": "abc123456",
-  "slug": "dan-brown",
-  "last_activity_at": "2022-02-03T16:27:55.000000Z",
-  "profile_url": "https://docs.example.com/user/dan-brown",
-  "edit_url": "https://docs.example.com/settings/users/1",
-  "avatar_url": "https://docs.example.com/uploads/images/user/2021-10/thumbs-50-50/profile-2021.jpg",
-  "roles": [
-    {
-      "id": 1,
-      "display_name": "Admin"
-    }
-  ]
-}