immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3010] [MERGED] fix(mobile): fix endless rendering of asset grid when scrolling #9810

New Issue
Closed
opened 2026-02-05 14:11:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:11:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3010
Author: @fyfrey
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/29/2023
Merged by: @alextran1502

Base: main ← Head: dev/fix-endless-asset-grid-rendering

📝 Commits (1)

  • 9155a99 fix(mobile): fix endless rendering of asset grid when scrolling

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 mobile/lib/modules/home/ui/asset_grid/immich_asset_grid_view.dart (+1 -6)

📄 Description

Currently, the entire asset grid is rebuilt multiple per second while scrolling with the draggable scroll bar. This is awful for performance and results in all sorts of issues originating from re-rendering (such as animation flickering).

This PR fixes the issue by not calling setState within build

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3010 **Author:** [@fyfrey](https://github.com/fyfrey) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/29/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `dev/fix-endless-asset-grid-rendering` --- ### 📝 Commits (1) - [`9155a99`](https://github.com/immich-app/immich/commit/9155a99094560f93bad1960fc8bdf2a04e4f8d02) fix(mobile): fix endless rendering of asset grid when scrolling ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/home/ui/asset_grid/immich_asset_grid_view.dart` (+1 -6) </details> ### 📄 Description Currently, the entire asset grid is rebuilt multiple per second while scrolling with the draggable scroll bar. This is awful for performance and results in all sorts of issues originating from re-rendering (such as animation flickering). This PR fixes the issue by not calling `setState` within `build` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:11:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9810
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?