immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #2747] [MERGED] don't fallback to exiftool for embedded image previews #9687

New Issue
Closed
opened 2026-02-05 14:09:07 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:09:07 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2747
Author: @uhthomas
Created: 6/13/2023
Status: ✅ Merged
Merged: 6/15/2023
Merged by: @alextran1502

Base: main ← Head: 2744

📝 Commits (1)

  • 93bc8b5 don't fallback to exiftool for embedded image previews

📊 Changes

5 files changed (+8 additions, -43 deletions)

View changed files

📝 server/src/domain/media/media.repository.ts (+0 -1)
📝 server/src/domain/media/media.service.spec.ts (+0 -22)
📝 server/src/domain/media/media.service.ts (+8 -14)
📝 server/src/infra/repositories/media.repository.ts (+0 -5)
📝 server/test/repositories/media.repository.mock.ts (+0 -1)

📄 Description

Given #2668 introduced support for imagemagick and libraw, this should no longer be necessary which allow for reduced code footprint and complexity.

Fixes: #2744

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2747 **Author:** [@uhthomas](https://github.com/uhthomas) **Created:** 6/13/2023 **Status:** ✅ Merged **Merged:** 6/15/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `2744` --- ### 📝 Commits (1) - [`93bc8b5`](https://github.com/immich-app/immich/commit/93bc8b52fbd4b6b81232ab14f3b009759981d463) don't fallback to exiftool for embedded image previews ### 📊 Changes **5 files changed** (+8 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/media/media.repository.ts` (+0 -1) 📝 `server/src/domain/media/media.service.spec.ts` (+0 -22) 📝 `server/src/domain/media/media.service.ts` (+8 -14) 📝 `server/src/infra/repositories/media.repository.ts` (+0 -5) 📝 `server/test/repositories/media.repository.mock.ts` (+0 -1) </details> ### 📄 Description Given #2668 introduced support for imagemagick and libraw, this should no longer be necessary which allow for reduced code footprint and complexity. Fixes: #2744 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:09:07 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?