immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 08:41:28 +03:00
Code Issues 26 Packages Projects Releases 10 Wiki Activity

[BUG] android motion photos fail to link when asset is uploaded separately #2747

New Issue
Closed
opened 2026-02-05 06:58:32 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 06:58:32 +03:00
Owner
Copy Link

Originally created by @Ynng on GitHub (Apr 4, 2024).

The bug

When you upload the "video" part of an Android motion photo first, then upload the MVIMG jpg second, Immich fails to link the jpg and mp4 files together.
This is easy to encounter, as App-Which-Must-Not-Be-Named takeout often contains both of these files separately.

Steps for reproduction:

  1. Obtain a MVIMG photo and its corresponding MP4 file. Here's an example https://files.catbox.moe/1juay1.MP4 https://files.catbox.moe/b59ftp.jpg
  2. Upload the MP4 to Immich first
  3. Then upload the jpg
  4. Observe that the jpg is not recognized as a motion photo.
    4.1 Backend logs say Asset xxxx's motion photo video with checksum xxxx already exists in the repository
  5. Permanently delete the MP4.
  6. Refresh metadata on the JPG.
  7. Observe that the motion photo now works properly.

Here's a video showing the reproduction steps:

https://github.com/immich-app/immich/assets/44907675/5862cc07-9057-49f5-a1c4-ed286681161e

In addition to MVIMG formatted photos (MVIMG_xxxx_xxxx.MP4 and MVIMG_xxxx_xxxx.jpg).
The issue also exists for MP formatted photos (PXL_xxxx_xxxx.MP and PXL_xxxx_xxxx.MV.jpg). The same issue can be easily reproduced for MP by renaming PXL_xxxx_xxxx.MP to PXL_xxxx_xxxx.MP.mp4 before uploading, then upload the jpg.

I cannot reproduce the same issue with Apple Live Photos in heif

A simple fix seems to be updating the livePhotoVideoId of the asset regardless of whether or not the motionAsset already exist here:
66650f5944/server/src/services/metadata.service.ts (L410)

The OS that Immich Server is running on

Fedora Linux 37

Version of Immich Server

v1.100.0

Version of Immich Mobile App

v1.100.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

version: '3.8'

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#

name: immich

services:
  immich-prometheus:
    container_name: immich_prometheus
    ports:
      # this exposes the default port for Prometheus so you can interact with it
      - 9090:9090
    image: prom/prometheus
    volumes:
      # the Prometheus configuration file - a barebones one is provided to get started
      - ./prometheus.yml:/etc/prometheus/prometheus.yml
      # a named volume defined in the bottom of the Compose file; it can also be a mounted folder
      - prometheus-data:/prometheus

  immich-grafana:
    container_name: immich_grafana
    command: ['./run.sh', '-disable-reporting'] # this is to disable Grafana's telemetry
    ports:
      - 3000:3000
    image: grafana/grafana
    volumes:
      # stores your pretty dashboards and panels
      - grafana-data:/var/lib/grafana
 
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: ['start.sh', 'immich']
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
      - ${EXTERNAL_PATH}:/usr/src/app/external
    env_file:
      - .env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: always

  immich-microservices:
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/hardware-transcoding
      file: hwaccel.transcoding.yml
      service: nvenc # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    command: ['start.sh', 'microservices']
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
      - ${EXTERNAL_PATH}:/usr/src/app/external
    env_file:
      - .env
    depends_on:
      - redis
      - database
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.
    # Example tag: ${IMMICH_VERSION:-release}-cuda
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}-cuda
    extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration
      file: hwaccel.ml.yml
      service: cuda # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable
    volumes:
      - model-cache:/cache
    env_file:
      - .env
    restart: always

  redis:
    container_name: immich_redis
    image: registry.hub.docker.com/library/redis:6.2-alpine@sha256:51d6c56749a4243096327e3fb964a48ed92254357108449cb6e23999c37773c5
    restart: always

  database:
    container_name: immich_postgres
    image: registry.hub.docker.com/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

volumes:
  pgdata:
  model-cache:
  prometheus-data:
  grafana-data:

Your .env content

# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables

# The location where your uploaded files are stored
UPLOAD_LOCATION=<redacted>

# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release

# Connection secret for postgres. You should change it to a random password
DB_PASSWORD=<redacted>

IMMICH_METRICS=true
EXTERNAL_PATH=<redacted>

# The values below this line do not need to be changed
###################################################################################
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_DATABASE_NAME=immich

REDIS_HOSTNAME=immich_redis
LOG_LEVEL=debug

Reproduction steps

See above

Additional information

No response

Originally created by @Ynng on GitHub (Apr 4, 2024). ### The bug When you upload the "video" part of an Android motion photo first, then upload the MVIMG jpg second, Immich fails to link the jpg and mp4 files together. This is easy to encounter, as _**App-Which-Must-Not-Be-Named**_ takeout often contains both of these files separately. Steps for reproduction: 1. Obtain a MVIMG photo and its corresponding MP4 file. Here's an example https://files.catbox.moe/1juay1.MP4 https://files.catbox.moe/b59ftp.jpg 2. Upload the MP4 to Immich first 3. Then upload the jpg 4. Observe that the jpg is not recognized as a motion photo. 4.1 Backend logs say `Asset xxxx's motion photo video with checksum xxxx already exists in the repository` 5. Permanently delete the MP4. 6. Refresh metadata on the JPG. 7. Observe that the motion photo now works properly. Here's a video showing the reproduction steps: https://github.com/immich-app/immich/assets/44907675/5862cc07-9057-49f5-a1c4-ed286681161e In addition to `MVIMG` formatted photos (`MVIMG_xxxx_xxxx.MP4` and `MVIMG_xxxx_xxxx.jpg`). The issue also exists for `MP` formatted photos (`PXL_xxxx_xxxx.MP` and `PXL_xxxx_xxxx.MV.jpg`). The same issue can be easily reproduced for `MP` by renaming `PXL_xxxx_xxxx.MP` to `PXL_xxxx_xxxx.MP.mp4` before uploading, then upload the jpg. I cannot reproduce the same issue with Apple Live Photos in `heif` A simple fix seems to be updating the `livePhotoVideoId` of the asset regardless of whether or not the `motionAsset` already exist here: https://github.com/immich-app/immich/blob/66650f594487c99715cb75555ce401b721bb8ee6/server/src/services/metadata.service.ts#L410 ### The OS that Immich Server is running on Fedora Linux 37 ### Version of Immich Server v1.100.0 ### Version of Immich Mobile App v1.100.0 ### Platform with the issue - [X] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML version: '3.8' # # WARNING: Make sure to use the docker-compose.yml of the current release: # # https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml # # The compose file on main may not be compatible with the latest release. # name: immich services: immich-prometheus: container_name: immich_prometheus ports: # this exposes the default port for Prometheus so you can interact with it - 9090:9090 image: prom/prometheus volumes: # the Prometheus configuration file - a barebones one is provided to get started - ./prometheus.yml:/etc/prometheus/prometheus.yml # a named volume defined in the bottom of the Compose file; it can also be a mounted folder - prometheus-data:/prometheus immich-grafana: container_name: immich_grafana command: ['./run.sh', '-disable-reporting'] # this is to disable Grafana's telemetry ports: - 3000:3000 image: grafana/grafana volumes: # stores your pretty dashboards and panels - grafana-data:/var/lib/grafana immich-server: container_name: immich_server image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release} command: ['start.sh', 'immich'] volumes: - ${UPLOAD_LOCATION}:/usr/src/app/upload - /etc/localtime:/etc/localtime:ro - ${EXTERNAL_PATH}:/usr/src/app/external env_file: - .env ports: - 2283:3001 depends_on: - redis - database restart: always immich-microservices: container_name: immich_microservices image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release} extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/hardware-transcoding file: hwaccel.transcoding.yml service: nvenc # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding command: ['start.sh', 'microservices'] volumes: - ${UPLOAD_LOCATION}:/usr/src/app/upload - /etc/localtime:/etc/localtime:ro - ${EXTERNAL_PATH}:/usr/src/app/external env_file: - .env depends_on: - redis - database restart: always immich-machine-learning: container_name: immich_machine_learning # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag. # Example tag: ${IMMICH_VERSION:-release}-cuda image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}-cuda extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration file: hwaccel.ml.yml service: cuda # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable volumes: - model-cache:/cache env_file: - .env restart: always redis: container_name: immich_redis image: registry.hub.docker.com/library/redis:6.2-alpine@sha256:51d6c56749a4243096327e3fb964a48ed92254357108449cb6e23999c37773c5 restart: always database: container_name: immich_postgres image: registry.hub.docker.com/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0 environment: POSTGRES_PASSWORD: ${DB_PASSWORD} POSTGRES_USER: ${DB_USERNAME} POSTGRES_DB: ${DB_DATABASE_NAME} volumes: - pgdata:/var/lib/postgresql/data restart: always volumes: pgdata: model-cache: prometheus-data: grafana-data: ``` ### Your .env content ```Shell # You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables # The location where your uploaded files are stored UPLOAD_LOCATION=<redacted> # The Immich version to use. You can pin this to a specific version like "v1.71.0" IMMICH_VERSION=release # Connection secret for postgres. You should change it to a random password DB_PASSWORD=<redacted> IMMICH_METRICS=true EXTERNAL_PATH=<redacted> # The values below this line do not need to be changed ################################################################################### DB_HOSTNAME=immich_postgres DB_USERNAME=postgres DB_DATABASE_NAME=immich REDIS_HOSTNAME=immich_redis LOG_LEVEL=debug ``` ### Reproduction steps ```bash See above ``` ### Additional information _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#2747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?