immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1980] [MERGED] fix(server): remove encoded video file on asset delete #9313

New Issue
Closed
opened 2026-02-05 14:02:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:02:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1980
Author: @raisinbear
Created: 3/11/2023
Status: ✅ Merged
Merged: 3/13/2023
Merged by: @jrasm91

Base: main ← Head: fix/server-delete-encoded-video-when-deleting-asset

📝 Commits (6)

  • 8b2cf4a add check for encoded video file to be deleted with asset
  • d31aeab remove unnecessary code and adjust test
  • 6b3a95a complete test
  • b3e9115 fix unit test
  • 4494cac fix unit test properly this time
  • eb216a7 fix formatting

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 server/apps/immich/src/api-v1/asset/asset.service.spec.ts (+13 -1)
📝 server/apps/immich/src/api-v1/asset/asset.service.ts (+1 -1)

📄 Description

#792 is back. Introduced a simple check for encoded video file path during object insertion into delete queue. Sorry in advance if this solution is cumbersome. I'm not apt in anything js related.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1980 **Author:** [@raisinbear](https://github.com/raisinbear) **Created:** 3/11/2023 **Status:** ✅ Merged **Merged:** 3/13/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/server-delete-encoded-video-when-deleting-asset` --- ### 📝 Commits (6) - [`8b2cf4a`](https://github.com/immich-app/immich/commit/8b2cf4a4fe162bd141b5a35d3439064f787d94f5) add check for encoded video file to be deleted with asset - [`d31aeab`](https://github.com/immich-app/immich/commit/d31aeabbc37ce721c1e280e9cb6ac527b4728662) remove unnecessary code and adjust test - [`6b3a95a`](https://github.com/immich-app/immich/commit/6b3a95a2606a99440e11fdd77d766cad21dbdcf8) complete test - [`b3e9115`](https://github.com/immich-app/immich/commit/b3e911574934bf42bb95f723b559cbb3204501a8) fix unit test - [`4494cac`](https://github.com/immich-app/immich/commit/4494cacbad7ec539c39dadabc51f80d608a2b661) fix unit test properly this time - [`eb216a7`](https://github.com/immich-app/immich/commit/eb216a79dc87200db139da972ac3ed024997dd56) fix formatting ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/apps/immich/src/api-v1/asset/asset.service.spec.ts` (+13 -1) 📝 `server/apps/immich/src/api-v1/asset/asset.service.ts` (+1 -1) </details> ### 📄 Description #792 is back. Introduced a simple check for encoded video file path during object insertion into delete queue. Sorry in advance if this solution is cumbersome. I'm not apt in anything js related. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:02:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?