immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-25 03:12:21 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #526] [MERGED] Migrate SvelteKit to the latest version 431 #8658

New Issue
Closed
opened 2026-02-05 13:51:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:51:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/526
Author: @alextran1502
Created: 8/24/2022
Status: ✅ Merged
Merged: 8/25/2022
Merged by: @alextran1502

Base: main ← Head: experimental/update-sveltekit

📝 Commits (10+)

📊 Changes

47 files changed (+1511 additions, -1218 deletions)

View changed files

📝 docker/docker-compose.dev.yml (+3 -0)
📝 server/Dockerfile (+2 -2)
📝 web/package-lock.json (+1016 -538)
📝 web/package.json (+0 -1)
📝 web/src/app.d.ts (+0 -6)
📝 web/src/hooks.ts (+2 -28)
📝 web/src/lib/components/album-page/album-card.svelte (+1 -1)
📝 web/src/lib/components/shared-components/upload-panel.svelte (+0 -1)
➕ web/src/routes/+error.svelte (+29 -0)
➕ web/src/routes/+layout.server.ts (+23 -0)
📝 web/src/routes/+layout.svelte (+3 -13)
➕ web/src/routes/+page.svelte (+29 -0)
➕ web/src/routes/+page.ts (+21 -0)
➕ web/src/routes/admin/+page.server.ts (+19 -0)
📝 web/src/routes/admin/+page.svelte (+12 -55)
➕ web/src/routes/albums/+page.server.ts (+22 -0)
📝 web/src/routes/albums/+page.svelte (+17 -56)
➕ web/src/routes/albums/[albumId]/+page.server.ts (+23 -0)
➕ web/src/routes/albums/[albumId]/+page.svelte (+14 -0)
➖ web/src/routes/albums/[albumId]/index.svelte (+0 -57)

...and 27 more files

📄 Description

  • Migrate to the new convention for the route's file name
  • Refactor new API

References

1 - Migration Guide - https://github.com/sveltejs/kit/discussions/5774#discussioncomment-3292707
2 - Removing Session - https://github.com/sveltejs/kit/discussions/5883

Behavior tests

Photos route

  • When not logged in, entering /photos will be redirected to /auth/login
  • When logged in, entering /photos/[assetId] will redirected to /photos (since the photo viewer is not a route but an overlay on top on photos page)
  • When not logged in, entering /photos/[assetId] will redirected to /auth/login

Sharing route

  • When not logged in, entering /sharing will be redirected to /auth/login

Albums route

  • When not logged in, entering /albums will be redirected to /auth/login

Admin route

  • When not logged in, entering /admin will be redirected to /auth/login
  • When logged in but the user is not admin, entering /admin will be redirected to /photos

Auth routes

  • Register admin

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/526 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 8/24/2022 **Status:** ✅ Merged **Merged:** 8/25/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `experimental/update-sveltekit` --- ### 📝 Commits (10+) - [`e8a7432`](https://github.com/immich-app/immich/commit/e8a743269a3a617375b79a531dd27471a18f5595) Refactor page - [`427c60c`](https://github.com/immich-app/immich/commit/427c60c6f15a69805df59e6de76e5f77ee90c3c2) Refactor page correctly - [`fa5d2f8`](https://github.com/immich-app/immich/commit/fa5d2f8f4c47a4e08df19988e32e3a5ed3324483) Refactor endpoints - [`b31b321`](https://github.com/immich-app/immich/commit/b31b32199edaf4a595a3c3cddbb229d385554c95) Testing endpoints redirection - [`ea4d53a`](https://github.com/immich-app/immich/commit/ea4d53afab7ccd37505cc1e23e305bc728968a5e) Remove deadcode - [`bfa369d`](https://github.com/immich-app/immich/commit/bfa369d40059c9fdf2dee010a26676e4f3481879) Add check for validation - [`b6eba62`](https://github.com/immich-app/immich/commit/b6eba623400ce8ababe67c48c6ab3de5d8e14b14) Test /photo/assetId - [`190db3d`](https://github.com/immich-app/immich/commit/190db3dceb5341a143a256a088f9988f422f2c94) test /admin - [`eb1b4f9`](https://github.com/immich-app/immich/commit/eb1b4f9ecd363b62c026c42cd8996407cea12679) test /albums /albums/albumId album/albumId/photos/assetId - [`2b34842`](https://github.com/immich-app/immich/commit/2b3484294a4abac4f3d4524cdab4499e91a95cb2) refactor sharing page ### 📊 Changes **47 files changed** (+1511 additions, -1218 deletions) <details> <summary>View changed files</summary> 📝 `docker/docker-compose.dev.yml` (+3 -0) 📝 `server/Dockerfile` (+2 -2) 📝 `web/package-lock.json` (+1016 -538) 📝 `web/package.json` (+0 -1) 📝 `web/src/app.d.ts` (+0 -6) 📝 `web/src/hooks.ts` (+2 -28) 📝 `web/src/lib/components/album-page/album-card.svelte` (+1 -1) 📝 `web/src/lib/components/shared-components/upload-panel.svelte` (+0 -1) ➕ `web/src/routes/+error.svelte` (+29 -0) ➕ `web/src/routes/+layout.server.ts` (+23 -0) 📝 `web/src/routes/+layout.svelte` (+3 -13) ➕ `web/src/routes/+page.svelte` (+29 -0) ➕ `web/src/routes/+page.ts` (+21 -0) ➕ `web/src/routes/admin/+page.server.ts` (+19 -0) 📝 `web/src/routes/admin/+page.svelte` (+12 -55) ➕ `web/src/routes/albums/+page.server.ts` (+22 -0) 📝 `web/src/routes/albums/+page.svelte` (+17 -56) ➕ `web/src/routes/albums/[albumId]/+page.server.ts` (+23 -0) ➕ `web/src/routes/albums/[albumId]/+page.svelte` (+14 -0) ➖ `web/src/routes/albums/[albumId]/index.svelte` (+0 -57) _...and 27 more files_ </details> ### 📄 Description * Migrate to the new convention for the route's file name * Refactor new API ## References 1 - Migration Guide - https://github.com/sveltejs/kit/discussions/5774#discussioncomment-3292707 2 - Removing Session - https://github.com/sveltejs/kit/discussions/5883 ## Behavior tests ### Photos route - [x] When not logged in, entering `/photos` will be redirected to `/auth/login` - [x] When logged in, entering `/photos/[assetId]` will redirected to `/photos` (since the photo viewer is not a route but an overlay on top on `photos` page) - [x] When not logged in, entering `/photos/[assetId]` will redirected to `/auth/login` ### Sharing route - [x] When not logged in, entering `/sharing` will be redirected to `/auth/login` ### Albums route - [x] When not logged in, entering `/albums` will be redirected to `/auth/login` ### Admin route - [x] When not logged in, entering `/admin` will be redirected to `/auth/login` - [x] When logged in but the user is not admin, entering `/admin` will be redirected to `/photos` ### Auth routes - [x] Register admin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:51:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?