[PR #205] [MERGED] Minor improvements to the detail-panel component #8510

Closed
opened 2026-02-05 13:48:32 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/205
Author: @matthinc
Created: 6/6/2022
Status: Merged
Merged: 6/7/2022
Merged by: @alextran1502

Base: mainHead: main


📝 Commits (3)

  • fb2d0b9 Fix roudning behavior in details panel
  • fb170fb Add lat,lon-popup to map in details
  • a350623 Refactor map code in detail-panel to avoid duplicate code

📊 Changes

1 file changed (+24 additions, -14 deletions)

View changed files

📝 web/src/lib/components/asset-viewer/detail-panel.svelte (+24 -14)

📄 Description

This PR contains three improvements of the details-panel component:

  • Floor the exposure time as the current implementation can result in very long numbers (see attached image)
  • Add a popup to the map-marker that shows the location in the lat,lon format (useful e.g. to copy the location to google maps)
  • Refactor some duplicated map-related code to a separate function

immich01


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/205 **Author:** [@matthinc](https://github.com/matthinc) **Created:** 6/6/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`fb2d0b9`](https://github.com/immich-app/immich/commit/fb2d0b9ace2708cec537eb67a05b63bb1fabe821) Fix roudning behavior in details panel - [`fb170fb`](https://github.com/immich-app/immich/commit/fb170fb5f0f226bc982b5dcf1369d8ccf9d7c38e) Add lat,lon-popup to map in details - [`a350623`](https://github.com/immich-app/immich/commit/a350623633cffd97806745acfc381123c6fbd76b) Refactor map code in detail-panel to avoid duplicate code ### 📊 Changes **1 file changed** (+24 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/asset-viewer/detail-panel.svelte` (+24 -14) </details> ### 📄 Description This PR contains three improvements of the details-panel component: - Floor the exposure time as the current implementation can result in very long numbers (see attached image) - Add a popup to the map-marker that shows the location in the lat,lon format (useful e.g. to copy the location to google maps) - Refactor some duplicated map-related code to a separate function ![immich01](https://user-images.githubusercontent.com/6898797/172235195-838ceb4b-3883-44e0-856d-324dd149f8ae.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:48:32 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8510