immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 9 Packages Projects Releases 10 Wiki Activity

[Feature]: Support for redis sentinel #205

New Issue
Closed
opened 2026-02-04 18:43:39 +03:00 by OVERLORD · 6 comments
OVERLORD commented 2026-02-04 18:43:39 +03:00
Owner
Copy Link

Originally created by @onedr0p on GitHub (Aug 16, 2022).

Feature detail

Hi 👋🏼

It would be great if immich could connect to a highly available redis instance.

Here's a couple examples of applications that support this method of redis.

Thanks!

Platform

Server

Originally created by @onedr0p on GitHub (Aug 16, 2022). ### Feature detail Hi 👋🏼 It would be great if immich could connect to a highly available redis instance. Here's a couple examples of applications that support this method of redis. - https://www.authelia.com/configuration/session/redis/ - https://github.com/outline/outline/blob/93bb9d067d0f61a2f5d6f1d302774b128095a4d0/.env.sample#L22L29 Thanks! ### Platform Server
OVERLORD commented 2026-02-04 18:43:49 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Aug 16, 2022):

Hello,

Thank you for opening the issue. This will be left to the user to implement because it is very specific to a user group

@alextran1502 commented on GitHub (Aug 16, 2022): Hello, Thank you for opening the issue. This will be left to the user to implement because it is very specific to a user group
OVERLORD commented 2026-02-04 18:43:58 +03:00
Author
Owner
Copy Link

@onedr0p commented on GitHub (Nov 13, 2022):

@alextran1502

To be able to implement sentinel support, there would have to be a switch from node-redis to ioredis, since node-redis doesn't have sentinel support https://github.com/redis/node-redis/issues/302 :/

Would you accept PRs on this change?

@onedr0p commented on GitHub (Nov 13, 2022): @alextran1502 To be able to implement sentinel support, there would have to be a switch from node-redis to [ioredis](https://github.com/luin/ioredis), since node-redis doesn't have sentinel support https://github.com/redis/node-redis/issues/302 :/ Would you accept PRs on this change?
OVERLORD commented 2026-02-04 18:44:12 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Nov 13, 2022):

You can try but I think there might be dependencies that depends on node-redis, like the socket-io implementation

@alextran1502 commented on GitHub (Nov 13, 2022): You can try but I think there might be dependencies that depends on node-redis, like the socket-io implementation
OVERLORD commented 2026-02-04 18:44:20 +03:00
Author
Owner
Copy Link

@onedr0p commented on GitHub (Nov 13, 2022):

Actually it looks like Bull passes the RedisOpts directly to ioredis, not sure why the redis lib is in the packages.json

https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#queue

Since with Redis Sentinel would require multiple hosts passthru to the application, do you think the way Outline made it configurable is a decent decision for implentation?

https://github.com/luin/ioredis#sentinel

@onedr0p commented on GitHub (Nov 13, 2022): Actually it looks like Bull passes the `RedisOpts` directly to ioredis, not sure why the `redis` lib is in the `packages.json` https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#queue Since with Redis Sentinel would require multiple hosts passthru to the application, do you think the way Outline made it [configurable](https://github.com/outline/outline/blob/93bb9d067d0f61a2f5d6f1d302774b128095a4d0/.env.sample#L22L29) is a decent decision for implentation? https://github.com/luin/ioredis#sentinel
OVERLORD commented 2026-02-04 18:44:28 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Nov 14, 2022):

Here is the reason we have Redis in the dependency https://docs.nestjs.com/websockets/adapter

@alextran1502 commented on GitHub (Nov 14, 2022): Here is the reason we have Redis in the dependency https://docs.nestjs.com/websockets/adapter
OVERLORD commented 2026-02-04 18:44:34 +03:00
Author
Owner
Copy Link

@samip5 commented on GitHub (Mar 31, 2023):

@alextran1502 Could you re-open this so it would get closed when the support is implemented from the PR?

@samip5 commented on GitHub (Mar 31, 2023): @alextran1502 Could you re-open this so it would get closed when the support is implemented from the PR?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#205
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?