immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Inconsistent availability of "add to album" for shared assets #4089

New Issue
Closed
opened 2026-02-05 09:43:13 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2026-02-05 09:43:13 +03:00
Owner
Copy Link

Originally created by @C-Otto on GitHub (Aug 16, 2024).

The bug

I can add assets shared with me to albums, but not all of the known options to do so are available.
For this, I assume that my partner shares everything with me, and that I configured my timeline to include those shared assets.

  1. Click on asset in timeline -> three dots -> Add to album: option is only shown for owned assets
  2. Select asset(s) in timeline (checkmark in upper left corner) -> click "+" in upper right corner -> Add to album: works for both owned and unowned assets
  3. Navigate to album -> Add photos (upper right): only shows owned assets in timeline (even though the regular timeline also shows unowned assets)
  4. Sharing -> click on partner in "Partners" -> click on asset: same as 1.
  5. Sharing -> click on partner in "Partners" -> select assets: same as 2.

As I'm able to add unowned assets to my albums via some of those options, I expect the other options to work, too.

The OS that Immich Server is running on

Debian Stable

Version of Immich Server

v1.112.1

Platform with the issue

  • Server
  • Web
  • Mobile
Originally created by @C-Otto on GitHub (Aug 16, 2024). ### The bug I can add assets shared with me to albums, but not all of the known options to do so are available. For this, I assume that my partner shares everything with me, and that I configured my timeline to include those shared assets. 1. Click on asset in timeline -> three dots -> Add to album: option is only shown for owned assets 2. Select asset(s) in timeline (checkmark in upper left corner) -> click "+" in upper right corner -> Add to album: works for both owned and unowned assets 3. Navigate to album -> Add photos (upper right): only shows owned assets in timeline (even though the regular timeline also shows unowned assets) 4. Sharing -> click on partner in "Partners" -> click on asset: same as 1. 5. Sharing -> click on partner in "Partners" -> select assets: same as 2. As I'm able to add unowned assets to my albums via some of those options, I expect the other options to work, too. ### The OS that Immich Server is running on Debian Stable ### Version of Immich Server v1.112.1 ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile
OVERLORD added the 🖥️websharing labels 2026-02-05 09:43:13 +03:00
OVERLORD commented 2026-02-05 09:43:17 +03:00
Author
Owner
Copy Link

@C-Otto commented on GitHub (Aug 16, 2024):

According to the server's permission checks, I am allowed to add an asset to an album if:

  • I own the album or the album is shared with me via the EDITOR role, and
  • I own the asset or it is shared with me via the "partner" mechanism

As such, I believe all assets shown in my timeline should also show the "add to album" option.

Furthermore, the assets shown for 3. (from album via "Add photos") should include show the full timeline (including my partners' assets). This might be a different issue, though.

@C-Otto commented on GitHub (Aug 16, 2024): According to the server's permission checks, I am allowed to add an asset to an album if: - I own the album or the album is shared with me via the EDITOR role, and - I own the asset or it is shared with me via the "partner" mechanism As such, I believe all assets shown in my timeline should also show the "add to album" option. Furthermore, the assets shown for 3. (from album via "Add photos") should include show the full timeline (including my partners' assets). This might be a different issue, though.
OVERLORD commented 2026-02-05 09:43:20 +03:00
Author
Owner
Copy Link

@ahayzen commented on GitHub (Aug 20, 2024):

Is this related or a duplicate of #6486 ?

@ahayzen commented on GitHub (Aug 20, 2024): Is this related or a duplicate of #6486 ?
OVERLORD commented 2026-02-05 09:43:23 +03:00
Author
Owner
Copy Link

@C-Otto commented on GitHub (Aug 20, 2024):

Related. That ticket only covers 3. of my list, I think.

@C-Otto commented on GitHub (Aug 20, 2024): Related. That ticket only covers 3. of my list, I think.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label sharing 🖥️web
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#4089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?