immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4089] [MERGED] feat(web): swap between people when merging faces #10239

New Issue
Closed
opened 2026-02-05 14:18:19 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:18:19 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4089
Author: @martabal
Created: 9/14/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @jrasm91

Base: main ← Head: feat/swap-when-mergin-people

📝 Commits (4)

  • 8112024 feat: swap between people when merging faces
  • e97e0ff rename
  • 8a1974c fix: remove url parameter when closing
  • cb17c8d chore: handler naming

📊 Changes

2 files changed (+83 additions, -49 deletions)

View changed files

📝 web/src/lib/components/faces-page/merge-face-selector.svelte (+19 -4)
📝 web/src/routes/(user)/people/[personId]/+page.svelte (+64 -45)

📄 Description

Changes made in this PR

This PR adds the ability to swap between people when merging faces. You can swap between people only when one face is selected.

Found the same bug mentioned in #3823 and using the same workaround.

Screenshots

https://github.com/immich-app/immich/assets/74269598/6dd3905d-665e-4ea3-af7c-c1419f8e53f1

Edit: Now, when the merge modal is closed, the action URL parameter is removed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4089 **Author:** [@martabal](https://github.com/martabal) **Created:** 9/14/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `feat/swap-when-mergin-people` --- ### 📝 Commits (4) - [`8112024`](https://github.com/immich-app/immich/commit/8112024554e0ab146da6627b26844de752d803ad) feat: swap between people when merging faces - [`e97e0ff`](https://github.com/immich-app/immich/commit/e97e0ff5105096df50058cb5e523c5dd02e03667) rename - [`8a1974c`](https://github.com/immich-app/immich/commit/8a1974c414fb16a40e775a575cf8a54d68a859b6) fix: remove url parameter when closing - [`cb17c8d`](https://github.com/immich-app/immich/commit/cb17c8df015828e468d9809bf15fa688dd293922) chore: handler naming ### 📊 Changes **2 files changed** (+83 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/faces-page/merge-face-selector.svelte` (+19 -4) 📝 `web/src/routes/(user)/people/[personId]/+page.svelte` (+64 -45) </details> ### 📄 Description ## Changes made in this PR This PR adds the ability to swap between people when merging faces. You can swap between people only when one face is selected. Found the same bug mentioned in #3823 and using the same workaround. ## Screenshots https://github.com/immich-app/immich/assets/74269598/6dd3905d-665e-4ea3-af7c-c1419f8e53f1 Edit: Now, when the merge modal is closed, the `action` URL parameter is removed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:18:19 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?