immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #18070] fix: Fix marking items as "not a duplicate". #15554

New Issue
Closed
opened 2026-02-05 15:50:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 15:50:44 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/18070

State: closed
Merged: No

The problem arose because null == undefined in JS. The other caparisons in this block should probably use !== as well (and === should be the general default because it is more predictable) but they are technically fine because no valid values will == undefined. So I have left them for now.

I am not sure if this is the best fix, but it does appear to solve the problem.

All credit goes to https://github.com/zzzorgo. I just converted it into a patch.

Fixes: https://github.com/immich-app/immich/issues/16413

Description

How Has This Been Tested?

  • Mark a candidate duplicate as not a duplicate. Then reload and see if it reappears.

API Changes

The /api/assets endpoint will now clear the duplicateId field if the request body contains duplicateId: null.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)
**Original Pull Request:** https://github.com/immich-app/immich/pull/18070 **State:** closed **Merged:** No --- The problem arose because `null == undefined` in JS. The other caparisons in this block should probably use `!==` as well (and `===` should be the general default because it is more predictable) but they are technically fine because no valid values will `== undefined`. So I have left them for now. I am not sure if this is the best fix, but it does appear to solve the problem. All credit goes to https://github.com/zzzorgo. I just converted it into a patch. Fixes: https://github.com/immich-app/immich/issues/16413 ## Description ## How Has This Been Tested? - [ ] Mark a candidate duplicate as not a duplicate. Then reload and see if it reappears. ## API Changes The `/api/assets` endpoint will now clear the `duplicateId` field if the request body contains `duplicateId: null`. ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
OVERLORD added the pull-request label 2026-02-05 15:50:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#15554
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?