immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #25088] fix(mobile): timeline handling on foldable phones + ensuring that images are not cut off #18070

New Issue
Open
opened 2026-02-05 16:32:09 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:32:09 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25088
Author: @bkchr
Created: 1/6/2026
Status: 🔄 Open

Base: main ← Head: bkchr-timeline-fixes

📝 Commits (1)

  • 2b82d15 [mobile]: Fix timeline handling on foldable phones + ensuring that images are not cut off

📊 Changes

2 files changed (+173 additions, -48 deletions)

View changed files

📝 mobile/lib/presentation/widgets/timeline/timeline.state.dart (+20 -0)
📝 mobile/lib/presentation/widgets/timeline/timeline.widget.dart (+153 -48)

📄 Description

This fixes the handling of unfolding the phone while having the application opened. So, the timeline is correctly rescaled and the current position is kept. Besides that it fixes a bug with the ordering which lead to images being "cut off" at the right side of the screen.

Description

Fixes # (issue)

How Has This Been Tested?

I tested this on my Z Fold7. Folding/Unfolding it. Checking that I can do pinch to zoom.

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Claude was used to generate this pull request.

Fixes: #22540
Fixes: https://github.com/immich-app/immich/issues/20466

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25088 **Author:** [@bkchr](https://github.com/bkchr) **Created:** 1/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `bkchr-timeline-fixes` --- ### 📝 Commits (1) - [`2b82d15`](https://github.com/immich-app/immich/commit/2b82d154810c5855b05caa081fd308483a86a8b9) [mobile]: Fix timeline handling on foldable phones + ensuring that images are not cut off ### 📊 Changes **2 files changed** (+173 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/presentation/widgets/timeline/timeline.state.dart` (+20 -0) 📝 `mobile/lib/presentation/widgets/timeline/timeline.widget.dart` (+153 -48) </details> ### 📄 Description This fixes the handling of unfolding the phone while having the application opened. So, the timeline is correctly rescaled and the current position is kept. Besides that it fixes a bug with the ordering which lead to images being "cut off" at the right side of the screen. ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes # (issue) ## How Has This Been Tested? I tested this on my Z Fold7. Folding/Unfolding it. Checking that I can do pinch to zoom. <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [x] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. Claude was used to generate this pull request. Fixes: #22540 Fixes: https://github.com/immich-app/immich/issues/20466 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:32:09 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18070
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?