immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #7403] [MERGED] fix(web): re-render albums #11614

New Issue
Closed
opened 2026-02-05 14:42:48 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:42:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/7403
Author: @martabal
Created: 2/25/2024
Status: ✅ Merged
Merged: 2/29/2024
Merged by: @alextran1502

Base: main ← Head: fix/re-render-albums

📝 Commits (10+)

📊 Changes

4 files changed (+205 additions, -175 deletions)

View changed files

➕ web/src/lib/components/album-page/album-description.svelte (+45 -0)
➕ web/src/lib/components/album-page/album-title.svelte (+42 -0)
📝 web/src/lib/components/shared-components/settings/setting-switch.svelte (+2 -2)
📝 web/src/routes/(user)/albums/[albumId]/+page.svelte (+116 -173)

📄 Description

What's changed

This PR fixes 2 issues:

  • Currently, when navigating from one album to another with the "Appears in" section in the detail-panel, the album infos and the timeline are not re-rendered. That's an issue we experienced with the people/[personId] route and this PR adds the same hacky solution to force re-rendering everything.
  • the toggle event for the setting-switch / slider components

Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/7403 **Author:** [@martabal](https://github.com/martabal) **Created:** 2/25/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/re-render-albums` --- ### 📝 Commits (10+) - [`5237a69`](https://github.com/immich-app/immich/commit/5237a69a4b2ed3bf70fd6b13efd382271f8adbbf) fix: re-render albums - [`42b3b77`](https://github.com/immich-app/immich/commit/42b3b77a79ae84180e92a421dfb672e88bdc2a58) fix: album description - [`084b678`](https://github.com/immich-app/immich/commit/084b6782f7e1bd8bd1b69613b9c0023789dce50a) fix: reactivity - [`4c5d46c`](https://github.com/immich-app/immich/commit/4c5d46c5f61359da70813274e5a123a9584de59b) fix album reactivity + components for title and description - [`0fdbfcb`](https://github.com/immich-app/immich/commit/0fdbfcb4f8047b86c933dd1c04c35d1c0497bc64) only update AssetGrid when albumId changes - [`a73fd2f`](https://github.com/immich-app/immich/commit/a73fd2f9b8cd36e266951bca6141b2587a274eae) remove title and description bindings - [`494f994`](https://github.com/immich-app/immich/commit/494f994a832a3f22d84d084fceda733be0e740c2) remove console.log - [`891c0f4`](https://github.com/immich-app/immich/commit/891c0f4d17c983de51f284dcb9ceecbc4840ca5e) merge main - [`bd45670`](https://github.com/immich-app/immich/commit/bd4567043aa1341011fa867d721444175ecfa73f) chore: fix merge - [`4d0e0df`](https://github.com/immich-app/immich/commit/4d0e0df0c9887b93e1525fff795c12f14463e62d) pr feedback ### 📊 Changes **4 files changed** (+205 additions, -175 deletions) <details> <summary>View changed files</summary> ➕ `web/src/lib/components/album-page/album-description.svelte` (+45 -0) ➕ `web/src/lib/components/album-page/album-title.svelte` (+42 -0) 📝 `web/src/lib/components/shared-components/settings/setting-switch.svelte` (+2 -2) 📝 `web/src/routes/(user)/albums/[albumId]/+page.svelte` (+116 -173) </details> ### 📄 Description ## What's changed This PR fixes 2 issues: - Currently, when navigating from one album to another with the "Appears in" section in the detail-panel, the album infos and the timeline are not re-rendered. That's an issue we experienced with the `people/[personId]` route and this PR adds the same hacky solution to force re-rendering everything. - the toggle event for the setting-switch / slider components ## Screenshots | Before | After | | :----: | :---: | | <video src="https://github.com/immich-app/immich/assets/74269598/e03c9e2b-1c01-41f0-b148-82c65ca6385e"> | <video src="https://github.com/immich-app/immich/assets/74269598/fb695df9-dba9-4b1c-b470-c93bb6801f41"> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:42:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?