immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #6476] [MERGED] fix(mobile): asset state when delete from trash #11201

New Issue
Closed
opened 2026-02-05 14:35:14 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:35:14 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/6476
Author: @shenlong-tanwen
Created: 1/18/2024
Status: ✅ Merged
Merged: 1/18/2024
Merged by: @alextran1502

Base: main ← Head: fix/mobile-empty-trash

📝 Commits (2)

  • 963b736 fix(mobile): handle asset removal state from trash for merged assets
  • edc7df1 fix(mobile): use appropriate text for trash / delete

📊 Changes

4 files changed (+47 additions, -14 deletions)

View changed files

📝 mobile/assets/i18n/en-US.json (+2 -1)
📝 mobile/lib/modules/home/ui/control_bottom_app_bar.dart (+3 -1)
📝 mobile/lib/modules/trash/providers/trashed_asset.provider.dart (+28 -0)
📝 mobile/lib/modules/trash/views/trash_page.dart (+14 -12)

📄 Description

Changes made:

  • The current delete from trash handling prompts the user for removing the asset from the local device as well and on accepting, the asset is removed from everywhere. This might be confusing to the users since deleting assets from trash, removes only the remote part and leaves the local asset untouched. This PR updates the mobile app to use the same handling where emptying or removing an asset from the trash will only remove the remote part and leave the local asset in place and display in back in the timeline with a crossed cloud icon
  • "Delete from Immich" text in the bottom app bar is also updated to display either "Move to Trash" or "Delete from Immich" based on whether trash is enabled or not

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/6476 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 1/18/2024 **Status:** ✅ Merged **Merged:** 1/18/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/mobile-empty-trash` --- ### 📝 Commits (2) - [`963b736`](https://github.com/immich-app/immich/commit/963b7369aed2fbd66573d975ccfc3b5b5728e7aa) fix(mobile): handle asset removal state from trash for merged assets - [`edc7df1`](https://github.com/immich-app/immich/commit/edc7df19131ce8b80e8bf8c1340f39be6cdeacd4) fix(mobile): use appropriate text for trash / delete ### 📊 Changes **4 files changed** (+47 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `mobile/assets/i18n/en-US.json` (+2 -1) 📝 `mobile/lib/modules/home/ui/control_bottom_app_bar.dart` (+3 -1) 📝 `mobile/lib/modules/trash/providers/trashed_asset.provider.dart` (+28 -0) 📝 `mobile/lib/modules/trash/views/trash_page.dart` (+14 -12) </details> ### 📄 Description #### Changes made: - The current delete from trash handling prompts the user for removing the asset from the local device as well and on accepting, the asset is removed from everywhere. This might be confusing to the users since deleting assets from trash, removes only the remote part and leaves the local asset untouched. This PR updates the mobile app to use the same handling where emptying or removing an asset from the trash will only remove the remote part and leave the local asset in place and display in back in the timeline with a crossed cloud icon - "Delete from Immich" text in the bottom app bar is also updated to display either "Move to Trash" or "Delete from Immich" based on whether trash is enabled or not --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:35:14 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?