immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4699] [MERGED] fix(mobile): cache key for assets from dto #10490

New Issue
Closed
opened 2026-02-05 14:22:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4699
Author: @shenlong-tanwen
Created: 10/29/2023
Status: ✅ Merged
Merged: 10/29/2023
Merged by: @alextran1502

Base: main ← Head: fix/cache-key-asset-from-dto

📝 Commits (1)

  • e0fa667 fix(mobile): cache key for assets from dto

📊 Changes

3 files changed (+13 additions, -8 deletions)

View changed files

📝 mobile/lib/modules/asset_viewer/views/gallery_viewer.dart (+3 -3)
📝 mobile/lib/modules/home/ui/asset_grid/thumbnail_image.dart (+2 -2)
📝 mobile/lib/utils/image_url_builder.dart (+8 -3)

📄 Description

Fixes #4614 , #4446

Issue:

  • Same as the unique hero tag issue from #4600, the assets from the response dto do not have isar id set. Using the isar id for caching resulted in the cache returning the first opened image because of the same cache key

Change made in the PR:

  • remoteId is used instead of isar id as the cache key for the assets from renderlist created directly from the response dto

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4699 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/cache-key-asset-from-dto` --- ### 📝 Commits (1) - [`e0fa667`](https://github.com/immich-app/immich/commit/e0fa66792caa6b6336b075b34cb9ebccd54d38d7) fix(mobile): cache key for assets from dto ### 📊 Changes **3 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/asset_viewer/views/gallery_viewer.dart` (+3 -3) 📝 `mobile/lib/modules/home/ui/asset_grid/thumbnail_image.dart` (+2 -2) 📝 `mobile/lib/utils/image_url_builder.dart` (+8 -3) </details> ### 📄 Description Fixes #4614 , #4446 #### Issue: - Same as the unique hero tag issue from #4600, the assets from the response dto do not have isar id set. Using the isar id for caching resulted in the cache returning the first opened image because of the same cache key #### Change made in the PR: - `remoteId` is used instead of isar id as the cache key for the assets from renderlist created directly from the response dto --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?