immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4633] [MERGED] fix(web): fix Theme Custom CSS endpoint requiring the user to be logged in as the server admin #10456

New Issue
Closed
opened 2026-02-05 14:22:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4633
Author: @Wingysam
Created: 10/25/2023
Status: ✅ Merged
Merged: 10/26/2023
Merged by: @jrasm91

Base: main ← Head: main

📝 Commits (3)

  • d2a4821 fix custom css requiring the user to be the admin and logged in
  • 4cbbf16 move theme api to custom endpoint
  • d4f1c03 add e2e test

📊 Changes

20 files changed (+448 additions, -1 deletions)

View changed files

📝 cli/src/api/open-api/api.ts (+69 -0)
📝 mobile/openapi/.openapi-generator/FILES (+3 -0)
📝 mobile/openapi/README.md (+2 -0)
📝 mobile/openapi/doc/ServerInfoApi.md (+38 -0)
➕ mobile/openapi/doc/ServerThemeDto.md (+15 -0)
📝 mobile/openapi/lib/api.dart (+1 -0)
📝 mobile/openapi/lib/api/server_info_api.dart (+41 -0)
📝 mobile/openapi/lib/api_client.dart (+2 -0)
➕ mobile/openapi/lib/model/server_theme_dto.dart (+98 -0)
📝 mobile/openapi/test/server_info_api_test.dart (+5 -0)
➕ mobile/openapi/test/server_theme_dto_test.dart (+27 -0)
📝 server/immich-openapi-specs.json (+32 -0)
📝 server/src/domain/server-info/server-info.dto.ts (+5 -0)
📝 server/src/domain/server-info/server-info.service.ts (+5 -0)
📝 server/src/domain/system-config/system-config.service.spec.ts (+6 -0)
📝 server/src/domain/system-config/system-config.service.ts (+6 -0)
📝 server/src/immich/controllers/server-info.controller.ts (+7 -0)
📝 server/test/e2e/server-info.e2e-spec.ts (+12 -0)
📝 web/src/api/open-api/api.ts (+69 -0)
📝 web/src/routes/custom.css/+server.ts (+5 -1)

📄 Description

My original implementation of Custom CSS has this bug: #4631. This PR resolves that issue.

fixes #4631

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4633 **Author:** [@Wingysam](https://github.com/Wingysam) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 10/26/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`d2a4821`](https://github.com/immich-app/immich/commit/d2a4821824563d066f5798c5691e0c245cbb8f7e) fix custom css requiring the user to be the admin and logged in - [`4cbbf16`](https://github.com/immich-app/immich/commit/4cbbf16792d8ddac8e354d8ba8b1b3adaf53da97) move theme api to custom endpoint - [`d4f1c03`](https://github.com/immich-app/immich/commit/d4f1c03dc644f2b0729cd77564e2bb93d79e5448) add e2e test ### 📊 Changes **20 files changed** (+448 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cli/src/api/open-api/api.ts` (+69 -0) 📝 `mobile/openapi/.openapi-generator/FILES` (+3 -0) 📝 `mobile/openapi/README.md` (+2 -0) 📝 `mobile/openapi/doc/ServerInfoApi.md` (+38 -0) ➕ `mobile/openapi/doc/ServerThemeDto.md` (+15 -0) 📝 `mobile/openapi/lib/api.dart` (+1 -0) 📝 `mobile/openapi/lib/api/server_info_api.dart` (+41 -0) 📝 `mobile/openapi/lib/api_client.dart` (+2 -0) ➕ `mobile/openapi/lib/model/server_theme_dto.dart` (+98 -0) 📝 `mobile/openapi/test/server_info_api_test.dart` (+5 -0) ➕ `mobile/openapi/test/server_theme_dto_test.dart` (+27 -0) 📝 `server/immich-openapi-specs.json` (+32 -0) 📝 `server/src/domain/server-info/server-info.dto.ts` (+5 -0) 📝 `server/src/domain/server-info/server-info.service.ts` (+5 -0) 📝 `server/src/domain/system-config/system-config.service.spec.ts` (+6 -0) 📝 `server/src/domain/system-config/system-config.service.ts` (+6 -0) 📝 `server/src/immich/controllers/server-info.controller.ts` (+7 -0) 📝 `server/test/e2e/server-info.e2e-spec.ts` (+12 -0) 📝 `web/src/api/open-api/api.ts` (+69 -0) 📝 `web/src/routes/custom.css/+server.ts` (+5 -1) </details> ### 📄 Description My original implementation of Custom CSS has this bug: #4631. This PR resolves that issue. fixes #4631 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10456
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?