immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4589] [MERGED] fix(mobile): handle non-standard exposure time string #10430

New Issue
Closed
opened 2026-02-05 14:21:48 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:21:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4589
Author: @shenlong-tanwen
Created: 10/22/2023
Status: ✅ Merged
Merged: 10/31/2023
Merged by: @alextran1502

Base: main ← Head: fix/mobile-exposure-time

📝 Commits (1)

  • bfce9b6 fix(mobile): store exposure time as string

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 mobile/lib/shared/models/exif_info.dart (+5 -2)

📄 Description

Fixes #4376

Changes made in the PR:

  • Non standard exposureTime values used to throw exceptions during parsing resulting in sync failures. All the double conversions are made optional and exposureTime is calculated only when we receive a valid string else set to empty to prevent sync failures

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4589 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/31/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/mobile-exposure-time` --- ### 📝 Commits (1) - [`bfce9b6`](https://github.com/immich-app/immich/commit/bfce9b65a03304b6735cb28164612ef81fcbba0c) fix(mobile): store exposure time as string ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/shared/models/exif_info.dart` (+5 -2) </details> ### 📄 Description Fixes #4376 #### Changes made in the PR: - Non standard `exposureTime` values used to throw exceptions during parsing resulting in sync failures. All the double conversions are made optional and exposureTime is calculated only when we receive a valid string else set to empty to prevent sync failures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:21:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?