immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4501] [MERGED] fix(mobile): reset trashed state for local assets on deletion #10402

New Issue
Closed
opened 2026-02-05 14:21:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:21:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4501
Author: @shenlong-tanwen
Created: 10/16/2023
Status: ✅ Merged
Merged: 10/16/2023
Merged by: @alextran1502

Base: main ← Head: fix/trash-local-asset

📝 Commits (1)

  • 4960e0d fix(mobile): reset trashed state for local assets on remote asset deletion

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 mobile/lib/shared/services/sync.service.dart (+1 -0)

📄 Description

Changes made in the PR

  • Merged assets state were not reverted properly when the remote asset is deleted in the server. Due to this, if an asset is trashed previously and is permanently removed from the server, the local asset in the mobile app still will not get displayed in the main timeline

How was this tested

  • Trashed an asset and permanently removed it from the web client and ensure that the state is changed to local and the asset is displayed in the main timeline

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4501 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 10/16/2023 **Status:** ✅ Merged **Merged:** 10/16/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/trash-local-asset` --- ### 📝 Commits (1) - [`4960e0d`](https://github.com/immich-app/immich/commit/4960e0d9075841f282c60f44397598ca030769a0) fix(mobile): reset trashed state for local assets on remote asset deletion ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/shared/services/sync.service.dart` (+1 -0) </details> ### 📄 Description #### Changes made in the PR - Merged assets state were not reverted properly when the remote asset is deleted in the server. Due to this, if an asset is trashed previously and is permanently removed from the server, the local asset in the mobile app still will not get displayed in the main timeline #### How was this tested - Trashed an asset and permanently removed it from the web client and ensure that the state is changed to local and the asset is displayed in the main timeline --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:21:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?