immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4378] [MERGED] feat(web): ws - on_config_update #10344

New Issue
Closed
opened 2026-02-05 14:20:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:20:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4378
Author: @shenlong-tanwen
Created: 10/7/2023
Status: ✅ Merged
Merged: 10/7/2023
Merged by: @alextran1502

Base: main ← Head: feat/web-ws-config

📝 Commits (1)

  • 4526041 feat(web): ws - on_config_update

📊 Changes

3 files changed (+2 additions, -8 deletions)

View changed files

📝 web/src/lib/components/admin-page/settings/map-settings/map-settings.svelte (+0 -4)
📝 web/src/lib/components/admin-page/settings/trash-settings/trash-settings.svelte (+0 -4)
📝 web/src/lib/stores/websocket.ts (+2 -0)

📄 Description

Changes made in this PR

  • Handle CONFIG_UPDATE - on_config_update from websocket to reload System Config updates in web
  • Removed the temporary config reload workaround added in #4015

How was this tested

  • Enable / Disable trash and check if it is immediately updated in the sidebar
  • Update map tile URL and check if the map URL is immediately updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4378 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 10/7/2023 **Status:** ✅ Merged **Merged:** 10/7/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/web-ws-config` --- ### 📝 Commits (1) - [`4526041`](https://github.com/immich-app/immich/commit/45260412756994e96bba5b46863ad4678ffaabee) feat(web): ws - on_config_update ### 📊 Changes **3 files changed** (+2 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/admin-page/settings/map-settings/map-settings.svelte` (+0 -4) 📝 `web/src/lib/components/admin-page/settings/trash-settings/trash-settings.svelte` (+0 -4) 📝 `web/src/lib/stores/websocket.ts` (+2 -0) </details> ### 📄 Description #### Changes made in this PR - Handle `CONFIG_UPDATE` - `on_config_update` from websocket to reload System Config updates in web - Removed the temporary config reload workaround added in #4015 #### How was this tested - Enable / Disable trash and check if it is immediately updated in the sidebar - Update map tile URL and check if the map URL is immediately updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:20:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?