immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3916] [MERGED] fix(ml): minScore not being set correctly #10160

New Issue
Closed
opened 2026-02-05 14:16:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:16:58 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3916
Author: @mertalev
Created: 8/30/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @alextran1502

Base: main ← Head: fix/ml-model-options

📝 Commits (5)

📊 Changes

3 files changed (+8 additions, -5 deletions)

View changed files

📝 machine-learning/app/models/facial_recognition.py (+2 -2)
📝 machine-learning/app/models/image_classification.py (+2 -2)
📝 server/src/infra/repositories/machine-learning.repository.ts (+4 -1)

📄 Description

Description

This is a hot-fix in two respects: fixing the image classification model erroring if the model is not downloaded, and correctly setting the minScore config in image classification and facial recognition. If the model is not already downloaded and exported to ONNX, the pipeline function used for the first load validates the kwargs passed while the other code path does not. Additionally, the options sent are in camelCase while the check is currently for snake_case.

Fixes #3915

How Has This Been Tested?

I deleted the image classification model from the cache, restarted the containers and confirmed that each job runs without errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3916 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 8/30/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/ml-model-options` --- ### 📝 Commits (5) - [`3aa38b9`](https://github.com/immich-app/immich/commit/3aa38b9c9c222a2b1cafc2e25c048ef4cc773a2e) fixed `minScore` not being set correctly - [`106fe2d`](https://github.com/immich-app/immich/commit/106fe2dec52480d69274c699f06abe8c74a0a7b0) apply to init - [`7c3e96a`](https://github.com/immich-app/immich/commit/7c3e96a0cd52a3b7001c4321ec1ab317af64f614) don't send `enabled` - [`912b4b1`](https://github.com/immich-app/immich/commit/912b4b11cd0560ff5bcd70afcce0878f1c404c22) fix eslint warning - [`d088554`](https://github.com/immich-app/immich/commit/d08855404c01b00d6a97f0162d8cf6370383d8d3) better error message ### 📊 Changes **3 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/app/models/facial_recognition.py` (+2 -2) 📝 `machine-learning/app/models/image_classification.py` (+2 -2) 📝 `server/src/infra/repositories/machine-learning.repository.ts` (+4 -1) </details> ### 📄 Description ## Description This is a hot-fix in two respects: fixing the image classification model erroring if the model is not downloaded, and correctly setting the `minScore` config in image classification and facial recognition. If the model is not already downloaded and exported to ONNX, the `pipeline` function used for the first load validates the kwargs passed while the other code path does not. Additionally, the options sent are in camelCase while the check is currently for snake_case. Fixes #3915 ## How Has This Been Tested? I deleted the image classification model from the cache, restarted the containers and confirmed that each job runs without errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:16:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?