mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Fails to build with OpenSSL 1.1.1 #96
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @luusl on GitHub (Sep 19, 2018).
On my machine I have OpenSSL 1.1.1 installed and building fails according to this error:
@dani-garcia commented on GitHub (Sep 19, 2018):
This is a problem with the old
opensslcrate, which doesn't support OpenSSL 1.1.1. (See https://github.com/sfackler/rust-openssl/issues/994).We have two dependencies that require that
opensslversion:reqwest, which works fine in its version 0.9 andlettre, which needs a change (See open PR: https://github.com/lettre/lettre/pull/303)The solutions for now are to:
@dani-garcia commented on GitHub (Sep 19, 2018):
I pushed a fix with the second solution I mentioned here: https://github.com/dani-garcia/bitwarden_rs/tree/openssl-fix
Hopefully the PR is merged soon and we can continue using the upstream version directly.
@luusl commented on GitHub (Sep 20, 2018):
Thank you, I tried that branch and it works.
@dani-garcia commented on GitHub (Sep 20, 2018):
Okay, that PR was merged, so the OpenSSL fix is now in master. With that, we can mark this issue as fixed.
@chris-morgan commented on GitHub (Sep 23, 2018):
Any chance of a bitwarden_rs 1.1.1 release to go with the openssl 1.1.1?
@dani-garcia commented on GitHub (Sep 23, 2018):
You are right, we need a release.
As the changes since the last version are significant, I decided to release a 1.2.0 version. I hope that works for you.
https://github.com/dani-garcia/bitwarden_rs/releases/tag/1.2.0
@mprasil Can you trigger a docker build of the new version, please?
@mprasil commented on GitHub (Sep 24, 2018):
Just triggered it now, it's gonna take about 6h before all the image versions are done.
@dobunzli commented on GitHub (Sep 24, 2018):
Hello,
Thanks for the work. I want to update the READ ME but just to be sure:
Is that correct ?
Thanks
Dominique
@dani-garcia commented on GitHub (Sep 24, 2018):
I think it's
mprasil/bitwarden:alpineinstead ofmusl, but yeah.@mprasil commented on GitHub (Sep 24, 2018):
Just a small correction. People on
muslplatform don't have to usemprasil/bitwarden:alpine, the required platform dependencies are shipped in the image. So as long as you are onAMD64platform, you can use both images.I'm thinking that maybe we should replace the default Debian based image and just use Alpine as default?