mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Mail HELO localhost #736
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Don-Swanson on GitHub (Jul 2, 2020).
Subject of the issue
Emails being sent by the instance are often being blocked by corporate subscription spam filters because the HELO command is sending localhost as the sending mail server name. This is frowned upon and therefore usually listed as spam by many corporate filters.
Your environment
Steps to reproduce
Look at a pcap from email traffic
Expected behaviour
should list a server name
Actual behaviour
lists localhost
@dani-garcia commented on GitHub (Jul 5, 2020):
Checking the lettre configuration, there's an option to provide the HELO name, should I create an option for it, or is it enough to use the SMTP host as-is?
@Don-Swanson commented on GitHub (Jul 5, 2020):
Thanks for the quick response!
Preference would be to allow a configurable option, because another issue that would come up is if the server name presented doesn't match the reverse dns lookup of the IP (which in my case it wouldn't since its a docker container on a host with a different name and reverse dns.)
@dani-garcia commented on GitHub (Jul 5, 2020):
Okay, option
HELO_NAMEis added now in the SMTP settings in the latest commit:596c9b8691.The docker images will still take some hours to build, but once done I'd appreciate if you can give it a try!
@Don-Swanson commented on GitHub (Jul 8, 2020):
That did the trick! Thank you so much!