mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
Allow empty ADMIN_TOKEN when DISABLE_ADMIN_TOKEN is set to false #600
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Roxedus on GitHub (Feb 5, 2020).
Allow presenting the variable for the user(which in reality set it to NULL), but disabling the admin panel when DISABLE_ADMIN_TOKEN is explicit set to false
As you may be aware of trough #813, I control this template, and would like to present the user with the ability to use
ADMIN_TOKEN, in order to this I have to set it to NULL.The reason that I want to present it this way is because it is a easier way to set settings in favor of environment variables. This is only also the only way to get started without enabling signup afaik.
Expected behaviour
Using the environment variables
-e ADMIN_TOKEN=""AND-e DISABLE_ADMIN_TOKEN=falseshould not enable the admin panel, but still allow the container to run, due to explicit telling bitwarden to disallow insecure token, while the admin_token variable exists.Actual behaviour
Using the environment variables
-e ADMIN_TOKEN=""AND-e DISABLE_ADMIN_TOKEN=falsegives me the error about either removing/filling the admin_token@jjlin commented on GitHub (Apr 8, 2020):
It looks like this was fixed in
480ba93.@Roxedus commented on GitHub (Apr 9, 2020):
No, its not. That commit stops the container from running.
@jjlin commented on GitHub (Apr 9, 2020):
Yeah, my mistake. I'll send a fix for this later today.