mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-01 11:19:52 +03:00
Verification mail sending error IDN Domain #582
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Latschenharry on GitHub (Jan 29, 2020).
Bitwardenrs is unable to send an verification mail to an IDN Domain.
Your environment
Steps to reproduce
Create an account with an IDN domain mail
Expected behaviour
bitwardenrs is able to send the verification mail
Actual behaviour
bitwardenrs is unable to send the verification mail
[bitwarden_rs::api::core::accounts][ERROR] Error sending delete account email: Error building email. invalid email address
@dani-garcia commented on GitHub (Jan 29, 2020):
I'm not sure about your terminology, when you say IDN domain do you mean using non-ascii characters? And by ACE converted do mean punycode? (Starting with "xn--").
If so, I haven't tested it but we could consider converting the email internally, to make sure the library accepts it.
@Latschenharry commented on GitHub (Jan 30, 2020):
Yes its exactly as described by you.
IDN=Internationalized Domain Name so for example: überall-ist.de
ACE/punycode: xn--berall-ist-8db.de
An internal conversion would be very nice.
@dani-garcia commented on GitHub (Jan 31, 2020):
Okay, I've changed it to convert the domain to ascii now in
def174a517, can you give it a try? if you are using the docker images, those might take some hours to build still.@Latschenharry commented on GitHub (Jan 31, 2020):
Thank you very much for the fast help.
It works like it should.