mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-12-06 09:13:03 +03:00
Panic if temporary SMTP-Problem #504
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Subito on GitHub.
Subject of the issue
Sometimes on trying to send a 2FA-Mail, the SMTP Server replies with
454: 4.7.0 Temporary authentication failure, which should indicate to the sender "please try later, this is a temporary problem". However vaultwarden panics if it receives this error and the server stops.Deployment environment
Install method: FreeBSD pkg
Clients used: happens on all clients on Login
Reverse proxy and version: nginx
Other relevant details:
Expected behaviour
Server does not crash if it receives a temporary SMTP-Failure.
Actual behaviour
Server crashes and needs restarting.
Troubleshooting data
@Subito commented on GitHub:
Of course, just catching the error would be great. As you said: Any sort of queue-and-retry should be handled on a mailserver. But panicing on a simple SMTP-Error is probably not great. Just logging an error would be perfect.
@BlackDex commented on GitHub:
Vaultwarden does not have a retry mechanisch for these kind of scenarios. The message indicates a connection error.
Most of the time temp errors should be tried again after a few minutes, but this is not something Vaultwarden handles. I also do not thing Vaultwarden should handle those and try again actually. That kind of functionality belongs to mail servers, not clients.
We probably can catch this error and return an error instead of a panic though, that is probably nicer then a panic.