mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-05 00:29:40 +03:00
"disable admin token" in admin panel could be improved #441
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @My1 on GitHub (Oct 8, 2019).
the message "Disable Admin Token (Know the risks!)" is kinda ambigous as it can be read as to "disable the access to admin completely" instead of "let everyone in", similar to as how disabling passwords on SSH does not mean "do not require passwords" but rather "require a different auth mechanism, aka public keys"
@dani-garcia commented on GitHub (Oct 8, 2019):
You are definitely right that the naming is confusing, and something like "bypass admin security" might be more adecuate. We can easily change the description in the admin page, but changing the config option would be a breaking change (Though I think just the description would be good enough for now)
@My1 commented on GitHub (Oct 8, 2019):
exactly, especially considering you dont just get the env var out of nowhere and the wiki clearly states the purpose and stuff
@dani-garcia commented on GitHub (Oct 8, 2019):
Fixed in
662bc27523 (diff-6d8a5e2104954a026de2bfe2b936aea4), thanks!