[PR #17] [MERGED] Implement cipher sharing #3920

New Issue

OVERLORD · 2025-10-09T18:32:39+03:00

OVERLORD commented

2025-10-09 18:32:39 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/17
Author: @mprasil
Created: 5/14/2018
Status: ✅ Merged
Merged: 5/15/2018
Merged by: @dani-garcia

Base: master ← Head: share_cipher

📝 Commits (3)

8b18c4c Implement cipher sharing
f43d329 Don't clone() unused value
3b537f7 Remove unnecessary test and rewrite match

📊 Changes

3 files changed (+52 additions, -3 deletions)

View changed files

📝 src/api/core/ciphers.rs (+47 -3)
📝 src/api/core/mod.rs (+1 -0)
📝 src/db/models/organization.rs (+4 -0)

📄 Description

This implements sharing an user-owned Cipher to Organization.

For now this only implements functionality for user that has at least access_all rights to the organization. I think that it should be possible to share Cipher to a specific collection only if the user has write access, however this will require some update to update_cipher_from_data, which would probably be better handled in separate PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/17 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 5/14/2018 **Status:** ✅ Merged **Merged:** 5/15/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `share_cipher` --- ### 📝 Commits (3) - [`8b18c4c`](https://github.com/dani-garcia/vaultwarden/commit/8b18c4c633a27bb559a9c893cf121dbfc56161e5) Implement cipher sharing - [`f43d329`](https://github.com/dani-garcia/vaultwarden/commit/f43d329e2223919d98586f3a1d06881c5a14ffeb) Don't clone() unused value - [`3b537f7`](https://github.com/dani-garcia/vaultwarden/commit/3b537f70ac4713a7c689dc568777956d4d2dd2a2) Remove unnecessary test and rewrite match ### 📊 Changes **3 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+47 -3) 📝 `src/api/core/mod.rs` (+1 -0) 📝 `src/db/models/organization.rs` (+4 -0) </details> ### 📄 Description This implements sharing an user-owned Cipher to Organization. For now this only implements functionality for user that has at least `access_all` rights to the organization. I *think* that it should be possible to share Cipher to a specific collection only if the user has write access, however this will require some update to `update_cipher_from_data`, which would probably be better handled in separate PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:32:39 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3920