[PR #6676] [MERGED] improve sso callback path #3792

New Issue

Closed

opened 2026-02-05 05:44:54 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2026-02-05 05:44:54 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6676
Author: @stefan0xC
Created: 1/6/2026
Status: ✅ Merged
Merged: 1/6/2026
Merged by: @BlackDex

Base: main ← Head: improve-sso-callback-path

---

📝 Commits (2)

• 8f1a80b normalize base_url for sso_callback_path
• 7fdb4d4 clean url when embedding images

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/config.rs (+6 -2)

📄 Description

Currently we remove a trailing slash after making the config:
9f1df42259/src/config.rs (L309)

This means that the generated sso_callback_path is not yet normalized, which leads to some issues (e.g. https://github.com/dani-garcia/vaultwarden/issues/6180 or https://github.com/dani-garcia/vaultwarden/issues/6601).

This change would fix that by applying the same normalization to the generated URL.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6676 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 1/6/2026 **Status:** ✅ Merged **Merged:** 1/6/2026 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `improve-sso-callback-path` --- ### 📝 Commits (2) - [`8f1a80b`](https://github.com/dani-garcia/vaultwarden/commit/8f1a80be8c0a8493fa9163afefd1f1981e4b75e9) normalize base_url for sso_callback_path - [`7fdb4d4`](https://github.com/dani-garcia/vaultwarden/commit/7fdb4d433a86be7b7a25ae69043768bc03c079d4) clean url when embedding images ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/config.rs` (+6 -2) </details> ### 📄 Description Currently we remove a trailing slash after making the config: https://github.com/dani-garcia/vaultwarden/blob/9f1df422595cdfb04b8aea6968ae52a434887abc/src/config.rs#L309 This means that the generated `sso_callback_path` is not yet normalized, which leads to some issues (e.g. https://github.com/dani-garcia/vaultwarden/issues/6180 or https://github.com/dani-garcia/vaultwarden/issues/6601). This change would fix that by applying the same normalization to the generated URL. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2026-02-05 05:44:54 +03:00

OVERLORD closed this issue 2026-02-05 05:44:58 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

SSO

Third party

better for forum

bug

bug

documentation

duplicate

enhancement

future Vault

future Vault

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3792