[PR #226] [MERGED] Fix /sync without query string #3786

New Issue

OVERLORD · 2025-10-09T18:30:08+03:00

OVERLORD commented

2025-10-09 18:30:08 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/226
Author: @janost
Created: 10/19/2018
Status: ✅ Merged
Merged: 10/19/2018
Merged by: @dani-garcia

Base: master ← Head: fix-sync-without-query-string

📝 Commits (1)

daa66b0 Fix /sync without query string

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 src/api/core/ciphers.rs (+7 -0)
📝 src/api/core/mod.rs (+1 -0)

📄 Description

Due to Rocket being a bit weird with query strings currently (see this Rocket issue), my last change (#225) broke clients which call /sync without the ?excludeDomains= query string. At least the Firefox addon is affected.
Until Rocket releases their new query string parsing logic implemented here in 0.4.0, we're probably stuck with this rather ugly workaround.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/226 **Author:** [@janost](https://github.com/janost) **Created:** 10/19/2018 **Status:** ✅ Merged **Merged:** 10/19/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-sync-without-query-string` --- ### 📝 Commits (1) - [`daa66b0`](https://github.com/dani-garcia/vaultwarden/commit/daa66b08dc1c21f38710f8791d45f188702ccd17) Fix /sync without query string ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+7 -0) 📝 `src/api/core/mod.rs` (+1 -0) </details> ### 📄 Description Due to Rocket being a bit weird with query strings currently (see [this Rocket issue](https://github.com/SergioBenitez/Rocket/issues/376)), my last change (#225) broke clients which call `/sync` without the `?excludeDomains=` query string. At least the Firefox addon is affected. Until Rocket releases their new query string parsing logic [implemented here](https://github.com/SergioBenitez/Rocket/issues/608) in `0.4.0`, we're probably stuck with this rather ugly workaround. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:30:08 +03:00

OVERLORD closed this issue

2025-10-09 18:30:09 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3786