[PR #6202] feat: Add comprehensive Prometheus metrics support #3708

New Issue

OVERLORD · 2026-02-05T05:41:01+03:00

OVERLORD commented

2026-02-05 05:41:01 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6202
Author: @rossigee
Created: 8/20/2025
Status: 🔄 Open

Base: main ← Head: feature/prometheus-metrics

📝 Commits (7)

9ed01ae feat: add comprehensive Prometheus metrics support
0502936 Drop verbose metrics functionality description.
a4106ae Drop examples (should be in docs).
c9563d6 Remove introduced development dependency.
2b1e989 Whitespace fixes.
387c2e9 Merge branch 'main' into feature/prometheus-metrics
672a1e5 Add Prometheus metrics support

📊 Changes

18 files changed (+1113 additions, -12 deletions)

View changed files

📝 Cargo.lock (+16 -0)
📝 Cargo.toml (+8 -0)
📝 README.md (+1 -0)
📝 docker/Dockerfile.alpine (+1 -1)
📝 docker/Dockerfile.debian (+1 -1)
📝 docker/Dockerfile.j2 (+2 -2)
📝 src/api/identity.rs (+7 -2)
➕ src/api/metrics.rs (+98 -0)
➕ src/api/middleware.rs (+176 -0)
📝 src/api/mod.rs (+4 -0)
📝 src/api/web.rs (+3 -1)
📝 src/config.rs (+34 -0)
📝 src/db/models/cipher.rs (+68 -0)
📝 src/db/models/organization.rs (+10 -0)
📝 src/db/models/user.rs (+22 -0)
📝 src/main.rs (+29 -5)
➕ src/metrics.rs (+456 -0)
➕ src/metrics_test.rs (+177 -0)

📄 Description

Summary

This PR adds comprehensive Prometheus metrics support to Vaultwarden, providing observability into application performance, database health, authentication patterns, and business metrics.

Key Features

Optional metrics endpoint at /metrics (disabled by default)
Token-based authentication with support for plain text and Argon2 hashed tokens
Comprehensive metric categories: HTTP, database, authentication, business, and system metrics
Secure by default: Feature must be explicitly enabled and compiled with --features enable_metrics
Production-ready: Path normalization prevents metric explosion, proper error handling

Metrics Categories

HTTP Metrics: Request rates, response times, status codes by endpoint
Database Metrics: Connection pool utilization, query performance
Authentication Metrics: Login attempts, session counts by method and status
Business Metrics: User counts, vault items by type, organization data
System Metrics: Uptime, build information, version details

Security Considerations

Disabled by default - requires explicit ENABLE_METRICS=true
Token authentication prevents unauthorized access
Path normalization prevents high cardinality issues
Network isolation recommended for production

Documentation

Complete configuration guide in METRICS.md
Comprehensive monitoring setup in MONITORING.md
Prometheus/Grafana examples and alerting rules
Security best practices and troubleshooting

Test Plan

Metrics compilation with feature flag
Authentication (no token, valid token, invalid token)
Metric format validation (Prometheus format)
All metric categories populated correctly
Path normalization working
Docker build with metrics feature
Security token hashing (Argon2)

Breaking Changes

None - this is an optional feature that's disabled by default.

Files Added/Modified

New: src/api/metrics.rs - Metrics endpoint implementation
New: METRICS.md - Configuration and usage guide
New: MONITORING.md - Complete monitoring setup guide
New: examples/metrics-config.env - Configuration examples
New: scripts/test-metrics.sh - Testing script
Modified: Cargo.toml - Added optional prometheus dependency
Modified: README.md - Added metrics feature documentation
Modified: docker/Dockerfile.debian - Support for extra features in build

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6202 **Author:** [@rossigee](https://github.com/rossigee) **Created:** 8/20/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature/prometheus-metrics` --- ### 📝 Commits (7) - [`9ed01ae`](https://github.com/dani-garcia/vaultwarden/commit/9ed01ae9eb38469ad3be79596b43316079d88530) feat: add comprehensive Prometheus metrics support - [`0502936`](https://github.com/dani-garcia/vaultwarden/commit/05029365ee08669ab69a8ed7c2aedf927149132e) Drop verbose metrics functionality description. - [`a4106ae`](https://github.com/dani-garcia/vaultwarden/commit/a4106aeb4c35d7cacaf7f8e68727e8d454f3be11) Drop examples (should be in docs). - [`c9563d6`](https://github.com/dani-garcia/vaultwarden/commit/c9563d6c241110044b47e196799ffb0451e8a402) Remove introduced development dependency. - [`2b1e989`](https://github.com/dani-garcia/vaultwarden/commit/2b1e9890dc7e1578852e5a18bb8810eddc91407c) Whitespace fixes. - [`387c2e9`](https://github.com/dani-garcia/vaultwarden/commit/387c2e90829ba15713d05db9cf7b91a88fa77163) Merge branch 'main' into feature/prometheus-metrics - [`672a1e5`](https://github.com/dani-garcia/vaultwarden/commit/672a1e5c7207a10fd04365ce66cc953695be5f7d) Add Prometheus metrics support ### 📊 Changes **18 files changed** (+1113 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+16 -0) 📝 `Cargo.toml` (+8 -0) 📝 `README.md` (+1 -0) 📝 `docker/Dockerfile.alpine` (+1 -1) 📝 `docker/Dockerfile.debian` (+1 -1) 📝 `docker/Dockerfile.j2` (+2 -2) 📝 `src/api/identity.rs` (+7 -2) ➕ `src/api/metrics.rs` (+98 -0) ➕ `src/api/middleware.rs` (+176 -0) 📝 `src/api/mod.rs` (+4 -0) 📝 `src/api/web.rs` (+3 -1) 📝 `src/config.rs` (+34 -0) 📝 `src/db/models/cipher.rs` (+68 -0) 📝 `src/db/models/organization.rs` (+10 -0) 📝 `src/db/models/user.rs` (+22 -0) 📝 `src/main.rs` (+29 -5) ➕ `src/metrics.rs` (+456 -0) ➕ `src/metrics_test.rs` (+177 -0) </details> ### 📄 Description ## Summary This PR adds comprehensive Prometheus metrics support to Vaultwarden, providing observability into application performance, database health, authentication patterns, and business metrics. ### Key Features - **Optional metrics endpoint** at `/metrics` (disabled by default) - **Token-based authentication** with support for plain text and Argon2 hashed tokens - **Comprehensive metric categories**: HTTP, database, authentication, business, and system metrics - **Secure by default**: Feature must be explicitly enabled and compiled with `--features enable_metrics` - **Production-ready**: Path normalization prevents metric explosion, proper error handling ### Metrics Categories - **HTTP Metrics**: Request rates, response times, status codes by endpoint - **Database Metrics**: Connection pool utilization, query performance - **Authentication Metrics**: Login attempts, session counts by method and status - **Business Metrics**: User counts, vault items by type, organization data - **System Metrics**: Uptime, build information, version details ### Security Considerations - Disabled by default - requires explicit `ENABLE_METRICS=true` - Token authentication prevents unauthorized access - Path normalization prevents high cardinality issues - Network isolation recommended for production ### Documentation - Complete configuration guide in `METRICS.md` - Comprehensive monitoring setup in `MONITORING.md` - Prometheus/Grafana examples and alerting rules - Security best practices and troubleshooting ### Test Plan - [x] Metrics compilation with feature flag - [x] Authentication (no token, valid token, invalid token) - [x] Metric format validation (Prometheus format) - [x] All metric categories populated correctly - [x] Path normalization working - [x] Docker build with metrics feature - [x] Security token hashing (Argon2) ### Breaking Changes None - this is an optional feature that's disabled by default. ### Files Added/Modified - New: `src/api/metrics.rs` - Metrics endpoint implementation - New: `METRICS.md` - Configuration and usage guide - New: `MONITORING.md` - Complete monitoring setup guide - New: `examples/metrics-config.env` - Configuration examples - New: `scripts/test-metrics.sh` - Testing script - Modified: `Cargo.toml` - Added optional prometheus dependency - Modified: `README.md` - Added metrics feature documentation - Modified: `docker/Dockerfile.debian` - Support for extra features in build --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 05:41:01 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3708