[PR #864] [MERGED] Do not disable invitations via admin API #3617

New Issue

Closed

opened 2025-10-09 18:26:48 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:26:48 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/864
Author: @mprasil
Created: 2/16/2020
Status: ✅ Merged
Merged: 2/17/2020
Merged by: @dani-garcia

Base: master ← Head: admin-invitation

---

📝 Commits (2)

• 0a72c4b Do not disable invitations via admin API
• 0323342 Remove check from Invitation:take()

📊 Changes

2 files changed (+4 additions, -9 deletions)

View changed files

📝 src/api/admin.rs (+0 -4)
📝 src/db/models/user.rs (+4 -5)

📄 Description

This was brought up today:

https://github.com/dani-garcia/bitwarden_rs/issues/752#issuecomment-586715073

I don't think it makes much sense in checking whether admin has the
right to send invitation as admin can change the setting anyway.

Removing the condition allows users to forbid regular users from
inviting new users to server while still preserving the option to do so
via the admin API.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/864 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 2/16/2020 **Status:** ✅ Merged **Merged:** 2/17/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `admin-invitation` --- ### 📝 Commits (2) - [`0a72c4b`](https://github.com/dani-garcia/vaultwarden/commit/0a72c4b6db4e254d7579b8dc3bb6e9e3c067947d) Do not disable invitations via admin API - [`0323342`](https://github.com/dani-garcia/vaultwarden/commit/03233429f4475de558c58707224d1cf72aa28c42) Remove check from Invitation:take() ### 📊 Changes **2 files changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+0 -4) 📝 `src/db/models/user.rs` (+4 -5) </details> ### 📄 Description This was brought up today: https://github.com/dani-garcia/bitwarden_rs/issues/752#issuecomment-586715073 I don't think it makes much sense in checking whether admin has the right to send invitation as admin can change the setting anyway. Removing the condition allows users to forbid regular users from inviting new users to server while still preserving the option to do so via the admin API. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:26:49 +03:00

OVERLORD closed this issue 2025-10-09 18:26:51 +03:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3617