[PR #901] [MERGED] Use opportunistic TLS in SMTP connections #3606

New Issue

OVERLORD · 2025-10-09T18:26:37+03:00

OVERLORD commented

2025-10-09 18:26:37 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/901
Author: @sleweke
Created: 3/12/2020
Status: ✅ Merged
Merged: 3/14/2020
Merged by: @dani-garcia

Base: master ← Head: feature/opportunistic_tls

📝 Commits (1)

5d3b765 Use opportunistic TLS in SMTP connections

📊 Changes

1 file changed (+9 additions, -9 deletions)

View changed files

📝 src/mail.rs (+9 -9)

📄 Description

If SSL is disabled, the SMTP ClientSecurity of the lettre crate defaults to None, that is, an insecure connection.
This is changed to Opportunistic, which uses TLS if available.
If TLS is not available, an insecure connection is used (i.e., this change is backward compatible).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/901 **Author:** [@sleweke](https://github.com/sleweke) **Created:** 3/12/2020 **Status:** ✅ Merged **Merged:** 3/14/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `feature/opportunistic_tls` --- ### 📝 Commits (1) - [`5d3b765`](https://github.com/dani-garcia/vaultwarden/commit/5d3b765a238f6df35e3233499d6da763ad7c6cd8) Use opportunistic TLS in SMTP connections ### 📊 Changes **1 file changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/mail.rs` (+9 -9) </details> ### 📄 Description If SSL is disabled, the SMTP `ClientSecurity` of the `lettre` crate defaults to `None`, that is, an insecure connection. This is changed to `Opportunistic`, which uses TLS if available. If TLS is not available, an insecure connection is used (i.e., this change is backward compatible). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:26:37 +03:00

OVERLORD closed this issue

2025-10-09 18:26:38 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3606